All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hailiang Zhang <zhang.zhanghailiang@huawei.com>
To: Eric Blake <eblake@redhat.com>
Cc: <armbru@redhat.com>, <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-trivial] [PATCH] qapi-schema: clarify 'colo' state for MigrationStatus
Date: Wed, 2 Nov 2016 15:28:16 +0800	[thread overview]
Message-ID: <58199590.6080805@huawei.com> (raw)
In-Reply-To: <29570f3d-1a97-8b5a-7b0d-628c61004cc0@redhat.com>

On 2016/11/1 22:28, Eric Blake wrote:
> On 11/01/2016 12:51 AM, zhanghailiang wrote:
>> VM can not get into colo state unless users enable 'x-colo'
>> capability for migration, Here it is necessary to clarify
>> this.
>>
>> Suggested-by: Eric Blake <eblake@redhat.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>> ---
>>   qapi-schema.json | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/qapi-schema.json b/qapi-schema.json
>> index 8a7b527..d580169 100644
>> --- a/qapi-schema.json
>> +++ b/qapi-schema.json
>> @@ -462,7 +462,8 @@
>>   #
>>   # @failed: some error occurred during migration process.
>>   #
>> -# @colo: VM is in the process of fault tolerance. (since 2.8)
>> +# @colo: VM is in the process of fault tolerance, VM can not get into this
>> +#        state unless colo capability is enabled for migration. (since 2.8)
>
> This hunk is for MigrationStatus; can you also add similar wording for
> the documentation of RunState?  Looking forward to v2.
>

OK, no problem, will send v2.



  reply	other threads:[~2016-11-02  7:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-01  5:51 [Qemu-trivial] [PATCH] qapi-schema: clarify 'colo' state for MigrationStatus zhanghailiang
2016-11-01 14:28 ` Eric Blake
2016-11-02  7:28   ` Hailiang Zhang [this message]
2016-11-02  7:18 ` Markus Armbruster
2016-11-02  7:28   ` Hailiang Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58199590.6080805@huawei.com \
    --to=zhang.zhanghailiang@huawei.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.