From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760563AbcKDNJN (ORCPT ); Fri, 4 Nov 2016 09:09:13 -0400 Received: from mga01.intel.com ([192.55.52.88]:63511 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753178AbcKDNJL (ORCPT ); Fri, 4 Nov 2016 09:09:11 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,443,1473145200"; d="scan'208";a="187609683" Subject: Re: [PATCH 1/1] usb: xhci: remove the use of xhci->addr_dev To: Lu Baolu References: <1478053836-26027-1-git-send-email-baolu.lu@linux.intel.com> Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Mathias Nyman Message-ID: <581C8877.1060301@linux.intel.com> Date: Fri, 4 Nov 2016 15:09:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1478053836-26027-1-git-send-email-baolu.lu@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02.11.2016 04:30, Lu Baolu wrote: > xhci->addr_dev is used for the completion of both address device > and enable slot commands. It's shared by enumerations of all USB > devices connected to an xhci host. Hence, it's just a source for > possible races. Since we've introduced command structure and the > command queue to xhci driver. It is time to get rid of addr_dev > and use the completion in the command structure instead. > > Signed-off-by: Lu Baolu Thanks, applied to my tree -Mathias