All of lore.kernel.org
 help / color / mirror / Atom feed
From: linz  <powertree@163.com>
To: "Jan Kiszka" <jan.kiszka@siemens.com>
Cc: "Florian Bezdeka" <florian.bezdeka@siemens.com>,
	"Philippe Gerum" <rpm@xenomai.org>,
	xenomai@lists.linux.dev
Subject: [PATCH v2] irqchip: gic-v3-its: irq_pipeline: fix OOB context in-band lock warning for ITS lock using hard spinlocks instead of hybrid spinlocks
Date: Mon, 13 Jul 2026 18:42:33 +0800 (CST)	[thread overview]
Message-ID: <581e35af.92dd.19f5b124b8a.Coremail.powertree@163.com> (raw)
In-Reply-To: <6ca12451-a015-4b54-9e22-0256e97d834e@siemens.com>

Thank you for your feedback


The gic-v3 IRQ chip is already marked with IRQCHIP_PIPELINE_SAFE. The its_irq_chip is not marked with IRQCHIP_PIPELINE_SAFE. I added the flag and tested, but it did not have any effect.

Meanwhile, I read the code related to IRQCHIP_PIPELINE_SAFE. If the gic-v3 IRQ chip is not marked with IRQCHIP_PIPELINE_SAFE, a call trace like the following would be reported:
MSI domain irqchip XXX is not pipeline-safe! or irqchip XXX is not pipeline-safe!
However, I did not see any such message in my logs.

Based on Florian's suggestion, I revisited the Xenomai 4 documentation regarding hybrid_spinlock_t and hard_spinlock_t. 
I agree with Florian's point that hybrid_spinlock_t should be limited to struct irq_desc and IRQ chips, and that hard_spinlock_t is more appropriate for the ITS node lock.

I changed the lock to hard_spinlock_t and tested it. The call trace no longer appears and the system works fine.

The patch is as follows. Please help review it:

From e0cbc9316af331bf007c86e1fcab0ef8699b05c9 Mon Sep 17 00:00:00 2001
From: zhanglin1040 <powertree@163.com>
Date: Mon, 13 Jul 2026 17:53:44 +0800
Subject: [PATCH] irqchip: gic-v3-its: irq_pipeline: fix OOB context in-band
 lock warning for ITS lock using hard spinlocks instead of hybrid spinlocks

---
 drivers/irqchip/irq-gic-v3-its.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
index 0e57735eac..3f2b02b8f4 100644
--- a/drivers/irqchip/irq-gic-v3-its.c
+++ b/drivers/irqchip/irq-gic-v3-its.c
@@ -94,7 +94,7 @@ struct its_device;
  * list.
  */
 struct its_node {
-    raw_spinlock_t        lock;
+    hard_spinlock_t        lock;
     struct mutex        dev_alloc_lock;
     struct list_head    entry;
     void __iomem        *base;
-- 
2.34.1

  reply	other threads:[~2026-07-13 10:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-25  9:32 [PATCH] irqchip: gic-v3-its: irq_pipeline: Fix OOB context in-band lock warning for ITS lock linz
2026-07-10 10:12 ` Jan Kiszka
2026-07-10 10:59   ` Florian Bezdeka
2026-07-13 10:20     ` linz
2026-07-13 10:29       ` Jan Kiszka
2026-07-13 10:42         ` linz [this message]
2026-07-13 10:50           ` [PATCH v2] irqchip: gic-v3-its: irq_pipeline: fix OOB context in-band lock warning for ITS lock using hard spinlocks instead of hybrid spinlocks Jan Kiszka
2026-07-14  3:43         ` [PATCH v2] irqchip: gic-v3-its: irq_pipeline: Fix OOB context in-band lock warning for ITS lock linz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=581e35af.92dd.19f5b124b8a.Coremail.powertree@163.com \
    --to=powertree@163.com \
    --cc=florian.bezdeka@siemens.com \
    --cc=jan.kiszka@siemens.com \
    --cc=rpm@xenomai.org \
    --cc=xenomai@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.