Re: master branch merges must pass unit tests

[Loic Dachary <loic@dachary.org>]

On 09/11/2016 00:34, Sage Weil wrote:
> On Tue, 8 Nov 2016, Sage Weil wrote:
>> I enabled the github check that the unit tests pass in order to merge to 
>> master.  These tests still aren't completely reliable, but they're close, 
>> and we'll make better progress if we start enforcing it now.
> 
> I went a bit further and also checked the box requiring a review and 
> preventing pushes directly to master branch.  These are already uneforced 
> requirements so this shouldn't slow people down *except* that we need to 
> start using the new github 'review' feature that lets you explicitly 
> approve changes.
> 
> Again, the core developers can override these restrictions if necessary.
> 
> I haven't done anything to the stable branches, but we might want to do 
> the same thing there...

Good move :-) I will do the same for the stable branches.

Cheers

-- 
Loïc Dachary, Artisan Logiciel Libre