From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH] [RFC] net: phy: phy drivers should not set SUPPORTED_Pause or SUPPORTED_Asym_Pause Date: Wed, 9 Nov 2016 11:34:02 -0600 Message-ID: <58235E0A.2030305@codeaurora.org> References: <1478020715-25578-1-git-send-email-timur@codeaurora.org> <5820AC1D.4040408@codeaurora.org> <582238F3.30906@codeaurora.org> <26a8fde2-6403-b14e-a163-c3a1b6afeb4d@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Florian Fainelli , David Miller , netdev@vger.kernel.org Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:40536 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752186AbcKIRoi (ORCPT ); Wed, 9 Nov 2016 12:44:38 -0500 In-Reply-To: <26a8fde2-6403-b14e-a163-c3a1b6afeb4d@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On 11/09/2016 11:06 AM, Florian Fainelli wrote: >> 1) PHY drivers and/or phylib sets the SUPPORTED_Pause | >> SUPPORTED_AsymPause bits in phydev->supported. This indicates that the >> PHY supports pause frames. > > Agreed. So I'm still not sure *where* phylib should set the bits in phydev->supported. I previously thought that phy_sanitize_settings() would be a candidate, but that function is called only when autonegotiation is disabled. So the only thing I can think of is to do this: /* A mapping of all SUPPORTED settings to speed/duplex */ static const struct phy_setting settings[] = { { .speed = SPEED_10000, .duplex = DUPLEX_FULL, - .setting = SUPPORTED_10000baseKR_Full, + .setting = SUPPORTED_10000baseKR_Full | + SUPPORTED_Pause | SUPPORTED_Asym_Pause, ... for all of the entries in settings[] But this seems excessive, and I don't know if all of these SPEED_xxx standards actually support pause frames. >> >3) When the link state changes, the MAC driver checks >> >phydev->advertising, and if the bits are set, then it enables those >> >features in the MAC. > Almost, we need to see what the link partner advertised, by looking at > phydev->pause / phydev->asym_pause and checking the local knobs whether > flow control can be enabled, but other than that, this looks correct to me. Yes, that's what I meant to write. Fortunately, my EMAC driver already does this. -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.