diff for duplicates of <58237383.4070506@iogearbox.net> diff --git a/a/1.txt b/N1/1.txt index 9b7261a..61b5ac3 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -6,7 +6,7 @@ On 11/09/2016 06:06 PM, Brenden Blanco wrote: >>>>> There are rx_ring_num queues. Each queue will load xdp prog. So >>>>> bpf_prog_add() should add rx_ring_num to ref_cnt. >>>>> ->>>>> Signed-off-by: Zhiyi Sun <zhiyisun-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> +>>>>> Signed-off-by: Zhiyi Sun <zhiyisun@gmail.com> >>>> >>>> Your analysis looks incorrect to me. Please elaborate in more detail why >>>> you think current code is buggy ... @@ -30,8 +30,8 @@ On 11/09/2016 06:06 PM, Brenden Blanco wrote: >> bpf_prog_add(rq->xdp_prog, 1) without actually checking for errors. > >> From d2bd6b3cd8636716a06b0ea3b1e041e16f87cce0 Mon Sep 17 00:00:00 2001 ->> Message-Id: <d2bd6b3cd8636716a06b0ea3b1e041e16f87cce0.1478685278.git.daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org> ->> From: Daniel Borkmann <daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org> +>> Message-Id: <d2bd6b3cd8636716a06b0ea3b1e041e16f87cce0.1478685278.git.daniel@iogearbox.net> +>> From: Daniel Borkmann <daniel@iogearbox.net> >> Date: Wed, 9 Nov 2016 10:31:19 +0100 >> Subject: [PATCH net-next 1/2] bpf, mlx4: fix prog refcount in mlx4_en_try_alloc_resources error path >> @@ -45,7 +45,7 @@ On 11/09/2016 06:06 PM, Brenden Blanco wrote: >> bpf_prog_put() due to the propagated error. >> >> Fixes: 67f8b1dcb9ee ("net/mlx4_en: Refactor the XDP forwarding rings scheme") ->> Signed-off-by: Daniel Borkmann <daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org> +>> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> >> --- >> drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 5 ++++- >> include/linux/bpf.h | 1 + @@ -117,10 +117,10 @@ have one reference already. >> 1.9.3 > >> From f0789544432bbb89c53c3b8ac6575d48fed97786 Mon Sep 17 00:00:00 2001 ->> Message-Id: <f0789544432bbb89c53c3b8ac6575d48fed97786.1478685278.git.daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org> ->> In-Reply-To: <d2bd6b3cd8636716a06b0ea3b1e041e16f87cce0.1478685278.git.daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org> ->> References: <d2bd6b3cd8636716a06b0ea3b1e041e16f87cce0.1478685278.git.daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org> ->> From: Daniel Borkmann <daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org> +>> Message-Id: <f0789544432bbb89c53c3b8ac6575d48fed97786.1478685278.git.daniel@iogearbox.net> +>> In-Reply-To: <d2bd6b3cd8636716a06b0ea3b1e041e16f87cce0.1478685278.git.daniel@iogearbox.net> +>> References: <d2bd6b3cd8636716a06b0ea3b1e041e16f87cce0.1478685278.git.daniel@iogearbox.net> +>> From: Daniel Borkmann <daniel@iogearbox.net> >> Date: Wed, 9 Nov 2016 10:51:26 +0100 >> Subject: [PATCH net-next 2/2] bpf, mlx5: fix prog refcount in mlx5e_xdp_set >> @@ -130,7 +130,7 @@ have one reference already. >> for errors here. >> >> Fixes: 86994156c736 ("net/mlx5e: XDP fast RX drop bpf programs support") ->> Signed-off-by: Daniel Borkmann <daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org> +>> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> >> --- >> drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 -- >> 1 file changed, 2 deletions(-) @@ -157,7 +157,3 @@ instead. Thanks, Daniel --- -To unsubscribe from this list: send the line "unsubscribe linux-rdma" in -the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 2434792..1c5f124 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,18 +3,17 @@ "ref\020161109094546.jtmzc4xwtaavzcnt@ubuntu\0" "ref\05822F30C.1050900@iogearbox.net\0" "ref\020161109170615.GB10428@gmail.com\0" - "ref\020161109170615.GB10428-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org\0" - "From\0Daniel Borkmann <daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org>\0" + "From\0Daniel Borkmann <daniel@iogearbox.net>\0" "Subject\0Re: [PATCH] net/mlx4_en: Fix bpf_prog_add ref_cnt in mlx4\0" "Date\0Wed, 09 Nov 2016 20:05:39 +0100\0" - "To\0Brenden Blanco <bblanco-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org>\0" - "Cc\0Zhiyi Sun <zhiyisun-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>" - Tariq Toukan <tariqt-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> - Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> - netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - " alexei.starovoitov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org\0" + "To\0Brenden Blanco <bblanco@plumgrid.com>\0" + "Cc\0Zhiyi Sun <zhiyisun@gmail.com>" + Tariq Toukan <tariqt@mellanox.com> + Yishai Hadas <yishaih@mellanox.com> + netdev@vger.kernel.org + linux-rdma@vger.kernel.org + linux-kernel@vger.kernel.org + " alexei.starovoitov@gmail.com\0" "\00:1\0" "b\0" "On 11/09/2016 06:06 PM, Brenden Blanco wrote:\n" @@ -25,7 +24,7 @@ ">>>>> There are rx_ring_num queues. Each queue will load xdp prog. So\n" ">>>>> bpf_prog_add() should add rx_ring_num to ref_cnt.\n" ">>>>>\n" - ">>>>> Signed-off-by: Zhiyi Sun <zhiyisun-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\n" + ">>>>> Signed-off-by: Zhiyi Sun <zhiyisun@gmail.com>\n" ">>>>\n" ">>>> Your analysis looks incorrect to me. Please elaborate in more detail why\n" ">>>> you think current code is buggy ...\n" @@ -49,8 +48,8 @@ ">> bpf_prog_add(rq->xdp_prog, 1) without actually checking for errors.\n" ">\n" ">> From d2bd6b3cd8636716a06b0ea3b1e041e16f87cce0 Mon Sep 17 00:00:00 2001\n" - ">> Message-Id: <d2bd6b3cd8636716a06b0ea3b1e041e16f87cce0.1478685278.git.daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org>\n" - ">> From: Daniel Borkmann <daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org>\n" + ">> Message-Id: <d2bd6b3cd8636716a06b0ea3b1e041e16f87cce0.1478685278.git.daniel@iogearbox.net>\n" + ">> From: Daniel Borkmann <daniel@iogearbox.net>\n" ">> Date: Wed, 9 Nov 2016 10:31:19 +0100\n" ">> Subject: [PATCH net-next 1/2] bpf, mlx4: fix prog refcount in mlx4_en_try_alloc_resources error path\n" ">>\n" @@ -64,7 +63,7 @@ ">> bpf_prog_put() due to the propagated error.\n" ">>\n" ">> Fixes: 67f8b1dcb9ee (\"net/mlx4_en: Refactor the XDP forwarding rings scheme\")\n" - ">> Signed-off-by: Daniel Borkmann <daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org>\n" + ">> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>\n" ">> ---\n" ">> drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 5 ++++-\n" ">> include/linux/bpf.h | 1 +\n" @@ -136,10 +135,10 @@ ">> 1.9.3\n" ">\n" ">> From f0789544432bbb89c53c3b8ac6575d48fed97786 Mon Sep 17 00:00:00 2001\n" - ">> Message-Id: <f0789544432bbb89c53c3b8ac6575d48fed97786.1478685278.git.daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org>\n" - ">> In-Reply-To: <d2bd6b3cd8636716a06b0ea3b1e041e16f87cce0.1478685278.git.daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org>\n" - ">> References: <d2bd6b3cd8636716a06b0ea3b1e041e16f87cce0.1478685278.git.daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org>\n" - ">> From: Daniel Borkmann <daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org>\n" + ">> Message-Id: <f0789544432bbb89c53c3b8ac6575d48fed97786.1478685278.git.daniel@iogearbox.net>\n" + ">> In-Reply-To: <d2bd6b3cd8636716a06b0ea3b1e041e16f87cce0.1478685278.git.daniel@iogearbox.net>\n" + ">> References: <d2bd6b3cd8636716a06b0ea3b1e041e16f87cce0.1478685278.git.daniel@iogearbox.net>\n" + ">> From: Daniel Borkmann <daniel@iogearbox.net>\n" ">> Date: Wed, 9 Nov 2016 10:51:26 +0100\n" ">> Subject: [PATCH net-next 2/2] bpf, mlx5: fix prog refcount in mlx5e_xdp_set\n" ">>\n" @@ -149,7 +148,7 @@ ">> for errors here.\n" ">>\n" ">> Fixes: 86994156c736 (\"net/mlx5e: XDP fast RX drop bpf programs support\")\n" - ">> Signed-off-by: Daniel Borkmann <daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org>\n" + ">> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>\n" ">> ---\n" ">> drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 2 --\n" ">> 1 file changed, 2 deletions(-)\n" @@ -175,10 +174,6 @@ "instead.\n" "\n" "Thanks,\n" - "Daniel\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-rdma\" in\n" - "the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + Daniel -aa2a5c7c75c32b69999935fd5a6654a6c8798f56585947d75ece8cf08eeb13bf +05903bb972a0ac8edf695c137e755f00ca5ca6113a6a92d7aabae986289fa746
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.