From: Denis Kenzior <denkenz@gmail.com>
To: ell@lists.01.org
Subject: Re: [PATCH] dbus: Don't send replies to messages with no reply flag
Date: Wed, 09 Nov 2016 14:16:09 -0600 [thread overview]
Message-ID: <58238409.4060507@gmail.com> (raw)
In-Reply-To: <1478686966-15117-1-git-send-email-andrew.zaborowski@intel.com>
[-- Attachment #1: Type: text/plain, Size: 697 bytes --]
Hi Andrew,
On 11/09/2016 04:22 AM, Andrew Zaborowski wrote:
> Kdbus doesn't store the cookies for messages that have the no reply flag
> and throws error when a reply is sent with reply_cookie that it doesn't
> know. It's not fatal, but we save some cycles by not sending the message
> with both dbus versions.
>
> We mark those replies with reply_serial == 0, rather than setting a
> "discard" flag on the message, because the method call's serial is
> effectively an invalid reply_serial value.
> ---
> ell/dbus-message.c | 10 +++++++---
> ell/dbus.c | 10 ++++++++++
> 2 files changed, 17 insertions(+), 3 deletions(-)
>
Applied, thanks.
Regards,
-Denis
next prev parent reply other threads:[~2016-11-09 20:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 10:22 [PATCH] dbus: Don't send replies to messages with no reply flag Andrew Zaborowski
2016-11-09 20:16 ` Denis Kenzior [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-04-18 14:31 [PATCH 1/2] dbus: Add private _dbus_message_new_error Andrew Zaborowski
2016-04-18 14:31 ` [PATCH] dbus: Don't send replies to messages with no reply flag Andrew Zaborowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58238409.4060507@gmail.com \
--to=denkenz@gmail.com \
--cc=ell@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.