From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Date: Fri, 11 Nov 2016 01:45:00 +0000 Subject: Re: [PATCH] drm/rockchip: return ERR_PTR instead of NULL Message-Id: <5825229C.8080704@rock-chips.com> List-Id: References: <1478812256-26189-1-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1478812256-26189-1-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Christophe JAILLET , linux-arm-kernel@lists.infradead.org On 2016年11月11日 05:10, Julia Lawall wrote: > rockchip_drm_framebuffer_init is only used in one case, in > rockchip_drm_fbdev.c, where its return value is tested using IS_ERR. To > enable propagating the reason for the error, change the definition so that > it returns an ERR_PTR value. > > Problem found with the help of Coccinelle. > > Signed-off-by: Julia Lawall Thanks for the fix. Applied to my drm-next. > > --- > drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c > index 0f6eda0..01e11bf 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c > @@ -213,7 +213,7 @@ struct drm_framebuffer * > > rockchip_fb = rockchip_fb_alloc(dev, mode_cmd, &obj, 1); > if (IS_ERR(rockchip_fb)) > - return NULL; > + return ERR_CAST(rockchip_fb); > > return &rockchip_fb->fb; > } > > > > -- Ｍark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH] drm/rockchip: return ERR_PTR instead of NULL Date: Fri, 11 Nov 2016 09:45:00 +0800 Message-ID: <5825229C.8080704@rock-chips.com> References: <1478812256-26189-1-git-send-email-Julia.Lawall@lip6.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1478812256-26189-1-git-send-email-Julia.Lawall@lip6.fr> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Julia Lawall Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Christophe JAILLET , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gMjAxNuW5tDEx5pyIMTHml6UgMDU6MTAsIEp1bGlhIExhd2FsbCB3cm90ZToKPiByb2NrY2hp cF9kcm1fZnJhbWVidWZmZXJfaW5pdCBpcyBvbmx5IHVzZWQgaW4gb25lIGNhc2UsIGluCj4gcm9j a2NoaXBfZHJtX2ZiZGV2LmMsIHdoZXJlIGl0cyByZXR1cm4gdmFsdWUgaXMgdGVzdGVkIHVzaW5n IElTX0VSUi4gIFRvCj4gZW5hYmxlIHByb3BhZ2F0aW5nIHRoZSByZWFzb24gZm9yIHRoZSBlcnJv ciwgY2hhbmdlIHRoZSBkZWZpbml0aW9uIHNvIHRoYXQKPiBpdCByZXR1cm5zIGFuIEVSUl9QVFIg dmFsdWUuCj4KPiBQcm9ibGVtIGZvdW5kIHdpdGggdGhlIGhlbHAgb2YgQ29jY2luZWxsZS4KPgo+ IFNpZ25lZC1vZmYtYnk6IEp1bGlhIExhd2FsbCA8SnVsaWEuTGF3YWxsQGxpcDYuZnI+ClRoYW5r cyBmb3IgdGhlIGZpeC4KCkFwcGxpZWQgdG8gbXkgZHJtLW5leHQuCgo+Cj4gLS0tCj4gICBkcml2 ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX2ZiLmMgfCAgICAyICstCj4gICAxIGZp bGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPgo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX2ZiLmMgYi9kcml2ZXJzL2dw dS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX2ZiLmMKPiBpbmRleCAwZjZlZGEwLi4wMWUxMWJm IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fZmIu Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fZmIuYwo+IEBA IC0yMTMsNyArMjEzLDcgQEAgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqCj4gICAKPiAgIAlyb2Nr Y2hpcF9mYiA9IHJvY2tjaGlwX2ZiX2FsbG9jKGRldiwgbW9kZV9jbWQsICZvYmosIDEpOwo+ICAg CWlmIChJU19FUlIocm9ja2NoaXBfZmIpKQo+IC0JCXJldHVybiBOVUxMOwo+ICsJCXJldHVybiBF UlJfQ0FTVChyb2NrY2hpcF9mYik7Cj4gICAKPiAgIAlyZXR1cm4gJnJvY2tjaGlwX2ZiLT5mYjsK PiAgIH0KPgo+Cj4KPgoKCi0tIArvvK1hcmsgWWFvCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Fri, 11 Nov 2016 09:45:00 +0800 Subject: [PATCH] drm/rockchip: return ERR_PTR instead of NULL In-Reply-To: <1478812256-26189-1-git-send-email-Julia.Lawall@lip6.fr> References: <1478812256-26189-1-git-send-email-Julia.Lawall@lip6.fr> Message-ID: <5825229C.8080704@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016?11?11? 05:10, Julia Lawall wrote: > rockchip_drm_framebuffer_init is only used in one case, in > rockchip_drm_fbdev.c, where its return value is tested using IS_ERR. To > enable propagating the reason for the error, change the definition so that > it returns an ERR_PTR value. > > Problem found with the help of Coccinelle. > > Signed-off-by: Julia Lawall Thanks for the fix. Applied to my drm-next. > > --- > drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c > index 0f6eda0..01e11bf 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c > @@ -213,7 +213,7 @@ struct drm_framebuffer * > > rockchip_fb = rockchip_fb_alloc(dev, mode_cmd, &obj, 1); > if (IS_ERR(rockchip_fb)) > - return NULL; > + return ERR_CAST(rockchip_fb); > > return &rockchip_fb->fb; > } > > > > -- ?ark Yao From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965992AbcKKBpj (ORCPT ); Thu, 10 Nov 2016 20:45:39 -0500 Received: from regular1.263xmail.com ([211.150.99.140]:36843 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964923AbcKKBpi (ORCPT ); Thu, 10 Nov 2016 20:45:38 -0500 X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: christophe.jaillet@wanadoo.fr X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <15a744f988f147f6e68041622290d35c> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] drm/rockchip: return ERR_PTR instead of NULL To: Julia Lawall References: <1478812256-26189-1-git-send-email-Julia.Lawall@lip6.fr> Cc: kernel-janitors@vger.kernel.org, David Airlie , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Christophe JAILLET From: Mark yao Message-ID: <5825229C.8080704@rock-chips.com> Date: Fri, 11 Nov 2016 09:45:00 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1478812256-26189-1-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年11月11日 05:10, Julia Lawall wrote: > rockchip_drm_framebuffer_init is only used in one case, in > rockchip_drm_fbdev.c, where its return value is tested using IS_ERR. To > enable propagating the reason for the error, change the definition so that > it returns an ERR_PTR value. > > Problem found with the help of Coccinelle. > > Signed-off-by: Julia Lawall Thanks for the fix. Applied to my drm-next. > > --- > drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c > index 0f6eda0..01e11bf 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c > @@ -213,7 +213,7 @@ struct drm_framebuffer * > > rockchip_fb = rockchip_fb_alloc(dev, mode_cmd, &obj, 1); > if (IS_ERR(rockchip_fb)) > - return NULL; > + return ERR_CAST(rockchip_fb); > > return &rockchip_fb->fb; > } > > > > -- Ｍark Yao