From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40563) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c51oj-0004Rh-Nc for qemu-devel@nongnu.org; Thu, 10 Nov 2016 21:43:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c51og-0004P3-Je for qemu-devel@nongnu.org; Thu, 10 Nov 2016 21:43:49 -0500 Received: from [59.151.112.132] (port=57213 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c51of-0004ON-T4 for qemu-devel@nongnu.org; Thu, 10 Nov 2016 21:43:46 -0500 References: <1478794177-29377-1-git-send-email-mst@redhat.com> <20161110152921.58253387@t450s.home> <20161111003049-mutt-send-email-mst@kernel.org> <20161110154828.73d2cbf9@t450s.home> <20161111005034-mutt-send-email-mst@kernel.org> From: Cao jin Message-ID: <58253105.8060507@cn.fujitsu.com> Date: Fri, 11 Nov 2016 10:46:29 +0800 MIME-Version: 1.0 In-Reply-To: <20161111005034-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 00/47] virtio, vhost, pc, pci: tests, documentation, fixes and cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Alex Williamson Cc: qemu-devel@nongnu.org, Peter Maydell , Stefan Hajnoczi , Paolo Bonzini , Felipe Franciosi On 11/11/2016 06:51 AM, Michael S. Tsirkin wrote: > On Thu, Nov 10, 2016 at 03:48:28PM -0700, Alex Williamson wrote: >>>> So I merge this tag to try to resolve it, now I get qemu segfaulting >>>> bisected to: >>>> >>>> commit a6d8372bc6764ee279b473d13ff4ecc8acb7a978 >>>> Author: Cao jin >>>> Date: Sat Nov 5 10:07:21 2016 +0800 >>>> >>>> hcd-xhci: check & correct param before using it >> >> Here's the backtrace from this one: >> >> #0 0x0000555555a99d90 in xhci_running (xhci=0x0) at hw/usb/hcd-xhci.c:824 >> #1 0x0000555555a9f092 in xhci_port_notify (port=0x7fffbfb39330, bits=131072) >> at hw/usb/hcd-xhci.c:2870 >> #2 0x0000555555a9f221 in xhci_port_update (port=0x7fffbfb39330, is_detach=0) >> at hw/usb/hcd-xhci.c:2905 >> #3 0x0000555555a9f435 in xhci_reset (dev=0x7fffbfb38010) >> at hw/usb/hcd-xhci.c:2961 >> #4 0x0000555555984a2e in device_reset (dev=0x7fffbfb38010) >> at hw/core/qdev.c:1145 >> #5 0x00005555559828db in qdev_reset_one (dev=0x7fffbfb38010, opaque=0x0) >> at hw/core/qdev.c:295 >> #6 0x00005555559834df in qdev_walk_children (dev=0x7fffbfb38010, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf , post_busfn=0x5555559828e2 , opaque=0x0) at hw/core/qdev.c:610 >> #7 0x000055555598763b in qbus_walk_children (bus=0x555556a40f30, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf , post_busfn=0x5555559828e2 , opaque=0x0) at hw/core/bus.c:59 >> #8 0x00005555559834a3 in qdev_walk_children (dev=0x555556a3f220, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf , post_busfn=0x5555559828e2 , opaque=0x0) at hw/core/qdev.c:602 >> #9 0x000055555598763b in qbus_walk_children (bus=0x5555568296c0, pre_devfn=0x0, pre_busfn=0x0, post_devfn=0x5555559828bf , post_busfn=0x5555559828e2 , opaque=0x0) at hw/core/bus.c:59 >> #10 0x00005555559829f5 in qbus_reset_all (bus=0x5555568296c0) >> at hw/core/qdev.c:321 >> #11 0x0000555555982a18 in qbus_reset_all_fn (opaque=0x5555568296c0) >> at hw/core/qdev.c:327 >> #12 0x00005555558e76f0 in qemu_devices_reset () at vl.c:1765 >> #13 0x00005555558367ce in pc_machine_reset () >> at /net/gimli/home/alwillia/Work/qemu.git/hw/i386/pc.c:2181 >> #14 0x00005555558e778d in qemu_system_reset (report=false) at vl.c:1778 >> #15 0x00005555558ef44b in main (argc=50, argv=0x7fffffffdf48, envp=0x7fffffffe0e0) at vl.c:4656 >> >> Here's a commandline sufficient to trigger it: >> >> qemu-system-x86_64 -m 1G -nodefaults -no-user-config -display none -monitor stdio -device nec-usb-xhci >> >> So apparently that never got tested or something got mangled in the >> commit. Thanks, >> >> Alex > > I think I'll drop this, this patchset was borderline useful anyway. > Really sorry for the issue, I moved usb_xhci_init() too far from its original place, results in the segmentation fault. Could I send new version of this patch to fix it right now? -- Yours Sincerely, Cao jin