From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35624)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wei.w.wang@intel.com>) id 1c57CR-00028Q-TQ
	for qemu-devel@nongnu.org; Fri, 11 Nov 2016 03:28:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wei.w.wang@intel.com>) id 1c57CO-0001aU-Nm
	for qemu-devel@nongnu.org; Fri, 11 Nov 2016 03:28:39 -0500
Received: from mga01.intel.com ([192.55.52.88]:8739)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <wei.w.wang@intel.com>)
	id 1c57CO-0001a4-Ds
	for qemu-devel@nongnu.org; Fri, 11 Nov 2016 03:28:36 -0500
Message-ID: <5825814A.8060902@intel.com>
Date: Fri, 11 Nov 2016 16:28:58 +0800
From: Wei Wang <wei.w.wang@intel.com>
MIME-Version: 1.0
References: <1478746069-79574-1-git-send-email-wei.w.wang@intel.com>
	<1478746069-79574-2-git-send-email-wei.w.wang@intel.com>
	<CAJ+F1CLFuvpa1ubAMyAbfd4vBfSc7hpH_D++eCv4enDd71-_qg@mail.gmail.com>
In-Reply-To: <CAJ+F1CLFuvpa1ubAMyAbfd4vBfSc7hpH_D++eCv4enDd71-_qg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [RFC PATCH 1/4] qemu-char: add the
 "1-server-N-client" support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= <marcandre.lureau@gmail.com>
Cc: mst@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org

On 11/10/2016 07:38 PM, Marc-André Lureau wrote:
> Hi
>
> On Thu, Nov 10, 2016 at 6:47 AM Wei Wang <wei.w.wang@intel.com 
> <mailto:wei.w.wang@intel.com>> wrote:
>
>     This patch enables a qemu server socket to be connected by multiple
>     client sockets.
>
> Thanks for sharing this early version of the series, I hope some early 
> feedback will help you. I'll be waiting for a more complete 
> implementation for detailed review.
>
> Is this patch necessary as a first step? I would rather start with  a 
> vhost-pci 1-1 Master-Slave series. Keep 1-n for a following 
> improvement. This would also probably post-pone the discussion 
> regarding connection-id, or uuid.
>
> In short, I think it would help if you can break your proposal in 
> smaller independant steps.
>

OK, we can leave this QEMU socket patch to the 2nd step.

So, I think we can have a two-step plan:
Step1: 1-1 QEMU socket based vhost-pci-net design
    Each QEMU socket manages (create/hotplug/destruction) only 1 
vhost-pci-net device. To create more vhost-pci-net devices, the slave VM 
needs to have more server sockets created at booting time.
Step2: 1-server-N-client based vhost-pci design
   A single QEMU server socket manages all the vhost-pci devices (may 
also in different device types).

Best,
Wei