From mboxrd@z Thu Jan 1 00:00:00 1970 From: guohanjun@huawei.com (Hanjun Guo) Date: Mon, 14 Nov 2016 16:12:16 +0800 Subject: [PATCH v3 5/6] arm64: arch_timer: apci: Introduce a generic aquirk framework for erratum In-Reply-To: <1478264794-14652-5-git-send-email-dingtianhong@huawei.com> References: <1478264794-14652-1-git-send-email-dingtianhong@huawei.com> <1478264794-14652-5-git-send-email-dingtianhong@huawei.com> Message-ID: <582971E0.4070403@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016/11/4 21:06, Ding Tianhong wrote: > From: Hanjun Guo > > Introduce a general quirk framework for each timer erratum in ACPI, > which use the oem information in GTDT table for platform specific erratums. > The struct gtdt_arch_timer_fixup is introduced to record the oem > information to match the quirk and handle the erratum. > > v3: Introduce a generic aquick framework for erratum in ACPI mode. > > Signed-off-by: Hanjun Guo > Signed-off-by: Ding Tianhong > --- > drivers/clocksource/arm_arch_timer.c | 37 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c > index 3d59af1..9bc93e5 100644 > --- a/drivers/clocksource/arm_arch_timer.c > +++ b/drivers/clocksource/arm_arch_timer.c > @@ -1068,6 +1068,40 @@ CLOCKSOURCE_OF_DECLARE(armv7_arch_timer_mem, "arm,armv7-timer-mem", > arch_timer_mem_init); > > #ifdef CONFIG_ACPI > +struct gtdt_arch_timer_fixup { > + char oem_id[ACPI_OEM_ID_SIZE]; > + char oem_table_id[ACPI_OEM_TABLE_ID_SIZE]; > + u32 oem_revision; > + > + /* quirk handler for arch timer erratum */ > + void (*handler)(u32 erratum); > + u32 erratum; Hmm, I think we just use void *context; and we convert it in the platform specific handler, then this struct can be reused for other type of quirks. > +}; > + > +/* note: this needs to be updated according to the doc of OEM ID > + * and TABLE ID for different board. > + */ > +struct gtdt_arch_timer_fixup arch_timer_quirks[] __initdata = { > +}; > + > +void __init arch_timer_acpi_quirks_handler(char *oem_id, > + char *oem_table_id, > + u32 oem_revision) > +{ > + struct gtdt_arch_timer_fixup *quirks = arch_timer_quirks; > + int i; > + > + for (i = 0; i < ARRAY_SIZE(arch_timer_quirks); i++, quirks++) { > + if (!memcmp(quirks->oem_id, oem_id, ACPI_OEM_ID_SIZE) && > + !memcmp(quirks->oem_table_id, oem_table_id, ACPI_OEM_TABLE_ID_SIZE) && > + quirks->oem_revision == oem_revision) { > + if (quirks->handler && quirks->erratum) > + quirks->handler(quirks->erratum); > + break; we can't just break because we have multi quirks for different handlers. Thanks Hanjun From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hanjun Guo Subject: Re: [PATCH v3 5/6] arm64: arch_timer: apci: Introduce a generic aquirk framework for erratum Date: Mon, 14 Nov 2016 16:12:16 +0800 Message-ID: <582971E0.4070403@huawei.com> References: <1478264794-14652-1-git-send-email-dingtianhong@huawei.com> <1478264794-14652-5-git-send-email-dingtianhong@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1478264794-14652-5-git-send-email-dingtianhong@huawei.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Ding Tianhong , catalin.marinas@arm.com, will.deacon@arm.com, marc.zyngier@arm.com, mark.rutland@arm.com, oss@buserror.net, devicetree@vger.kernel.org, shawnguo@kernel.org, stuart.yoder@nxp.com, linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com, hanjun.guo@linaro.org List-Id: devicetree@vger.kernel.org On 2016/11/4 21:06, Ding Tianhong wrote: > From: Hanjun Guo > > Introduce a general quirk framework for each timer erratum in ACPI, > which use the oem information in GTDT table for platform specific erratums. > The struct gtdt_arch_timer_fixup is introduced to record the oem > information to match the quirk and handle the erratum. > > v3: Introduce a generic aquick framework for erratum in ACPI mode. > > Signed-off-by: Hanjun Guo > Signed-off-by: Ding Tianhong > --- > drivers/clocksource/arm_arch_timer.c | 37 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c > index 3d59af1..9bc93e5 100644 > --- a/drivers/clocksource/arm_arch_timer.c > +++ b/drivers/clocksource/arm_arch_timer.c > @@ -1068,6 +1068,40 @@ CLOCKSOURCE_OF_DECLARE(armv7_arch_timer_mem, "arm,armv7-timer-mem", > arch_timer_mem_init); > > #ifdef CONFIG_ACPI > +struct gtdt_arch_timer_fixup { > + char oem_id[ACPI_OEM_ID_SIZE]; > + char oem_table_id[ACPI_OEM_TABLE_ID_SIZE]; > + u32 oem_revision; > + > + /* quirk handler for arch timer erratum */ > + void (*handler)(u32 erratum); > + u32 erratum; Hmm, I think we just use void *context; and we convert it in the platform specific handler, then this struct can be reused for other type of quirks. > +}; > + > +/* note: this needs to be updated according to the doc of OEM ID > + * and TABLE ID for different board. > + */ > +struct gtdt_arch_timer_fixup arch_timer_quirks[] __initdata = { > +}; > + > +void __init arch_timer_acpi_quirks_handler(char *oem_id, > + char *oem_table_id, > + u32 oem_revision) > +{ > + struct gtdt_arch_timer_fixup *quirks = arch_timer_quirks; > + int i; > + > + for (i = 0; i < ARRAY_SIZE(arch_timer_quirks); i++, quirks++) { > + if (!memcmp(quirks->oem_id, oem_id, ACPI_OEM_ID_SIZE) && > + !memcmp(quirks->oem_table_id, oem_table_id, ACPI_OEM_TABLE_ID_SIZE) && > + quirks->oem_revision == oem_revision) { > + if (quirks->handler && quirks->erratum) > + quirks->handler(quirks->erratum); > + break; we can't just break because we have multi quirks for different handlers. Thanks Hanjun