From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1c6ErX-0004ot-E0 for kexec@lists.infradead.org; Mon, 14 Nov 2016 10:51:44 +0000 Subject: Re: [PATCH v2] kexec: Increase the upper limit for RAM segments References: <1478902871-13800-1-git-send-email-sgoel@codeaurora.org> From: Xunlei Pang Message-ID: <5829974D.4020901@redhat.com> Date: Mon, 14 Nov 2016 18:51:57 +0800 MIME-Version: 1.0 In-Reply-To: <1478902871-13800-1-git-send-email-sgoel@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: xlpang@redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Sameer Goel , geoff@infradead.org Cc: kexec@lists.infradead.org, bhe@redhat.com On 2016/11/12 at 06:21, Sameer Goel wrote: > On a newer UEFI based Qualcomm target the number of system ram regions > retrieved from /proc/iomem are ~40. So increasing the current hardcoded > values to 64 from 16. I am a little confused, memory regions from /proc/iomem should be MAX_MEMORY_RANGES used as the elfcorehdr, while KEXEC_SEGMENT_MAX stands for the kexec segments passed to the kexec syscall, like kernel image, initrd image, purgatory, etc. Do you mean KEXEC_SEGMENT_MAX or MAX_MEMORY_RANGES? Regards, Xunlei > > Signed-off-by: Sameer Goel > --- > kexec/arch/arm64/kexec-arm64.h | 2 +- > kexec/kexec-syscall.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kexec/arch/arm64/kexec-arm64.h b/kexec/arch/arm64/kexec-arm64.h > index bac62f8..bd4c20e 100644 > --- a/kexec/arch/arm64/kexec-arm64.h > +++ b/kexec/arch/arm64/kexec-arm64.h > @@ -11,7 +11,7 @@ > #include "image-header.h" > #include "kexec.h" > > -#define KEXEC_SEGMENT_MAX 16 > +#define KEXEC_SEGMENT_MAX 64 > > #define BOOT_BLOCK_VERSION 17 > #define BOOT_BLOCK_LAST_COMP_VERSION 16 > diff --git a/kexec/kexec-syscall.h b/kexec/kexec-syscall.h > index c0d0bea..f84c937 100644 > --- a/kexec/kexec-syscall.h > +++ b/kexec/kexec-syscall.h > @@ -115,7 +115,7 @@ static inline long kexec_file_load(int kernel_fd, int initrd_fd, > #define KEXEC_ARCH_MIPS ( 8 << 16) > #define KEXEC_ARCH_CRIS (76 << 16) > > -#define KEXEC_MAX_SEGMENTS 16 > +#define KEXEC_MAX_SEGMENTS 64 > > #ifdef __i386__ > #define KEXEC_ARCH_NATIVE KEXEC_ARCH_386 _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec