From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6GSq-0007De-B6 for qemu-devel@nongnu.org; Mon, 14 Nov 2016 07:34:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6GSn-0003d0-8A for qemu-devel@nongnu.org; Mon, 14 Nov 2016 07:34:20 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:33187) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c6GSn-0003cp-2Q for qemu-devel@nongnu.org; Mon, 14 Nov 2016 07:34:17 -0500 Received: by mail-pg0-f65.google.com with SMTP id 3so8915502pgd.0 for ; Mon, 14 Nov 2016 04:34:16 -0800 (PST) Message-ID: <5829af0b.84f4420a.a436f.4a6d@mx.google.com> From: Li Qiang Date: Mon, 14 Nov 2016 07:32:56 -0500 In-Reply-To: <1479126778-125867-1-git-send-email-Qiang(liqiang6-s@360.cn)> References: <1479126778-125867-1-git-send-email-Qiang(liqiang6-s@360.cn)> Subject: [Qemu-devel] [PATCH 1/3] 9pfs: add cleanup operation in FileOperations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: groug@kaod.org, qemu-devel@nongnu.org Cc: liqiang6-s@360.cn, Li Qiang From: Li Qiang Currently, the backend of VirtFS doesn't have a cleanup function. This will lead resource leak issues if the backed driver allocates resources. This patch addresses this issue. Signed-off-by: Li Qiang --- fsdev/file-op-9p.h | 1 + hw/9pfs/9p.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/fsdev/file-op-9p.h b/fsdev/file-op-9p.h index 6db9fea..a56dc84 100644 --- a/fsdev/file-op-9p.h +++ b/fsdev/file-op-9p.h @@ -100,6 +100,7 @@ struct FileOperations { int (*parse_opts)(QemuOpts *, struct FsDriverEntry *); int (*init)(struct FsContext *); + void (*cleanup)(struct FsContext *); int (*lstat)(FsContext *, V9fsPath *, struct stat *); ssize_t (*readlink)(FsContext *, V9fsPath *, char *, size_t); int (*chmod)(FsContext *, V9fsPath *, FsCred *); diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index aea7e9d..166b5a7 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@ -3532,6 +3532,9 @@ void v9fs_device_unrealize_common(V9fsState *s, Error **errp) { g_free(s->ctx.fs_root); g_free(s->tag); + if (s->ops->cleanup) { + s->ops->cleanup(&s->ctx); + } } typedef struct VirtfsCoResetData { -- 1.8.3.1