From: zhoucm1 <david1.zhou-5C7GfCeVMHo@public.gmane.org>
To: Alex Deucher
<alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH] drm/amdgpu/sdma: fix typo in packet setup
Date: Tue, 15 Nov 2016 09:55:15 +0800 [thread overview]
Message-ID: <582A6B03.60306@amd.com> (raw)
In-Reply-To: <1479147215-2151-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
On 2016年11月15日 02:13, Alex Deucher wrote:
> Use the correct define. No functional change as both
> defines are equivalent.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Chunming Zhou <david1.zhou@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c b/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c
> index e81aa46..1b44d5b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v2_4.c
> @@ -775,7 +775,7 @@ static void sdma_v2_4_vm_write_pte(struct amdgpu_ib *ib, uint64_t pe,
> unsigned ndw = count * 2;
>
> ib->ptr[ib->length_dw++] = SDMA_PKT_HEADER_OP(SDMA_OP_WRITE) |
> - SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_COPY_LINEAR);
> + SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_WRITE_LINEAR);
> ib->ptr[ib->length_dw++] = pe;
> ib->ptr[ib->length_dw++] = upper_32_bits(pe);
> ib->ptr[ib->length_dw++] = ndw;
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> index 77f1465..9425c69 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> @@ -977,7 +977,7 @@ static void sdma_v3_0_vm_write_pte(struct amdgpu_ib *ib, uint64_t pe,
> unsigned ndw = count * 2;
>
> ib->ptr[ib->length_dw++] = SDMA_PKT_HEADER_OP(SDMA_OP_WRITE) |
> - SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_COPY_LINEAR);
> + SDMA_PKT_HEADER_SUB_OP(SDMA_SUBOP_WRITE_LINEAR);
> ib->ptr[ib->length_dw++] = lower_32_bits(pe);
> ib->ptr[ib->length_dw++] = upper_32_bits(pe);
> ib->ptr[ib->length_dw++] = ndw;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2016-11-15 1:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 18:13 [PATCH] drm/amdgpu/sdma: fix typo in packet setup Alex Deucher
[not found] ` <1479147215-2151-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2016-11-15 1:55 ` zhoucm1 [this message]
[not found] ` <582A6B03.60306-5C7GfCeVMHo@public.gmane.org>
2016-11-15 8:11 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=582A6B03.60306@amd.com \
--to=david1.zhou-5c7gfcevmho@public.gmane.org \
--cc=alexander.deucher-5C7GfCeVMHo@public.gmane.org \
--cc=alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.