From: Wols Lists <antlists@youngman.org.uk>
To: Shaohua Li <shli@kernel.org>
Cc: NeilBrown <neilb@suse.com>, Shaohua Li <shli@fb.com>,
linux-raid@vger.kernel.org, songliubraving@fb.com,
Zhengyuan Liu <liuzhengyuan@kylinos.cn>
Subject: Re: [PATCH 1/2] raid5-cache: update superblock at shutdown/reboot
Date: Thu, 17 Nov 2016 19:11:11 +0000 [thread overview]
Message-ID: <582E00CF.4080903@youngman.org.uk> (raw)
In-Reply-To: <20161117182359.tyyqmrbngtqufcvf@kernel.org>
On 17/11/16 18:23, Shaohua Li wrote:
>> And yes, I *AM* volunteering to do the work - as I said elsewhere, I
>> > want to put a load of kerneldoc into the raid source, and get to
>> > understand it all, but the downside is you'll get a lot of newbie-ish
>> > questions from me trying to get to grips with what's going on. I'm an
>> > experienced C programmer but kernel style is alien to me - you know the
>> > disconnect when you're reading something, you can read the words easily,
>> > but you can't decipher the meaning. That's how I feel reading the kernel
>> > source at the moment.
>> >
>> > Are we up for it?
> Yep, that makes sense. the journal (current write-through mode and upcoming
> write-back mode) does deserve a description. I'll add something into
> Documentation dir in kernel source.
From what I can make out ... :-)
The new kernel documentation system actually builds a load of stuff into
the Documentation/output directory from the kernel source. In other
words, it'll be far better edited into the source files. And/or put a
.rst file in the md directory.
I need to dig into this, and work out how it all fits together (I'm
having trouble running it on my main system at the moment, gentoo takes
forever to upgrade and the bits I need won't install ...)
https://www.kernel.org/doc/
When you've written it up, post it to the list, and we'll see about
getting it into the new documentation system rather than just dropping
it into the Documentation directory (I think the new system will put it
in Documentation/output/drivers/md, which is lot more sensible than just
jumbled in Documentation along with everything else.
Cheers,
Wol
next prev parent reply other threads:[~2016-11-17 19:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 1:20 [PATCH 1/2] raid5-cache: update superblock at shutdown/reboot Shaohua Li
2016-11-17 1:20 ` [PATCH 2/2] raid5-cache: fix lockdep warning Shaohua Li
2016-11-17 5:18 ` [PATCH 1/2] raid5-cache: update superblock at shutdown/reboot NeilBrown
2016-11-17 9:44 ` Wols Lists
2016-11-17 18:23 ` Shaohua Li
2016-11-17 19:11 ` Wols Lists [this message]
2016-11-17 18:13 ` Shaohua Li
2016-11-18 0:01 ` NeilBrown
2016-11-18 1:41 ` Shaohua Li
2016-11-18 3:49 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=582E00CF.4080903@youngman.org.uk \
--to=antlists@youngman.org.uk \
--cc=linux-raid@vger.kernel.org \
--cc=liuzhengyuan@kylinos.cn \
--cc=neilb@suse.com \
--cc=shli@fb.com \
--cc=shli@kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.