From: "Aníbal Limón" <anibal.limon@linux.intel.com>
To: Linus Wallgren <linus.wallgren@scypho.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] apt-package: Include maintenance scripts
Date: Thu, 17 Nov 2016 16:16:38 -0600 [thread overview]
Message-ID: <582E2C46.9090605@linux.intel.com> (raw)
In-Reply-To: <20161116163315.18662-1-linus.wallgren@scypho.com>
[-- Attachment #1: Type: text/plain, Size: 2360 bytes --]
Hi Linus,
Your patch looks good, only missing one thing you need to conditional
those lines to only work when systemd is enabled in DISTRO_FEATURES, see
example:
http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-support/consolekit/consolekit_0.4.6.bb#n26
Thanks in advance,
alimon
On 11/16/2016 10:33 AM, Linus Wallgren wrote:
> Apt can run multiple tasks daily, such as for example clean, update,
> autoclean, unattended-upgrades etc.
>
> [YOCTO #10669]
>
> Signed-off-by: Linus Wallgren <linus.wallgren@scypho.com>
> ---
> meta/recipes-devtools/apt/apt-package.inc | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/apt/apt-package.inc b/meta/recipes-devtools/apt/apt-package.inc
> index a553aa2..38cd558 100644
> --- a/meta/recipes-devtools/apt/apt-package.inc
> +++ b/meta/recipes-devtools/apt/apt-package.inc
> @@ -32,13 +32,19 @@ FILES_${PN} = "${bindir}/apt-cdrom ${bindir}/apt-get \
> ${bindir}/apt-config ${bindir}/apt-cache \
> ${libdir}/apt ${libdir}/libapt*.so.* \
> ${localstatedir} ${sysconfdir} \
> - ${libdir}/dpkg"
> + ${libdir}/dpkg \
> + ${systemd_unitdir}/system \
> + "
> FILES_${PN}-utils = "${bindir}/apt-sortpkgs ${bindir}/apt-extracttemplates"
> FILES_${PN}-doc = "${@get_files_apt_doc(d, bb, d.getVar('apt-manpages', True))} \
> ${docdir}/apt"
> FILES_${PN}-utils-doc = "${@get_files_apt_doc(d, bb, d.getVar('apt-utils-manpages', True))}"
> FILES_${PN}-dev = "${libdir}/libapt*.so ${includedir}"
>
> +inherit systemd
> +
> +SYSTEMD_SERVICE_${PN} = "apt-daily.timer"
> +
> do_install () {
> set -x
> install -d ${D}${bindir}
> @@ -75,4 +81,11 @@ do_install () {
>
> install -d ${D}${includedir}/apt-pkg/
> install -m 0644 include/apt-pkg/*.h ${D}${includedir}/apt-pkg/
> +
> + install -d ${D}${systemd_unitdir}/system/
> + install -m 0644 ${S}/debian/apt.systemd.daily ${D}/usr/lib/apt/
> + install -m 0644 ${S}/debian/apt-daily.service ${D}${systemd_unitdir}/system/
> + install -m 0644 ${S}/debian/apt-daily.timer ${D}${systemd_unitdir}/system/
> + install -d ${D}${sysconfdir}/cron.daily/
> + install -m 0755 ${S}/debian/apt.apt-compat.cron.daily ${D}${sysconfdir}/cron.daily/
> }
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2016-11-17 22:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 16:33 [PATCH] apt-package: Include maintenance scripts Linus Wallgren
2016-11-17 22:16 ` Aníbal Limón [this message]
2016-11-19 14:06 ` Andreas Oberritter
2016-11-21 20:57 ` [PATCHv2] " Linus Wallgren
2016-11-22 20:26 ` Aníbal Limón
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=582E2C46.9090605@linux.intel.com \
--to=anibal.limon@linux.intel.com \
--cc=linus.wallgren@scypho.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.