diff for duplicates of <582EE465.4010408@oracle.com> diff --git a/a/1.txt b/N1/1.txt index 34282ea..83e51bc 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -33,7 +33,7 @@ On Saturday 12 November 2016 11:36 PM, Julia Lawall wrote: >> position p; >> @@ >> ( ->> request_threaded_irq at p(irq, NULL, thread_fn, +>> request_threaded_irq@p(irq, NULL, thread_fn, >> ( >> -flags | IRQF_ONESHOT >> +IRQF_ONESHOT | ... @@ -42,7 +42,7 @@ On Saturday 12 November 2016 11:36 PM, Julia Lawall wrote: >> ) >> @@ -32,20 +31,39 @@ IRQF_ONESHOT >> | ->> devm_request_threaded_irq at p(dev, irq, NULL, thread_fn, +>> devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, >> ( >> -flags | IRQF_ONESHOT >> +IRQF_ONESHOT | ... @@ -52,8 +52,8 @@ On Saturday 12 November 2016 11:36 PM, Julia Lawall wrote: >> , ...) >> ) >> ->> - at depends on patch@ ->> + at r2@ +>> -@depends on patch@ +>> +@r2@ >> expression dev; >> expression irq; >> expression thread_fn; @@ -63,13 +63,13 @@ On Saturday 12 November 2016 11:36 PM, Julia Lawall wrote: >> @@ >> +flags = IRQF_ONESHOT | ...; >> +( ->> +ret = request_threaded_irq at p(irq, NULL, thread_fn, flags, ...); +>> +ret = request_threaded_irq@p(irq, NULL, thread_fn, flags, ...); >> +| ->> +ret = devm_request_threaded_irq at p(dev, irq, NULL, thread_fn, flags, ...); +>> +ret = devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...); >> +| ->> +return request_threaded_irq at p(irq, NULL, thread_fn, flags, ...); +>> +return request_threaded_irq@p(irq, NULL, thread_fn, flags, ...); >> +| ->> +return devm_request_threaded_irq at p(dev, irq, NULL, thread_fn, flags, ...); +>> +return devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...); >> +) > > This rule needs some improvement. @@ -99,9 +99,9 @@ Ok, this makes sense. > should be replaced by the following: > > ( -> request_threaded_irq at p(irq, NULL, thread_fn, flags, ...) +> request_threaded_irq@p(irq, NULL, thread_fn, flags, ...) > | -> devm_request_threaded_irq at p(dev, irq, NULL, thread_fn, flags, ...) +> devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...) > ) Ok, primary motivation with having specified pattern was to have less @@ -115,7 +115,7 @@ changes. > > >> + ->> + at depends on patch@ +>> +@depends on patch@ >> +expression dev; >> +expression irq; >> +expression thread_fn; @@ -123,23 +123,23 @@ changes. >> +position p != {r1.p,r2.p}; >> +@@ >> ( ->> request_threaded_irq at p(irq, NULL, thread_fn, +>> request_threaded_irq@p(irq, NULL, thread_fn, >> ( ->> @@ -69,13 +87,13 @@ devm_request_threaded_irq at p(dev, irq, NULL, thread_fn, +>> @@ -69,13 +87,13 @@ devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, >> ) >> >> @depends on context@ >> -position p != r1.p; >> +position p != {r1.p,r2.p}; >> @@ ->> *request_threaded_irq at p(...) +>> *request_threaded_irq@p(...) >> >> @match depends on report || org@ >> expression irq; >> -position p != r1.p; >> +position p != {r1.p,r2.p}; >> @@ ->> request_threaded_irq at p(irq, NULL, ...) +>> request_threaded_irq@p(irq, NULL, ...) >> >> -- >> 2.1.4 diff --git a/a/content_digest b/N1/content_digest index f044591..2c407e5 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,10 +1,16 @@ "ref\0cover.1477293469.git.vaishali.thakkar@oracle.com\0" "ref\053a9e7344bd2fe5756c245ab0e1646976c1e0fbd.1477293469.git.vaishali.thakkar@oracle.com\0" "ref\0alpine.DEB.2.20.1611121901440.2011@hadrien\0" - "From\0vaishali.thakkar@oracle.com (Vaishali Thakkar)\0" - "Subject\0[Cocci] [PATCH v3 1/3] Coccinelle: misc: Improve the matching of rules\0" + "From\0Vaishali Thakkar <vaishali.thakkar@oracle.com>\0" + "Subject\0Re: [PATCH v3 1/3] Coccinelle: misc: Improve the matching of rules\0" "Date\0Fri, 18 Nov 2016 16:52:13 +0530\0" - "To\0cocci@systeme.lip6.fr\0" + "To\0Julia Lawall <julia.lawall@lip6.fr>\0" + "Cc\0mmarek@suse.com" + Gilles Muller <gilles.muller@lip6.fr> + nicolas.palix@imag.fr + cocci@systeme.lip6.fr + linux-kernel@vger.kernel.org + " lars@metafoo.de\0" "\00:1\0" "b\0" "\n" @@ -42,7 +48,7 @@ ">> position p;\n" ">> @@\n" ">> (\n" - ">> request_threaded_irq at p(irq, NULL, thread_fn,\n" + ">> request_threaded_irq@p(irq, NULL, thread_fn,\n" ">> (\n" ">> -flags | IRQF_ONESHOT\n" ">> +IRQF_ONESHOT | ...\n" @@ -51,7 +57,7 @@ ">> )\n" ">> @@ -32,20 +31,39 @@ IRQF_ONESHOT\n" ">> |\n" - ">> devm_request_threaded_irq at p(dev, irq, NULL, thread_fn,\n" + ">> devm_request_threaded_irq@p(dev, irq, NULL, thread_fn,\n" ">> (\n" ">> -flags | IRQF_ONESHOT\n" ">> +IRQF_ONESHOT | ...\n" @@ -61,8 +67,8 @@ ">> , ...)\n" ">> )\n" ">>\n" - ">> - at depends on patch@\n" - ">> + at r2@\n" + ">> -@depends on patch@\n" + ">> +@r2@\n" ">> expression dev;\n" ">> expression irq;\n" ">> expression thread_fn;\n" @@ -72,13 +78,13 @@ ">> @@\n" ">> +flags = IRQF_ONESHOT | ...;\n" ">> +(\n" - ">> +ret = request_threaded_irq at p(irq, NULL, thread_fn, flags, ...);\n" + ">> +ret = request_threaded_irq@p(irq, NULL, thread_fn, flags, ...);\n" ">> +|\n" - ">> +ret = devm_request_threaded_irq at p(dev, irq, NULL, thread_fn, flags, ...);\n" + ">> +ret = devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...);\n" ">> +|\n" - ">> +return request_threaded_irq at p(irq, NULL, thread_fn, flags, ...);\n" + ">> +return request_threaded_irq@p(irq, NULL, thread_fn, flags, ...);\n" ">> +|\n" - ">> +return devm_request_threaded_irq at p(dev, irq, NULL, thread_fn, flags, ...);\n" + ">> +return devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...);\n" ">> +)\n" "> \n" "> This rule needs some improvement.\n" @@ -108,9 +114,9 @@ "> should be replaced by the following:\n" "> \n" "> (\n" - "> request_threaded_irq at p(irq, NULL, thread_fn, flags, ...)\n" + "> request_threaded_irq@p(irq, NULL, thread_fn, flags, ...)\n" "> |\n" - "> devm_request_threaded_irq at p(dev, irq, NULL, thread_fn, flags, ...)\n" + "> devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, flags, ...)\n" "> )\n" "\n" "Ok, primary motivation with having specified pattern was to have less\n" @@ -124,7 +130,7 @@ "> \n" "> \n" ">> +\n" - ">> + at depends on patch@\n" + ">> +@depends on patch@\n" ">> +expression dev;\n" ">> +expression irq;\n" ">> +expression thread_fn;\n" @@ -132,23 +138,23 @@ ">> +position p != {r1.p,r2.p};\n" ">> +@@\n" ">> (\n" - ">> request_threaded_irq at p(irq, NULL, thread_fn,\n" + ">> request_threaded_irq@p(irq, NULL, thread_fn,\n" ">> (\n" - ">> @@ -69,13 +87,13 @@ devm_request_threaded_irq at p(dev, irq, NULL, thread_fn,\n" + ">> @@ -69,13 +87,13 @@ devm_request_threaded_irq@p(dev, irq, NULL, thread_fn,\n" ">> )\n" ">>\n" ">> @depends on context@\n" ">> -position p != r1.p;\n" ">> +position p != {r1.p,r2.p};\n" ">> @@\n" - ">> *request_threaded_irq at p(...)\n" + ">> *request_threaded_irq@p(...)\n" ">>\n" ">> @match depends on report || org@\n" ">> expression irq;\n" ">> -position p != r1.p;\n" ">> +position p != {r1.p,r2.p};\n" ">> @@\n" - ">> request_threaded_irq at p(irq, NULL, ...)\n" + ">> request_threaded_irq@p(irq, NULL, ...)\n" ">>\n" ">> --\n" ">> 2.1.4\n" @@ -158,4 +164,4 @@ "-- \n" Vaishali -f02b8d2f9d32d2ca4f341d22aac7fe966b3889a60289c0d026b5149b800b5787 +3ae0fe7488fd62c54804264c89d18525209106af20753c5b4953f736cfad362b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.