From: John Fastabend <john.fastabend@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: tgraf@suug.ch, shm@cumulusnetworks.com,
alexei.starovoitov@gmail.com, daniel@iogearbox.net,
davem@davemloft.net, john.r.fastabend@intel.com,
netdev@vger.kernel.org, bblanco@plumgrid.com, brouer@redhat.com
Subject: Re: [PATCH 3/5] virtio_net: Add XDP support
Date: Fri, 18 Nov 2016 17:02:44 -0800 [thread overview]
Message-ID: <582FA4B4.4000808@gmail.com> (raw)
In-Reply-To: <1479511422.8455.305.camel@edumazet-glaptop3.roam.corp.google.com>
On 16-11-18 03:23 PM, Eric Dumazet wrote:
> On Fri, 2016-11-18 at 11:00 -0800, John Fastabend wrote:
>> From: Shrijeet Mukherjee <shrijeet@gmail.com>
>
>
>> #include <linux/slab.h>
>> @@ -81,6 +82,8 @@ struct receive_queue {
>>
>> struct napi_struct napi;
>>
>> + struct bpf_prog *xdp_prog;
>
> Please add proper sparse annotation, as in
>
> struct bpf_prog __rcu *xdp_prog;
>
> And run sparse ;)
>
> CONFIG_SPARSE_RCU_POINTER=y
>
> make C=2 drivers/net/virtio_net.o
>
>
>
>
Yep will do thanks! And I will fix the other comment as well.
next prev parent reply other threads:[~2016-11-19 1:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 18:59 [PATCH 0/5] XDP for virtio_net John Fastabend
2016-11-18 18:59 ` [PATCH 1/5] net: virtio dynamically disable/enable LRO John Fastabend
2016-11-18 18:59 ` [PATCH 2/5] net: xdp: add invalid buffer warning John Fastabend
2016-11-18 19:00 ` [PATCH 3/5] virtio_net: Add XDP support John Fastabend
2016-11-18 23:21 ` Eric Dumazet
2016-11-19 2:16 ` John Fastabend
2016-11-18 23:23 ` Eric Dumazet
2016-11-19 1:02 ` John Fastabend [this message]
2016-11-18 19:00 ` [PATCH 4/5] virtio_net: add dedicated XDP transmit queues John Fastabend
2016-11-18 21:09 ` Jakub Kicinski
2016-11-19 2:10 ` Jakub Kicinski
2016-11-19 2:43 ` John Fastabend
2016-11-19 2:57 ` Jakub Kicinski
2016-11-19 3:20 ` Eric Dumazet
2016-11-19 3:23 ` Jakub Kicinski
2016-11-19 21:33 ` John Fastabend
2016-11-18 19:01 ` [PATCH 5/5] virtio_net: add XDP_TX support John Fastabend
2016-11-18 19:06 ` [PATCH 0/5] XDP for virtio_net John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=582FA4B4.4000808@gmail.com \
--to=john.fastabend@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bblanco@plumgrid.com \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shm@cumulusnetworks.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.