Re: [GIT PULL FOR 6.18-fixes] Please pull platform-qcom-fixes-for-6.18

[Hans Verkuil <hverkuil+cisco@kernel.org>]

On 24/09/2025 12:43, bod@kernel.org wrote:
> From: Bryan O'Donoghue <bod@kernel.org>
> 
> The following changes since commit 40b7a19f321e65789612ebaca966472055dab48c:
> 
>   media: tuner: xc5000: Fix use-after-free in xc5000_release (2025-09-17 12:15:35 +0200)
> 
> are available in the Git repository at:
> 
>   https://gitlab.freedesktop.org/linux-media/users/bodonoghue.git tags/platform-qcom-fixes-for-6.18
> 
> for you to fetch changes up to 22d0fa7f9507d8e20db956aab5d2eecd55084db6:
> 
>   dt-bindings: media: camss: Add qcs8300 supplies binding (2025-09-23 00:13:39 +0100)
> 
> ----------------------------------------------------------------
> This tag contains three fixes for 6.18
> 
> - An alignment issue Loic identified in -next for QCM2290
> - A fix for Venus when OPP tables are missing
> - A fix for the QCS8300 CAMSS binding.
>   https://lore.kernel.org/linux-media/61b562ad-eb67-4917-a449-f5556c43ceef@linaro.org
>   https://lore.kernel.org/linux-media/e72800d4-cb65-443b-be7e-0966a60fa5a9@linaro.org
> 
> ----------------------------------------------------------------
> Loic Poulain (1):
>       media: qcom: camss: vfe: Fix BPL alignment for QCM2290
> 
> Nihal Kumar Gupta (1):
>       dt-bindings: media: camss: Add qcs8300 supplies binding

I am unhappy with this bindings patch: it's missing Acks from the device-tree devs,
and the commit log is vague:

"This commit adds in the missing vdda-phy and vdda-pll supplies from
qcs8300-camss.yaml."

Did you mean "to" instead of "from"?

Also mention why they were missing, I assume because it was simply forgotten? Shouldn't
there be a Fixes tag?

Since this is also a fix for a newly introduced file (hence the lack of Acks), I think it
is better to handle this as a post-v6.18-rc1 fix. That way the file that is fixed is
available for the devicetree maintainers, you can add a Fixes tag and update the commit
message.

I'll take the other two patches.

Regards,

	Hans

> 
> Renjiang Han (1):
>       media: venus: pm_helpers: add fallback for the opp-table
> 
>  .../devicetree/bindings/media/qcom,qcs8300-camss.yaml       | 13 +++++++++++++
>  drivers/media/platform/qcom/camss/camss-vfe.c               |  1 -
>  drivers/media/platform/qcom/venus/pm_helpers.c              |  9 ++++++++-
>  3 files changed, 21 insertions(+), 2 deletions(-)
>