From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manojkiran Eda Date: Thu, 28 Mar 2024 11:33:44 -0000 Subject: [PATCH v2 4/4] dt-bindings: aspeed: Add eSPI controller In-Reply-To: References: <20240319093405.39833-1-manojkiran.eda@gmail.com> <20240319093405.39833-5-manojkiran.eda@gmail.com> Message-ID: <582c276c-ea2f-456c-9bf9-47e39289a0b6@gmail.com> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 20/03/24 8:14 pm, Krzysztof Kozlowski wrote: > On 20/03/2024 10:59, Manojkiran Eda wrote: >> >> On 19/03/24 3:26 pm, Krzysztof Kozlowski wrote: >>> On 19/03/2024 10:34, Manojkiran Eda wrote: >>>> This commit adds the device tree bindings for aspeed eSPI >>>> controller. >>>> >>>> Although aspeed eSPI hardware supports 4 different channels, >>>> this commit only adds the support for flash channel, the >>>> bindings for other channels could be upstreamed when the driver >>>> support for those are added. >>>> >>>> Signed-off-by: Manojkiran Eda >>>> --- >>>> .../bindings/soc/aspeed/aspeed,espi.yaml | 94 +++++++++++++++++++ >>>> 1 file changed, 94 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/soc/aspeed/aspeed,espi.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/soc/aspeed/aspeed,espi.yaml b/Documentation/devicetree/bindings/soc/aspeed/aspeed,espi.yaml >>>> new file mode 100644 >>>> index 000000000000..3d3ad528e3b3 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/soc/aspeed/aspeed,espi.yaml >>> Why Rob's comments got ignored? >>> >>> This is not a soc component. >> I did not mean to ignore, i have few reasons listed below that provides >> information on why i felt this belongs into soc. > > soc is dumping ground of things which are purely SoC specific, not > covered by existing hardware structure in bindings. Maybe indeed this > does not have any other place, but did you actually look? > Yes, i did look at existing hardware bindings, and cannot seem to find out any other suitable place. I can definitely look again. > Anyway, please CC SPI maintainers on future submission. Sure, will add them. > >>> >>>> @@ -0,0 +1,94 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +# # Copyright (c) 2024 IBM Corporation. >>>> +# # Copyright (c) 2021 Aspeed Technology Inc. >>>> +%YAML 1.2 >>>> +--- >>>> +$id:http://devicetree.org/schemas/soc/aspeed/aspeed,espi.yaml# >>>> +$schema:http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Aspeed eSPI Controller >>>> + >>>> +maintainers: >>>> + - Manojkiran Eda >>>> + - Patrick Rudolph >>>> + - Chia-Wei Wang >>>> + - Ryan Chen >>>> + >>>> +description: >>>> + Aspeed eSPI controller implements a device side eSPI endpoint device >>>> + supporting the flash channel. >>> Explain what is eSPI. >> eSPI is a serial bus interface for client and server platforms that is > > Explain in description of the hardware. Sure, i will add this description in the binding document in the future submission. > >> based on SPI,? using the same master and slave topology but operates >> with a different protocol to meet new requirements. For instance, eSPI >> uses I/O, or input/output, communication, instead of MOSI/MISO used in >> SPI. It also includes a transaction layer on top of the SPI protocol, >> defining packets such as command and response packets that allow both >> the master and slave to initiate alert and reset signals. eSPI supports >> communication between Embedded Controller (EC), Baseboard Management >> Controller (BMC), Super-I/O (SIO) and Port-80 debug cards. I could add >> this to the commit message as well in the next patchset. >>> >>>> + >>>> +properties: >>>> + compatible: >>>> + items: >>>> + - enum: >>>> + - aspeed,ast2500-espi >>>> + - aspeed,ast2600-espi >>>> + - const: simple-mfd >>> >>> That's not simple-mfd. You have driver for this. Drop. >>> >>>> + - const: syscon >>> That's not syscon. Why do you have ranges then? Where is any explanation >>> of hardware which would justify such combination? >>> >>>> + >>>> + reg: >>>> + maxItems: 1 >>>> + >>>> + "#address-cells": >>>> + const: 1 >>>> + >>>> + "#size-cells": >>>> + const: 1 >>>> + >>>> + ranges: true >>>> + >>>> +patternProperties: >>>> + "^espi-ctrl@[0-9a-f]+$": >>>> + type: object >>>> + >>>> + description: Controls the flash channel of eSPI hardware >>> That explains nothing. Unless you wanted to use here MTD bindings. >>> >>> This binding did not improve much. I don't understand why this is not >>> SPI (nothing in commit msg, nothing in description), what is eSPI, >> >> eSPI uses Peripheral, Virtual Wire, Out of Band, and Flash Access >> channels to communicate different sets of data. > > And what are these channels? What does it mean a "channel"? Is it just > how you organize transfers and classes of devices? Or some sort of > addressable instance on the bus? > Yes, an espi channel provides a means to allow multiple independent flows of traffic to share the same physical bus. Each of the channels has its own dedicated resources such as queue and flow control. > The channels feel like some sort of software or logical concept, not > physical. Physical would be endpoint with peripheral. Or flash memory. A channel is a logical communication pathway or interface between the chipset and peripheral devices. The concept of channels in the ESPI protocol helps organize and manage different types of communication between the chipset and peripherals. Each channel may have its own set of protocols, data transfer rates, and supported features, tailored to the requirements of the devices it serves. > How do they fit here? I am not sure I understand, can you please elaborate ? >> >> * The *Peripheral* Channel is used for communication between eSPI host >> bridge located on the master side and eSPI endpoints located on the >> slave side. LPC Host and LPC Peripherals are an example of eSPI host >> bridge and eSPI endpoints respectively. >> * *Virtual Wire* Channel: The Virtual Wire channel is used to >> communicate the state of sideband pins or GPIO tunneled through eSPI >> as in-band messages. Serial IRQ interrupts are communicated through >> this channel as in-band messages. >> * *OOB* Channel: The SMBus packets are tunneled through eSPI as >> Out-Of-Band (OOB) messages. The whole SMBus packet is embedded >> inside the eSPI OOB message as data. >> * *Flash Access* Channel: The Flash Access channel provides a path >> allowing the flash components to be shared run-time between chipset >> and the eSPI slaves that require flash accesses such as EC (Embedded >> Controller) and BMC. > > Please make binding complete, so define all of the channels. I would like to inquire about the rationale behind this request. Based on previous feedback received from the upstream efforts [https://lore.kernel.org/openbmc/HK0PR06MB37798462D17443C697433D7191D09 at HK0PR06MB3779.apcprd06.prod.outlook.com/], suggestions were made to model the flash channel by utilizing the mtd subsystem, the virtual wire channel by utilizing the GPIO subsystem, and to consider the OOB channel as a type of i2c device, thereby allowing it to be utilized by the existing in-kernel MCTP subsystem, among others. My intention was to prioritize upstreaming the flash channel binding, along with its driver code, before proceeding to address other channels. I am curious to understand if it is a strict requirement to have the complete binding upstreamed before addressing the device drivers code. > >> >> Although , eSPI reuses the timing and electrical specification of Serial >> Peripheral Interface (SPI) but it runs an entirely different protocol to >> meet a set of different requirements. Which is why i felt probably >> placing this in soc was a better choice rather than spi. Do you think >> otherwise ? > > soc is dumping ground for things do not fit other places. Are there any > other buses / IP blocks similar to this one? > > > Best regards, > Krzysztof > Thanks, Manoj From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FACCC54E67 for ; Thu, 28 Mar 2024 11:33:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cwrwYFEKRtlxk+QWcYtaxx6Hw134jSqnDstDsYcTRgE=; b=a6OlIQjZ6JXUEi 6WzmBZEObFDM5IRiTBair0acaU4Y9rzZZIHUZ/Yjb7Z1AjzG9ap2ask/bM+S6LLD1zxhy2Cdv55wq XlB9EZTS0vDk2+UUv45GUy6yRrhUXjWRouNsNALTUf9VtFk7QVVoi6ciDJywdbyaKts8L06dvGdwn LqceJV5spmhaDiKbDZHdtG6JWzmC2V8ibpbygJVfALURrpkaHhPmjqxi9Xz4S5S3f2Ap26Zq0cqKI bYIIm9xmmtm7nKb0Zpca/mLt9JG8tjI5iRlOEEn3d5nxFJiHrEnjj8m2KASIRvciYjgMaHP3Prv0u Ixfz5wDYvr5Y5h0YsT2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpo0w-0000000Dkd3-1W5r; Thu, 28 Mar 2024 11:33:46 +0000 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpo0r-0000000Dkbz-2PH4; Thu, 28 Mar 2024 11:33:43 +0000 Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-5cddc5455aeso544679a12.1; Thu, 28 Mar 2024 04:33:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711625618; x=1712230418; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+kLanRBlqX8HlhHJd1EuboE4CdfDSblPAQpGFR2UoHI=; b=R8kobUXhcU1CsCuhsA9RmE8DNOFXXzxQEnIDZ9DIEv6DBuwJqR6QN4NxVdeKZn85Kx C++HAmKbt7njHSZ3OfHMH5jmDNiYMroZNJgk9KEl56Hmb2YqLV/dyU9+9K6+FVDv3ZEt SHfgDLGrv4b9225Hxy8y1IzvPGNGMr3mR0dpD0HfkakFS1wLFZx9pKE00ks9WtyfIapn DnMSOe652G1DtR52/IoEdGTmW/hAumhvyJBiB9dE37MbBLDLHjw4om4Kh7Qe/XXSU/A4 UhoSPFLiM4nEmNOwG9DSXfAHMup8B9xvo6xfHWmbTHXc+4dKXWCBEBGzYD/QHqJdbFN7 +s6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711625618; x=1712230418; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+kLanRBlqX8HlhHJd1EuboE4CdfDSblPAQpGFR2UoHI=; b=upCz30HASZ1yC+SpTe0Eze5ROiTgdjoHCa6bAHRV/HqS0vvNauZfeadPqrDc4e943r J87BE9hswLizl6Hvve2+okWM3i4Aadjc5EgKC1Slmbq3wf11yUdYzv5Md4xESUDh5OMG /YKOyH1StPRLTX/M0YZNXykFFkyEuGp2b28n4a9u6jRs+R9D2s96dR2cw2UzJvl5WTIt eFa3aA4wIzDyTCJ5Hpmybl7LX0qVPGf8v6jfJWyABp0JFeZqUyrLYDYVU63tnM7xwCEQ 0r0ENdhZEe1K/AIKPRtEuKrd9i9m6PZyH2prFUltcs+IdDm8qPyq3CgBIEdAe7dGPnRE R2aA== X-Forwarded-Encrypted: i=1; AJvYcCUOiVBsFPSL/fCPzvp9Av+Si66dg8cL4sCCsfxrTq6HelnQ1A4Ik2EaGXo7NgBbug/P0oqDjMi/RSWJZngIEoKztl0jViMa6DE1QAI6JyY1/Jn3fzDepAl5UDfpno20A/Lgqkn/5Tc7NBh0K/xC+EjCDMU1 X-Gm-Message-State: AOJu0YzttVGJh5my70ybQ66WG54aAt2hv03JE3ubfq8HYZbYLO3IZjko Ntq+fKygWEXmaDDYYlwAxiNODGFRoaXZAfvOjvpOqlH3xAWBbolnHSrB99A8UGcDHw== X-Google-Smtp-Source: AGHT+IHuuhHhHTN8Vk2oFh7RQ5imuAXNENsjhoN5lsG/+ejPKPrgj43OHqKRbOUo9podhvM5NqfWTQ== X-Received: by 2002:a17:90b:4c8a:b0:2a0:53cf:9bae with SMTP id my10-20020a17090b4c8a00b002a053cf9baemr2142394pjb.32.1711625617852; Thu, 28 Mar 2024 04:33:37 -0700 (PDT) Received: from [192.168.29.219] ([49.37.251.254]) by smtp.gmail.com with ESMTPSA id m5-20020a17090b068500b0029fbfb620cdsm1173744pjz.28.2024.03.28.04.33.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Mar 2024 04:33:37 -0700 (PDT) Message-ID: <582c276c-ea2f-456c-9bf9-47e39289a0b6@gmail.com> Date: Thu, 28 Mar 2024 17:03:30 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] dt-bindings: aspeed: Add eSPI controller To: Krzysztof Kozlowski , patrick.rudolph@9elements.com, chiawei_wang@aspeedtech.com, ryan_chen@aspeedtech.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, jk@codeconstruct.com.au, openbmc@lists.ozlabs.org, broonie@kernel.org, linux-spi@vger.kernel.org References: <20240319093405.39833-1-manojkiran.eda@gmail.com> <20240319093405.39833-5-manojkiran.eda@gmail.com> Content-Language: en-US From: Manojkiran Eda In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240328_043341_675367_C0A09FC0 X-CRM114-Status: GOOD ( 34.01 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org CgpPbiAyMC8wMy8yNCA4OjE0IHBtLCBLcnp5c3p0b2YgS296bG93c2tpIHdyb3RlOgo+IE9uIDIw LzAzLzIwMjQgMTA6NTksIE1hbm9qa2lyYW4gRWRhIHdyb3RlOgo+Pgo+PiBPbiAxOS8wMy8yNCAz OjI2IHBtLCBLcnp5c3p0b2YgS296bG93c2tpIHdyb3RlOgo+Pj4gT24gMTkvMDMvMjAyNCAxMDoz NCwgTWFub2praXJhbiBFZGEgd3JvdGU6Cj4+Pj4gVGhpcyBjb21taXQgYWRkcyB0aGUgZGV2aWNl IHRyZWUgYmluZGluZ3MgZm9yIGFzcGVlZCBlU1BJCj4+Pj4gY29udHJvbGxlci4KPj4+Pgo+Pj4+ IEFsdGhvdWdoIGFzcGVlZCBlU1BJIGhhcmR3YXJlIHN1cHBvcnRzIDQgZGlmZmVyZW50IGNoYW5u ZWxzLAo+Pj4+IHRoaXMgY29tbWl0IG9ubHkgYWRkcyB0aGUgc3VwcG9ydCBmb3IgZmxhc2ggY2hh bm5lbCwgdGhlCj4+Pj4gYmluZGluZ3MgZm9yIG90aGVyIGNoYW5uZWxzIGNvdWxkIGJlIHVwc3Ry ZWFtZWQgd2hlbiB0aGUgZHJpdmVyCj4+Pj4gc3VwcG9ydCBmb3IgdGhvc2UgYXJlIGFkZGVkLgo+ Pj4+Cj4+Pj4gU2lnbmVkLW9mZi1ieTogTWFub2praXJhbiBFZGE8bWFub2praXJhbi5lZGFAZ21h aWwuY29tPgo+Pj4+IC0tLQo+Pj4+ICAgIC4uLi9iaW5kaW5ncy9zb2MvYXNwZWVkL2FzcGVlZCxl c3BpLnlhbWwgICAgICB8IDk0ICsrKysrKysrKysrKysrKysrKysKPj4+PiAgICAxIGZpbGUgY2hh bmdlZCwgOTQgaW5zZXJ0aW9ucygrKQo+Pj4+ICAgIGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvc29jL2FzcGVlZC9hc3BlZWQsZXNwaS55YW1sCj4+ Pj4KPj4+PiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3Nv Yy9hc3BlZWQvYXNwZWVkLGVzcGkueWFtbCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5k aW5ncy9zb2MvYXNwZWVkL2FzcGVlZCxlc3BpLnlhbWwKPj4+PiBuZXcgZmlsZSBtb2RlIDEwMDY0 NAo+Pj4+IGluZGV4IDAwMDAwMDAwMDAwMC4uM2QzYWQ1MjhlM2IzCj4+Pj4gLS0tIC9kZXYvbnVs bAo+Pj4+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9zb2MvYXNwZWVk L2FzcGVlZCxlc3BpLnlhbWwKPj4+IFdoeSBSb2IncyBjb21tZW50cyBnb3QgaWdub3JlZD8KPj4+ Cj4+PiBUaGlzIGlzIG5vdCBhIHNvYyBjb21wb25lbnQuCj4+IEkgZGlkIG5vdCBtZWFuIHRvIGln bm9yZSwgaSBoYXZlIGZldyByZWFzb25zIGxpc3RlZCBiZWxvdyB0aGF0IHByb3ZpZGVzCj4+IGlu Zm9ybWF0aW9uIG9uIHdoeSBpIGZlbHQgdGhpcyBiZWxvbmdzIGludG8gc29jLgo+IAo+IHNvYyBp cyBkdW1waW5nIGdyb3VuZCBvZiB0aGluZ3Mgd2hpY2ggYXJlIHB1cmVseSBTb0Mgc3BlY2lmaWMs IG5vdAo+IGNvdmVyZWQgYnkgZXhpc3RpbmcgaGFyZHdhcmUgc3RydWN0dXJlIGluIGJpbmRpbmdz LiBNYXliZSBpbmRlZWQgdGhpcwo+IGRvZXMgbm90IGhhdmUgYW55IG90aGVyIHBsYWNlLCBidXQg ZGlkIHlvdSBhY3R1YWxseSBsb29rPwo+IAoKWWVzLCBpIGRpZCBsb29rIGF0IGV4aXN0aW5nIGhh cmR3YXJlIGJpbmRpbmdzLCBhbmQgY2Fubm90IHNlZW0gdG8gZmluZCAKb3V0IGFueSBvdGhlciBz dWl0YWJsZSBwbGFjZS4gSSBjYW4gZGVmaW5pdGVseSBsb29rIGFnYWluLgoKPiBBbnl3YXksIHBs ZWFzZSBDQyBTUEkgbWFpbnRhaW5lcnMgb24gZnV0dXJlIHN1Ym1pc3Npb24uCgpTdXJlLCB3aWxs IGFkZCB0aGVtLgoKPiAKPj4+Cj4+Pj4gQEAgLTAsMCArMSw5NCBAQAo+Pj4+ICsjIFNQRFgtTGlj ZW5zZS1JZGVudGlmaWVyOiAoR1BMLTIuMC1vbmx5IE9SIEJTRC0yLUNsYXVzZSkKPj4+PiArIyAj IENvcHlyaWdodCAoYykgMjAyNCBJQk0gQ29ycG9yYXRpb24uCj4+Pj4gKyMgIyBDb3B5cmlnaHQg KGMpIDIwMjEgQXNwZWVkIFRlY2hub2xvZ3kgSW5jLgo+Pj4+ICslWUFNTCAxLjIKPj4+PiArLS0t Cj4+Pj4gKyRpZDpodHRwOi8vZGV2aWNldHJlZS5vcmcvc2NoZW1hcy9zb2MvYXNwZWVkL2FzcGVl ZCxlc3BpLnlhbWwjCj4+Pj4gKyRzY2hlbWE6aHR0cDovL2RldmljZXRyZWUub3JnL21ldGEtc2No ZW1hcy9jb3JlLnlhbWwjCj4+Pj4gKwo+Pj4+ICt0aXRsZTogQXNwZWVkIGVTUEkgQ29udHJvbGxl cgo+Pj4+ICsKPj4+PiArbWFpbnRhaW5lcnM6Cj4+Pj4gKyAgLSBNYW5vamtpcmFuIEVkYTxtYW5v amtpcmFuLmVkYUBnbWFpbC5jb20+Cj4+Pj4gKyAgLSBQYXRyaWNrIFJ1ZG9scGg8cGF0cmljay5y dWRvbHBoQDllbGVtZW50cy5jb20+Cj4+Pj4gKyAgLSBDaGlhLVdlaSBXYW5nPGNoaWF3ZWlfd2Fu Z0Bhc3BlZWR0ZWNoLmNvbT4KPj4+PiArICAtIFJ5YW4gQ2hlbjxyeWFuX2NoZW5AYXNwZWVkdGVj aC5jb20+Cj4+Pj4gKwo+Pj4+ICtkZXNjcmlwdGlvbjoKPj4+PiArICBBc3BlZWQgZVNQSSBjb250 cm9sbGVyIGltcGxlbWVudHMgYSBkZXZpY2Ugc2lkZSBlU1BJIGVuZHBvaW50IGRldmljZQo+Pj4+ ICsgIHN1cHBvcnRpbmcgdGhlIGZsYXNoIGNoYW5uZWwuCj4+PiBFeHBsYWluIHdoYXQgaXMgZVNQ SS4KPj4gZVNQSSBpcyBhIHNlcmlhbCBidXMgaW50ZXJmYWNlIGZvciBjbGllbnQgYW5kIHNlcnZl ciBwbGF0Zm9ybXMgdGhhdCBpcwo+IAo+IEV4cGxhaW4gaW4gZGVzY3JpcHRpb24gb2YgdGhlIGhh cmR3YXJlLgoKU3VyZSwgaSB3aWxsIGFkZCB0aGlzIGRlc2NyaXB0aW9uIGluIHRoZSBiaW5kaW5n IGRvY3VtZW50IGluIHRoZSBmdXR1cmUgCnN1Ym1pc3Npb24uCj4gCj4+IGJhc2VkIG9uIFNQSSzC oCB1c2luZyB0aGUgc2FtZSBtYXN0ZXIgYW5kIHNsYXZlIHRvcG9sb2d5IGJ1dCBvcGVyYXRlcwo+ PiB3aXRoIGEgZGlmZmVyZW50IHByb3RvY29sIHRvIG1lZXQgbmV3IHJlcXVpcmVtZW50cy4gRm9y IGluc3RhbmNlLCBlU1BJCj4+IHVzZXMgSS9PLCBvciBpbnB1dC9vdXRwdXQsIGNvbW11bmljYXRp b24sIGluc3RlYWQgb2YgTU9TSS9NSVNPIHVzZWQgaW4KPj4gU1BJLiBJdCBhbHNvIGluY2x1ZGVz IGEgdHJhbnNhY3Rpb24gbGF5ZXIgb24gdG9wIG9mIHRoZSBTUEkgcHJvdG9jb2wsCj4+IGRlZmlu aW5nIHBhY2tldHMgc3VjaCBhcyBjb21tYW5kIGFuZCByZXNwb25zZSBwYWNrZXRzIHRoYXQgYWxs b3cgYm90aAo+PiB0aGUgbWFzdGVyIGFuZCBzbGF2ZSB0byBpbml0aWF0ZSBhbGVydCBhbmQgcmVz ZXQgc2lnbmFscy4gZVNQSSBzdXBwb3J0cwo+PiBjb21tdW5pY2F0aW9uIGJldHdlZW4gRW1iZWRk ZWQgQ29udHJvbGxlciAoRUMpLCBCYXNlYm9hcmQgTWFuYWdlbWVudAo+PiBDb250cm9sbGVyIChC TUMpLCBTdXBlci1JL08gKFNJTykgYW5kIFBvcnQtODAgZGVidWcgY2FyZHMuIEkgY291bGQgYWRk Cj4+IHRoaXMgdG8gdGhlIGNvbW1pdCBtZXNzYWdlIGFzIHdlbGwgaW4gdGhlIG5leHQgcGF0Y2hz ZXQuCj4+Pgo+Pj4+ICsKPj4+PiArcHJvcGVydGllczoKPj4+PiArICBjb21wYXRpYmxlOgo+Pj4+ ICsgICAgaXRlbXM6Cj4+Pj4gKyAgICAgIC0gZW51bToKPj4+PiArICAgICAgICAgIC0gYXNwZWVk LGFzdDI1MDAtZXNwaQo+Pj4+ICsgICAgICAgICAgLSBhc3BlZWQsYXN0MjYwMC1lc3BpCj4+Pj4g KyAgICAgIC0gY29uc3Q6IHNpbXBsZS1tZmQKPj4+Cj4+PiBUaGF0J3Mgbm90IHNpbXBsZS1tZmQu IFlvdSBoYXZlIGRyaXZlciBmb3IgdGhpcy4gRHJvcC4KPj4+Cj4+Pj4gKyAgICAgIC0gY29uc3Q6 IHN5c2Nvbgo+Pj4gVGhhdCdzIG5vdCBzeXNjb24uIFdoeSBkbyB5b3UgaGF2ZSByYW5nZXMgdGhl bj8gV2hlcmUgaXMgYW55IGV4cGxhbmF0aW9uCj4+PiBvZiBoYXJkd2FyZSB3aGljaCB3b3VsZCBq dXN0aWZ5IHN1Y2ggY29tYmluYXRpb24/Cj4+Pgo+Pj4+ICsKPj4+PiArICByZWc6Cj4+Pj4gKyAg ICBtYXhJdGVtczogMQo+Pj4+ICsKPj4+PiArICAiI2FkZHJlc3MtY2VsbHMiOgo+Pj4+ICsgICAg Y29uc3Q6IDEKPj4+PiArCj4+Pj4gKyAgIiNzaXplLWNlbGxzIjoKPj4+PiArICAgIGNvbnN0OiAx Cj4+Pj4gKwo+Pj4+ICsgIHJhbmdlczogdHJ1ZQo+Pj4+ICsKPj4+PiArcGF0dGVyblByb3BlcnRp ZXM6Cj4+Pj4gKyAgIl5lc3BpLWN0cmxAWzAtOWEtZl0rJCI6Cj4+Pj4gKyAgICB0eXBlOiBvYmpl Y3QKPj4+PiArCj4+Pj4gKyAgICBkZXNjcmlwdGlvbjogQ29udHJvbHMgdGhlIGZsYXNoIGNoYW5u ZWwgb2YgZVNQSSBoYXJkd2FyZQo+Pj4gVGhhdCBleHBsYWlucyBub3RoaW5nLiBVbmxlc3MgeW91 IHdhbnRlZCB0byB1c2UgaGVyZSBNVEQgYmluZGluZ3MuCj4+Pgo+Pj4gVGhpcyBiaW5kaW5nIGRp ZCBub3QgaW1wcm92ZSBtdWNoLiBJIGRvbid0IHVuZGVyc3RhbmQgd2h5IHRoaXMgaXMgbm90Cj4+ PiBTUEkgKG5vdGhpbmcgaW4gY29tbWl0IG1zZywgbm90aGluZyBpbiBkZXNjcmlwdGlvbiksIHdo YXQgaXMgZVNQSSwKPj4KPj4gZVNQSSB1c2VzIFBlcmlwaGVyYWwsIFZpcnR1YWwgV2lyZSwgT3V0 IG9mIEJhbmQsIGFuZCBGbGFzaCBBY2Nlc3MKPj4gY2hhbm5lbHMgdG8gY29tbXVuaWNhdGUgZGlm ZmVyZW50IHNldHMgb2YgZGF0YS4KPiAKPiBBbmQgd2hhdCBhcmUgdGhlc2UgY2hhbm5lbHM/IFdo YXQgZG9lcyBpdCBtZWFuIGEgImNoYW5uZWwiPyBJcyBpdCBqdXN0Cj4gaG93IHlvdSBvcmdhbml6 ZSB0cmFuc2ZlcnMgYW5kIGNsYXNzZXMgb2YgZGV2aWNlcz8gT3Igc29tZSBzb3J0IG9mCj4gYWRk cmVzc2FibGUgaW5zdGFuY2Ugb24gdGhlIGJ1cz8KPiAKClllcywgYW4gZXNwaSBjaGFubmVsIHBy b3ZpZGVzIGEgbWVhbnMgdG8gYWxsb3cgbXVsdGlwbGUgaW5kZXBlbmRlbnQgCmZsb3dzIG9mIHRy YWZmaWMgdG8gc2hhcmUgdGhlIHNhbWUgcGh5c2ljYWwgYnVzLiBFYWNoIG9mIHRoZSBjaGFubmVs cyAKaGFzIGl0cyBvd24gZGVkaWNhdGVkIHJlc291cmNlcyBzdWNoIGFzIHF1ZXVlIGFuZCBmbG93 IGNvbnRyb2wuCgo+IFRoZSBjaGFubmVscyBmZWVsIGxpa2Ugc29tZSBzb3J0IG9mIHNvZnR3YXJl IG9yIGxvZ2ljYWwgY29uY2VwdCwgbm90Cj4gcGh5c2ljYWwuIFBoeXNpY2FsIHdvdWxkIGJlIGVu ZHBvaW50IHdpdGggcGVyaXBoZXJhbC4gT3IgZmxhc2ggbWVtb3J5LgoKQSBjaGFubmVsIGlzIGEg bG9naWNhbCBjb21tdW5pY2F0aW9uIHBhdGh3YXkgb3IgaW50ZXJmYWNlIGJldHdlZW4gdGhlIApj aGlwc2V0IGFuZCBwZXJpcGhlcmFsIGRldmljZXMuIFRoZSBjb25jZXB0IG9mIGNoYW5uZWxzIGlu IHRoZSBFU1BJIApwcm90b2NvbCBoZWxwcyBvcmdhbml6ZSBhbmQgbWFuYWdlIGRpZmZlcmVudCB0 eXBlcyBvZiBjb21tdW5pY2F0aW9uIApiZXR3ZWVuIHRoZSBjaGlwc2V0IGFuZCBwZXJpcGhlcmFs cy4gRWFjaCBjaGFubmVsIG1heSBoYXZlIGl0cyBvd24gc2V0IApvZiBwcm90b2NvbHMsIGRhdGEg dHJhbnNmZXIgcmF0ZXMsIGFuZCBzdXBwb3J0ZWQgZmVhdHVyZXMsIHRhaWxvcmVkIHRvIAp0aGUg cmVxdWlyZW1lbnRzIG9mIHRoZSBkZXZpY2VzIGl0IHNlcnZlcy4KCj4gSG93IGRvIHRoZXkgZml0 IGhlcmU/CgpJIGFtIG5vdCBzdXJlIEkgdW5kZXJzdGFuZCwgY2FuIHlvdSBwbGVhc2UgZWxhYm9y YXRlID8KCj4+Cj4+ICAgICogVGhlICpQZXJpcGhlcmFsKiBDaGFubmVsIGlzIHVzZWQgZm9yIGNv bW11bmljYXRpb24gYmV0d2VlbiBlU1BJIGhvc3QKPj4gICAgICBicmlkZ2UgbG9jYXRlZCBvbiB0 aGUgbWFzdGVyIHNpZGUgYW5kIGVTUEkgZW5kcG9pbnRzIGxvY2F0ZWQgb24gdGhlCj4+ICAgICAg c2xhdmUgc2lkZS4gTFBDIEhvc3QgYW5kIExQQyBQZXJpcGhlcmFscyBhcmUgYW4gZXhhbXBsZSBv ZiBlU1BJIGhvc3QKPj4gICAgICBicmlkZ2UgYW5kIGVTUEkgZW5kcG9pbnRzIHJlc3BlY3RpdmVs eS4KPj4gICAgKiAqVmlydHVhbCBXaXJlKiBDaGFubmVsOiBUaGUgVmlydHVhbCBXaXJlIGNoYW5u ZWwgaXMgdXNlZCB0bwo+PiAgICAgIGNvbW11bmljYXRlIHRoZSBzdGF0ZSBvZiBzaWRlYmFuZCBw aW5zIG9yIEdQSU8gdHVubmVsZWQgdGhyb3VnaCBlU1BJCj4+ICAgICAgYXMgaW4tYmFuZCBtZXNz YWdlcy4gU2VyaWFsIElSUSBpbnRlcnJ1cHRzIGFyZSBjb21tdW5pY2F0ZWQgdGhyb3VnaAo+PiAg ICAgIHRoaXMgY2hhbm5lbCBhcyBpbi1iYW5kIG1lc3NhZ2VzLgo+PiAgICAqICpPT0IqIENoYW5u ZWw6IFRoZSBTTUJ1cyBwYWNrZXRzIGFyZSB0dW5uZWxlZCB0aHJvdWdoIGVTUEkgYXMKPj4gICAg ICBPdXQtT2YtQmFuZCAoT09CKSBtZXNzYWdlcy4gVGhlIHdob2xlIFNNQnVzIHBhY2tldCBpcyBl bWJlZGRlZAo+PiAgICAgIGluc2lkZSB0aGUgZVNQSSBPT0IgbWVzc2FnZSBhcyBkYXRhLgo+PiAg ICAqICpGbGFzaCBBY2Nlc3MqIENoYW5uZWw6IFRoZSBGbGFzaCBBY2Nlc3MgY2hhbm5lbCBwcm92 aWRlcyBhIHBhdGgKPj4gICAgICBhbGxvd2luZyB0aGUgZmxhc2ggY29tcG9uZW50cyB0byBiZSBz aGFyZWQgcnVuLXRpbWUgYmV0d2VlbiBjaGlwc2V0Cj4+ICAgICAgYW5kIHRoZSBlU1BJIHNsYXZl cyB0aGF0IHJlcXVpcmUgZmxhc2ggYWNjZXNzZXMgc3VjaCBhcyBFQyAoRW1iZWRkZWQKPj4gICAg ICBDb250cm9sbGVyKSBhbmQgQk1DLgo+IAo+IFBsZWFzZSBtYWtlIGJpbmRpbmcgY29tcGxldGUs IHNvIGRlZmluZSBhbGwgb2YgdGhlIGNoYW5uZWxzLgoKCkkgd291bGQgbGlrZSB0byBpbnF1aXJl IGFib3V0IHRoZSByYXRpb25hbGUgYmVoaW5kIHRoaXMgcmVxdWVzdC4gQmFzZWQgCm9uIHByZXZp b3VzIGZlZWRiYWNrIHJlY2VpdmVkIGZyb20gdGhlIHVwc3RyZWFtIGVmZm9ydHMgCltodHRwczov L2xvcmUua2VybmVsLm9yZy9vcGVuYm1jL0hLMFBSMDZNQjM3Nzk4NDYyRDE3NDQzQzY5NzQzM0Q3 MTkxRDA5QEhLMFBSMDZNQjM3NzkuYXBjcHJkMDYucHJvZC5vdXRsb29rLmNvbS9dLCAKc3VnZ2Vz dGlvbnMgd2VyZSBtYWRlIHRvIG1vZGVsIHRoZSBmbGFzaCBjaGFubmVsIGJ5IHV0aWxpemluZyB0 aGUgbXRkIApzdWJzeXN0ZW0sIHRoZSB2aXJ0dWFsIHdpcmUgY2hhbm5lbCBieSB1dGlsaXppbmcg dGhlIEdQSU8gc3Vic3lzdGVtLCBhbmQgCnRvIGNvbnNpZGVyIHRoZSBPT0IgY2hhbm5lbCBhcyBh IHR5cGUgb2YgaTJjIGRldmljZSwgdGhlcmVieSBhbGxvd2luZyBpdCAKdG8gYmUgdXRpbGl6ZWQg YnkgdGhlIGV4aXN0aW5nIGluLWtlcm5lbCBNQ1RQIHN1YnN5c3RlbSwgYW1vbmcgb3RoZXJzLiAK TXkgaW50ZW50aW9uIHdhcyB0byBwcmlvcml0aXplIHVwc3RyZWFtaW5nIHRoZSBmbGFzaCBjaGFu bmVsIGJpbmRpbmcsIAphbG9uZyB3aXRoIGl0cyBkcml2ZXIgY29kZSwgYmVmb3JlIHByb2NlZWRp bmcgdG8gYWRkcmVzcyBvdGhlciBjaGFubmVscy4gCkkgYW0gY3VyaW91cyB0byB1bmRlcnN0YW5k IGlmIGl0IGlzIGEgc3RyaWN0IHJlcXVpcmVtZW50IHRvIGhhdmUgdGhlIApjb21wbGV0ZSBiaW5k aW5nIHVwc3RyZWFtZWQgYmVmb3JlIGFkZHJlc3NpbmcgdGhlIGRldmljZSBkcml2ZXJzIGNvZGUu Cgo+IAo+Pgo+PiBBbHRob3VnaCAsIGVTUEkgcmV1c2VzIHRoZSB0aW1pbmcgYW5kIGVsZWN0cmlj YWwgc3BlY2lmaWNhdGlvbiBvZiBTZXJpYWwKPj4gUGVyaXBoZXJhbCBJbnRlcmZhY2UgKFNQSSkg YnV0IGl0IHJ1bnMgYW4gZW50aXJlbHkgZGlmZmVyZW50IHByb3RvY29sIHRvCj4+IG1lZXQgYSBz ZXQgb2YgZGlmZmVyZW50IHJlcXVpcmVtZW50cy4gV2hpY2ggaXMgd2h5IGkgZmVsdCBwcm9iYWJs eQo+PiBwbGFjaW5nIHRoaXMgaW4gc29jIHdhcyBhIGJldHRlciBjaG9pY2UgcmF0aGVyIHRoYW4g c3BpLiBEbyB5b3UgdGhpbmsKPj4gb3RoZXJ3aXNlID8KPiAKPiBzb2MgaXMgZHVtcGluZyBncm91 bmQgZm9yIHRoaW5ncyBkbyBub3QgZml0IG90aGVyIHBsYWNlcy4gQXJlIHRoZXJlIGFueQo+IG90 aGVyIGJ1c2VzIC8gSVAgYmxvY2tzIHNpbWlsYXIgdG8gdGhpcyBvbmU/Cj4gCj4gCj4gQmVzdCBy ZWdhcmRzLAo+IEtyenlzenRvZgo+IAoKVGhhbmtzLApNYW5vagoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9u IG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C935C4E1D1; Thu, 28 Mar 2024 11:33:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711625620; cv=none; b=LYkDJNBvgWhinHjiI8F89uriBlSitNtLevUgMwPVePW5MivL3+eC0tUSRWzxCPhv+DQKwS4x6AMGNsZcR4Jd+jTXsa6wnPkKCteydhAQZ0p6/TOKTE3EvTLunH/ZJT/XREBxfrEW0ENSoWoPXPPyUP8/0oRu0e8MPyrCew2V3hM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711625620; c=relaxed/simple; bh=7fZE3G1lOu+XdO+WmKhirf4I/Hy+9Ns0NfZeXbyBk3w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JyqqsbHCUyOHEerK5V9OMDKoYIQdhhIU7taZr3DlINQ5c+4qdcOHrRzrPxdJ8tGkSQDw8VXEp0ZQQsw93zn48bMfh2t0kng1wjBnKv6YLCIHgAUJxyD3KoZXazC/aSkqG1vtgvwfwiaRcrtueJOq7JSaWpfKPPM9Dov/6hi3iRQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MujHIGYJ; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MujHIGYJ" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6e74bd85f26so741840b3a.1; Thu, 28 Mar 2024 04:33:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711625618; x=1712230418; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+kLanRBlqX8HlhHJd1EuboE4CdfDSblPAQpGFR2UoHI=; b=MujHIGYJirYvQeXTasbWHbETsKxMrFoSKWtEuppJYmLlHCDKG8KVlPxcPZICK59Rir PmpCDt/hEDBC0ej35qF1O6a9mQzi2N5Ra1Pb1go0SWMRGKLB6YAUt0el8vRhLgQSF/YJ g+dtWspNtU4Gls7pnI3+1J3MAA9FGBM+klhcbJwvZQRA/L5xNLBtIhtvu7QQRmlG99ze AqbT7k9dX8I1HTkGHlJ6NlE1oXU0Q6/dMMuGHjZW72tmn5iRBepVwBgsqXuk+J1zWG2F 5BjQts4InOlCUXLxTC/J4p4SJs7pgFuVUEstpuIobC47WNfgPysee2pOu0DfwRYbRcmM ORDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711625618; x=1712230418; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+kLanRBlqX8HlhHJd1EuboE4CdfDSblPAQpGFR2UoHI=; b=DIG9u9zNs0Hg+kSy4qh2Boh6+S250qubMYwhg82XLmeuWveDqL+/tnqNoJ0Qj+7LnY Awg4CprI9an2y/LCTLviJ3HcvI3GJsopn+OIdyawZuyWBsqcwbal3Zp8BR0DFai7HhhC piRCyq7JEGXPglrJX8wF63RnisRdjMkwwvkKbEQjJYrTfenME3vwZraICGUnQsWr6zK/ eZinyMOHinTrpVHljA3OEsOnXrv5knC51FHZk9NKVKmUG2WKC38QHJ27fVe+QvKKpYV2 julkxCTsrkrR1swCmB/5Cq5h3FvYTos1eOSZyrktmR0vP8LUYSC8/+kG+ogmGYEy1tFZ 0Heg== X-Forwarded-Encrypted: i=1; AJvYcCV9UJtpLvDFK9fSMayfg7VPVxEBZKNl2euP7NeidnjrlDPmSU9k+PMGqzNea8OR5hkiItDK47sGDYhmpez0Atq21c2CWhrlbME1zzpAm4liOX4FDz5BWlshVkZX+wD+gBB3jFJGhwda5Wt8xCbJmZW/ShV1c1IYq6WynHmuzqegXscVKA== X-Gm-Message-State: AOJu0Yx0MogRvxQ1BnE1YMQ8Y4BtTkLxviSZFMCDhzkyn0Zs1CJW1pKS r/hVnrjgenzP8NShR6hJS5qWEWgceIwfnMmFkiA2MHIz7ez6nnLU X-Google-Smtp-Source: AGHT+IHuuhHhHTN8Vk2oFh7RQ5imuAXNENsjhoN5lsG/+ejPKPrgj43OHqKRbOUo9podhvM5NqfWTQ== X-Received: by 2002:a17:90b:4c8a:b0:2a0:53cf:9bae with SMTP id my10-20020a17090b4c8a00b002a053cf9baemr2142394pjb.32.1711625617852; Thu, 28 Mar 2024 04:33:37 -0700 (PDT) Received: from [192.168.29.219] ([49.37.251.254]) by smtp.gmail.com with ESMTPSA id m5-20020a17090b068500b0029fbfb620cdsm1173744pjz.28.2024.03.28.04.33.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Mar 2024 04:33:37 -0700 (PDT) Message-ID: <582c276c-ea2f-456c-9bf9-47e39289a0b6@gmail.com> Date: Thu, 28 Mar 2024 17:03:30 +0530 Precedence: bulk X-Mailing-List: linux-spi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] dt-bindings: aspeed: Add eSPI controller To: Krzysztof Kozlowski , patrick.rudolph@9elements.com, chiawei_wang@aspeedtech.com, ryan_chen@aspeedtech.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, jk@codeconstruct.com.au, openbmc@lists.ozlabs.org, broonie@kernel.org, linux-spi@vger.kernel.org References: <20240319093405.39833-1-manojkiran.eda@gmail.com> <20240319093405.39833-5-manojkiran.eda@gmail.com> Content-Language: en-US From: Manojkiran Eda In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 20/03/24 8:14 pm, Krzysztof Kozlowski wrote: > On 20/03/2024 10:59, Manojkiran Eda wrote: >> >> On 19/03/24 3:26 pm, Krzysztof Kozlowski wrote: >>> On 19/03/2024 10:34, Manojkiran Eda wrote: >>>> This commit adds the device tree bindings for aspeed eSPI >>>> controller. >>>> >>>> Although aspeed eSPI hardware supports 4 different channels, >>>> this commit only adds the support for flash channel, the >>>> bindings for other channels could be upstreamed when the driver >>>> support for those are added. >>>> >>>> Signed-off-by: Manojkiran Eda >>>> --- >>>> .../bindings/soc/aspeed/aspeed,espi.yaml | 94 +++++++++++++++++++ >>>> 1 file changed, 94 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/soc/aspeed/aspeed,espi.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/soc/aspeed/aspeed,espi.yaml b/Documentation/devicetree/bindings/soc/aspeed/aspeed,espi.yaml >>>> new file mode 100644 >>>> index 000000000000..3d3ad528e3b3 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/soc/aspeed/aspeed,espi.yaml >>> Why Rob's comments got ignored? >>> >>> This is not a soc component. >> I did not mean to ignore, i have few reasons listed below that provides >> information on why i felt this belongs into soc. > > soc is dumping ground of things which are purely SoC specific, not > covered by existing hardware structure in bindings. Maybe indeed this > does not have any other place, but did you actually look? > Yes, i did look at existing hardware bindings, and cannot seem to find out any other suitable place. I can definitely look again. > Anyway, please CC SPI maintainers on future submission. Sure, will add them. > >>> >>>> @@ -0,0 +1,94 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +# # Copyright (c) 2024 IBM Corporation. >>>> +# # Copyright (c) 2021 Aspeed Technology Inc. >>>> +%YAML 1.2 >>>> +--- >>>> +$id:http://devicetree.org/schemas/soc/aspeed/aspeed,espi.yaml# >>>> +$schema:http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Aspeed eSPI Controller >>>> + >>>> +maintainers: >>>> + - Manojkiran Eda >>>> + - Patrick Rudolph >>>> + - Chia-Wei Wang >>>> + - Ryan Chen >>>> + >>>> +description: >>>> + Aspeed eSPI controller implements a device side eSPI endpoint device >>>> + supporting the flash channel. >>> Explain what is eSPI. >> eSPI is a serial bus interface for client and server platforms that is > > Explain in description of the hardware. Sure, i will add this description in the binding document in the future submission. > >> based on SPI,  using the same master and slave topology but operates >> with a different protocol to meet new requirements. For instance, eSPI >> uses I/O, or input/output, communication, instead of MOSI/MISO used in >> SPI. It also includes a transaction layer on top of the SPI protocol, >> defining packets such as command and response packets that allow both >> the master and slave to initiate alert and reset signals. eSPI supports >> communication between Embedded Controller (EC), Baseboard Management >> Controller (BMC), Super-I/O (SIO) and Port-80 debug cards. I could add >> this to the commit message as well in the next patchset. >>> >>>> + >>>> +properties: >>>> + compatible: >>>> + items: >>>> + - enum: >>>> + - aspeed,ast2500-espi >>>> + - aspeed,ast2600-espi >>>> + - const: simple-mfd >>> >>> That's not simple-mfd. You have driver for this. Drop. >>> >>>> + - const: syscon >>> That's not syscon. Why do you have ranges then? Where is any explanation >>> of hardware which would justify such combination? >>> >>>> + >>>> + reg: >>>> + maxItems: 1 >>>> + >>>> + "#address-cells": >>>> + const: 1 >>>> + >>>> + "#size-cells": >>>> + const: 1 >>>> + >>>> + ranges: true >>>> + >>>> +patternProperties: >>>> + "^espi-ctrl@[0-9a-f]+$": >>>> + type: object >>>> + >>>> + description: Controls the flash channel of eSPI hardware >>> That explains nothing. Unless you wanted to use here MTD bindings. >>> >>> This binding did not improve much. I don't understand why this is not >>> SPI (nothing in commit msg, nothing in description), what is eSPI, >> >> eSPI uses Peripheral, Virtual Wire, Out of Band, and Flash Access >> channels to communicate different sets of data. > > And what are these channels? What does it mean a "channel"? Is it just > how you organize transfers and classes of devices? Or some sort of > addressable instance on the bus? > Yes, an espi channel provides a means to allow multiple independent flows of traffic to share the same physical bus. Each of the channels has its own dedicated resources such as queue and flow control. > The channels feel like some sort of software or logical concept, not > physical. Physical would be endpoint with peripheral. Or flash memory. A channel is a logical communication pathway or interface between the chipset and peripheral devices. The concept of channels in the ESPI protocol helps organize and manage different types of communication between the chipset and peripherals. Each channel may have its own set of protocols, data transfer rates, and supported features, tailored to the requirements of the devices it serves. > How do they fit here? I am not sure I understand, can you please elaborate ? >> >> * The *Peripheral* Channel is used for communication between eSPI host >> bridge located on the master side and eSPI endpoints located on the >> slave side. LPC Host and LPC Peripherals are an example of eSPI host >> bridge and eSPI endpoints respectively. >> * *Virtual Wire* Channel: The Virtual Wire channel is used to >> communicate the state of sideband pins or GPIO tunneled through eSPI >> as in-band messages. Serial IRQ interrupts are communicated through >> this channel as in-band messages. >> * *OOB* Channel: The SMBus packets are tunneled through eSPI as >> Out-Of-Band (OOB) messages. The whole SMBus packet is embedded >> inside the eSPI OOB message as data. >> * *Flash Access* Channel: The Flash Access channel provides a path >> allowing the flash components to be shared run-time between chipset >> and the eSPI slaves that require flash accesses such as EC (Embedded >> Controller) and BMC. > > Please make binding complete, so define all of the channels. I would like to inquire about the rationale behind this request. Based on previous feedback received from the upstream efforts [https://lore.kernel.org/openbmc/HK0PR06MB37798462D17443C697433D7191D09@HK0PR06MB3779.apcprd06.prod.outlook.com/], suggestions were made to model the flash channel by utilizing the mtd subsystem, the virtual wire channel by utilizing the GPIO subsystem, and to consider the OOB channel as a type of i2c device, thereby allowing it to be utilized by the existing in-kernel MCTP subsystem, among others. My intention was to prioritize upstreaming the flash channel binding, along with its driver code, before proceeding to address other channels. I am curious to understand if it is a strict requirement to have the complete binding upstreamed before addressing the device drivers code. > >> >> Although , eSPI reuses the timing and electrical specification of Serial >> Peripheral Interface (SPI) but it runs an entirely different protocol to >> meet a set of different requirements. Which is why i felt probably >> placing this in soc was a better choice rather than spi. Do you think >> otherwise ? > > soc is dumping ground for things do not fit other places. Are there any > other buses / IP blocks similar to this one? > > > Best regards, > Krzysztof > Thanks, Manoj From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5560C54E64 for ; Thu, 28 Mar 2024 11:34:37 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=dljgceTU; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4V51fN1J2xz3vY9 for ; Thu, 28 Mar 2024 22:34:36 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=dljgceTU; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::532; helo=mail-pg1-x532.google.com; envelope-from=manojkiran.eda@gmail.com; receiver=lists.ozlabs.org) Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4V51dN2PS9z3dXb; Thu, 28 Mar 2024 22:33:42 +1100 (AEDT) Received: by mail-pg1-x532.google.com with SMTP id 41be03b00d2f7-5d8b70b39efso655950a12.0; Thu, 28 Mar 2024 04:33:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711625618; x=1712230418; darn=lists.ozlabs.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+kLanRBlqX8HlhHJd1EuboE4CdfDSblPAQpGFR2UoHI=; b=dljgceTUK0PS7dI7b5JzJdNymZTx7jIczpCOuQEx6bBP+RdNFtjOYQZTJDLPavTy2O vsXKKT8AZPJWBfEPqVpgwwohMrrjxWDXsZw0xgXz2eMufSmEjoCzIKvv+kT8vJ1UzSWV bqw1MDkXb7+2TrYFoTklGED45NI4DEKlKKfyRL5nbobwh1tFwML7UCWkNTKABuR1+0Rp ccjtKndF5GUl6sj8bmZDD8pSlPxLz77sS1yP6yaZJpQXqkyku3rClDa4dcygPwUuavpD gQGBkaVIs4jn9U922siuNC0TRpJpnAce6zEweoNVNTOqXtTHYK5H08Te4h+3CslJbDXD Y60Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711625618; x=1712230418; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+kLanRBlqX8HlhHJd1EuboE4CdfDSblPAQpGFR2UoHI=; b=ldwRpf+hfTHPJis2X7QRDttZ+F8P53eXevel/IPkSIfa0ZcOfi28cST4jX7GZL+07i d+XMAUHXQUAtRSVkIvhupzPpvFHKfjpRhnp1Uins5WD5smxCwBn8rGElqlvULsS6LbdO G9ma3ib0VRN3xiWTrf75Scouke+QIjf9eQ8PApKYdU77msNNbTus3lsiUfbQNUcZ2Z4k VkWAaEL/6yKL43JQFg2vO8etK0JT5+ROo5sXC7eY+Jivs35nF5odUjy6qiF0e9K9AgSj jhyW4zuf8+Dg//7OWW1RXJ9TXVcB8GxR4jvZAyJcPdPPMnO0wpmmx/2q1kHmk9+/Mee4 1+7Q== X-Forwarded-Encrypted: i=1; AJvYcCVFSOMK505XZy8pyxHmD5KKT1D6eaHNmWj3d7tA14MVurSehJUizxds3uxTpwrx+Ex61nW4v/1A+djtqvAA/r/LDqKiEVxMLvcj6hv4bCm9UBekX5JYgj89OtoP8X067mqfpWDqqXBv X-Gm-Message-State: AOJu0YyOtTQDNrki4P0TbwP68AKs3KesduAss1saPf91Xg3bVdXei+hi JBBNr2dWsqJ/6thg4GKpis/wBL78znhXdCurf9XsRu1/YypZJRd7 X-Google-Smtp-Source: AGHT+IHuuhHhHTN8Vk2oFh7RQ5imuAXNENsjhoN5lsG/+ejPKPrgj43OHqKRbOUo9podhvM5NqfWTQ== X-Received: by 2002:a17:90b:4c8a:b0:2a0:53cf:9bae with SMTP id my10-20020a17090b4c8a00b002a053cf9baemr2142394pjb.32.1711625617852; Thu, 28 Mar 2024 04:33:37 -0700 (PDT) Received: from [192.168.29.219] ([49.37.251.254]) by smtp.gmail.com with ESMTPSA id m5-20020a17090b068500b0029fbfb620cdsm1173744pjz.28.2024.03.28.04.33.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Mar 2024 04:33:37 -0700 (PDT) Message-ID: <582c276c-ea2f-456c-9bf9-47e39289a0b6@gmail.com> Date: Thu, 28 Mar 2024 17:03:30 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] dt-bindings: aspeed: Add eSPI controller To: Krzysztof Kozlowski , patrick.rudolph@9elements.com, chiawei_wang@aspeedtech.com, ryan_chen@aspeedtech.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org References: <20240319093405.39833-1-manojkiran.eda@gmail.com> <20240319093405.39833-5-manojkiran.eda@gmail.com> Content-Language: en-US From: Manojkiran Eda In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: conor+dt@kernel.org, vigneshr@ti.com, richard@nod.at, openbmc@lists.ozlabs.org, linux-spi@vger.kernel.org, robh+dt@kernel.org, broonie@kernel.org, joel@jms.id.au, krzysztof.kozlowski+dt@linaro.org, miquel.raynal@bootlin.com, jk@codeconstruct.com.au Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On 20/03/24 8:14 pm, Krzysztof Kozlowski wrote: > On 20/03/2024 10:59, Manojkiran Eda wrote: >> >> On 19/03/24 3:26 pm, Krzysztof Kozlowski wrote: >>> On 19/03/2024 10:34, Manojkiran Eda wrote: >>>> This commit adds the device tree bindings for aspeed eSPI >>>> controller. >>>> >>>> Although aspeed eSPI hardware supports 4 different channels, >>>> this commit only adds the support for flash channel, the >>>> bindings for other channels could be upstreamed when the driver >>>> support for those are added. >>>> >>>> Signed-off-by: Manojkiran Eda >>>> --- >>>> .../bindings/soc/aspeed/aspeed,espi.yaml | 94 +++++++++++++++++++ >>>> 1 file changed, 94 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/soc/aspeed/aspeed,espi.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/soc/aspeed/aspeed,espi.yaml b/Documentation/devicetree/bindings/soc/aspeed/aspeed,espi.yaml >>>> new file mode 100644 >>>> index 000000000000..3d3ad528e3b3 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/soc/aspeed/aspeed,espi.yaml >>> Why Rob's comments got ignored? >>> >>> This is not a soc component. >> I did not mean to ignore, i have few reasons listed below that provides >> information on why i felt this belongs into soc. > > soc is dumping ground of things which are purely SoC specific, not > covered by existing hardware structure in bindings. Maybe indeed this > does not have any other place, but did you actually look? > Yes, i did look at existing hardware bindings, and cannot seem to find out any other suitable place. I can definitely look again. > Anyway, please CC SPI maintainers on future submission. Sure, will add them. > >>> >>>> @@ -0,0 +1,94 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>> +# # Copyright (c) 2024 IBM Corporation. >>>> +# # Copyright (c) 2021 Aspeed Technology Inc. >>>> +%YAML 1.2 >>>> +--- >>>> +$id:http://devicetree.org/schemas/soc/aspeed/aspeed,espi.yaml# >>>> +$schema:http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Aspeed eSPI Controller >>>> + >>>> +maintainers: >>>> + - Manojkiran Eda >>>> + - Patrick Rudolph >>>> + - Chia-Wei Wang >>>> + - Ryan Chen >>>> + >>>> +description: >>>> + Aspeed eSPI controller implements a device side eSPI endpoint device >>>> + supporting the flash channel. >>> Explain what is eSPI. >> eSPI is a serial bus interface for client and server platforms that is > > Explain in description of the hardware. Sure, i will add this description in the binding document in the future submission. > >> based on SPI,  using the same master and slave topology but operates >> with a different protocol to meet new requirements. For instance, eSPI >> uses I/O, or input/output, communication, instead of MOSI/MISO used in >> SPI. It also includes a transaction layer on top of the SPI protocol, >> defining packets such as command and response packets that allow both >> the master and slave to initiate alert and reset signals. eSPI supports >> communication between Embedded Controller (EC), Baseboard Management >> Controller (BMC), Super-I/O (SIO) and Port-80 debug cards. I could add >> this to the commit message as well in the next patchset. >>> >>>> + >>>> +properties: >>>> + compatible: >>>> + items: >>>> + - enum: >>>> + - aspeed,ast2500-espi >>>> + - aspeed,ast2600-espi >>>> + - const: simple-mfd >>> >>> That's not simple-mfd. You have driver for this. Drop. >>> >>>> + - const: syscon >>> That's not syscon. Why do you have ranges then? Where is any explanation >>> of hardware which would justify such combination? >>> >>>> + >>>> + reg: >>>> + maxItems: 1 >>>> + >>>> + "#address-cells": >>>> + const: 1 >>>> + >>>> + "#size-cells": >>>> + const: 1 >>>> + >>>> + ranges: true >>>> + >>>> +patternProperties: >>>> + "^espi-ctrl@[0-9a-f]+$": >>>> + type: object >>>> + >>>> + description: Controls the flash channel of eSPI hardware >>> That explains nothing. Unless you wanted to use here MTD bindings. >>> >>> This binding did not improve much. I don't understand why this is not >>> SPI (nothing in commit msg, nothing in description), what is eSPI, >> >> eSPI uses Peripheral, Virtual Wire, Out of Band, and Flash Access >> channels to communicate different sets of data. > > And what are these channels? What does it mean a "channel"? Is it just > how you organize transfers and classes of devices? Or some sort of > addressable instance on the bus? > Yes, an espi channel provides a means to allow multiple independent flows of traffic to share the same physical bus. Each of the channels has its own dedicated resources such as queue and flow control. > The channels feel like some sort of software or logical concept, not > physical. Physical would be endpoint with peripheral. Or flash memory. A channel is a logical communication pathway or interface between the chipset and peripheral devices. The concept of channels in the ESPI protocol helps organize and manage different types of communication between the chipset and peripherals. Each channel may have its own set of protocols, data transfer rates, and supported features, tailored to the requirements of the devices it serves. > How do they fit here? I am not sure I understand, can you please elaborate ? >> >> * The *Peripheral* Channel is used for communication between eSPI host >> bridge located on the master side and eSPI endpoints located on the >> slave side. LPC Host and LPC Peripherals are an example of eSPI host >> bridge and eSPI endpoints respectively. >> * *Virtual Wire* Channel: The Virtual Wire channel is used to >> communicate the state of sideband pins or GPIO tunneled through eSPI >> as in-band messages. Serial IRQ interrupts are communicated through >> this channel as in-band messages. >> * *OOB* Channel: The SMBus packets are tunneled through eSPI as >> Out-Of-Band (OOB) messages. The whole SMBus packet is embedded >> inside the eSPI OOB message as data. >> * *Flash Access* Channel: The Flash Access channel provides a path >> allowing the flash components to be shared run-time between chipset >> and the eSPI slaves that require flash accesses such as EC (Embedded >> Controller) and BMC. > > Please make binding complete, so define all of the channels. I would like to inquire about the rationale behind this request. Based on previous feedback received from the upstream efforts [https://lore.kernel.org/openbmc/HK0PR06MB37798462D17443C697433D7191D09@HK0PR06MB3779.apcprd06.prod.outlook.com/], suggestions were made to model the flash channel by utilizing the mtd subsystem, the virtual wire channel by utilizing the GPIO subsystem, and to consider the OOB channel as a type of i2c device, thereby allowing it to be utilized by the existing in-kernel MCTP subsystem, among others. My intention was to prioritize upstreaming the flash channel binding, along with its driver code, before proceeding to address other channels. I am curious to understand if it is a strict requirement to have the complete binding upstreamed before addressing the device drivers code. > >> >> Although , eSPI reuses the timing and electrical specification of Serial >> Peripheral Interface (SPI) but it runs an entirely different protocol to >> meet a set of different requirements. Which is why i felt probably >> placing this in soc was a better choice rather than spi. Do you think >> otherwise ? > > soc is dumping ground for things do not fit other places. Are there any > other buses / IP blocks similar to this one? > > > Best regards, > Krzysztof > Thanks, Manoj From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92BCCC54E64 for ; Thu, 28 Mar 2024 11:33:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1sSsAr0LW5lueH7Tv3RjsTTxK7pxpT8snK4PzpkJ8As=; b=JLvFOJyG+WvOXw kqO1rkiaPtJHG50Y0a3rO8HnbNf2DexHgcAJpRSgD7QahKrcs/ws6MYLwoPPn4PSn90ercmI6IHBa cSY2Trl9icqoBEC95PAxGJQnriZAYvw8+VRDRIlu6qNPUYebYBNMyOoLejJwL9XQdw4tnKljrQpsd JlaaiEfhHbsh2Tx8UbUKOLk7nAbHSdy/V5WFVfQIiozTrvZENJOVVc1xoQb5sE0Z2/m9YRgCcaMta +oPFIJO8NYg9iGFK3frSOQhW1cQSWFHNuGhzFO6pWnZFsKxyTCst3os/xAhbO1b4Vo/cXsznak5oB nPKrmJBb4Z6NErQrEyAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpo0u-0000000Dkck-2K1P; Thu, 28 Mar 2024 11:33:44 +0000 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpo0r-0000000Dkbz-2PH4; Thu, 28 Mar 2024 11:33:43 +0000 Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-5cddc5455aeso544679a12.1; Thu, 28 Mar 2024 04:33:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711625618; x=1712230418; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+kLanRBlqX8HlhHJd1EuboE4CdfDSblPAQpGFR2UoHI=; b=R8kobUXhcU1CsCuhsA9RmE8DNOFXXzxQEnIDZ9DIEv6DBuwJqR6QN4NxVdeKZn85Kx C++HAmKbt7njHSZ3OfHMH5jmDNiYMroZNJgk9KEl56Hmb2YqLV/dyU9+9K6+FVDv3ZEt SHfgDLGrv4b9225Hxy8y1IzvPGNGMr3mR0dpD0HfkakFS1wLFZx9pKE00ks9WtyfIapn DnMSOe652G1DtR52/IoEdGTmW/hAumhvyJBiB9dE37MbBLDLHjw4om4Kh7Qe/XXSU/A4 UhoSPFLiM4nEmNOwG9DSXfAHMup8B9xvo6xfHWmbTHXc+4dKXWCBEBGzYD/QHqJdbFN7 +s6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711625618; x=1712230418; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+kLanRBlqX8HlhHJd1EuboE4CdfDSblPAQpGFR2UoHI=; b=upCz30HASZ1yC+SpTe0Eze5ROiTgdjoHCa6bAHRV/HqS0vvNauZfeadPqrDc4e943r J87BE9hswLizl6Hvve2+okWM3i4Aadjc5EgKC1Slmbq3wf11yUdYzv5Md4xESUDh5OMG /YKOyH1StPRLTX/M0YZNXykFFkyEuGp2b28n4a9u6jRs+R9D2s96dR2cw2UzJvl5WTIt eFa3aA4wIzDyTCJ5Hpmybl7LX0qVPGf8v6jfJWyABp0JFeZqUyrLYDYVU63tnM7xwCEQ 0r0ENdhZEe1K/AIKPRtEuKrd9i9m6PZyH2prFUltcs+IdDm8qPyq3CgBIEdAe7dGPnRE R2aA== X-Forwarded-Encrypted: i=1; AJvYcCUOiVBsFPSL/fCPzvp9Av+Si66dg8cL4sCCsfxrTq6HelnQ1A4Ik2EaGXo7NgBbug/P0oqDjMi/RSWJZngIEoKztl0jViMa6DE1QAI6JyY1/Jn3fzDepAl5UDfpno20A/Lgqkn/5Tc7NBh0K/xC+EjCDMU1 X-Gm-Message-State: AOJu0YzttVGJh5my70ybQ66WG54aAt2hv03JE3ubfq8HYZbYLO3IZjko Ntq+fKygWEXmaDDYYlwAxiNODGFRoaXZAfvOjvpOqlH3xAWBbolnHSrB99A8UGcDHw== X-Google-Smtp-Source: AGHT+IHuuhHhHTN8Vk2oFh7RQ5imuAXNENsjhoN5lsG/+ejPKPrgj43OHqKRbOUo9podhvM5NqfWTQ== X-Received: by 2002:a17:90b:4c8a:b0:2a0:53cf:9bae with SMTP id my10-20020a17090b4c8a00b002a053cf9baemr2142394pjb.32.1711625617852; Thu, 28 Mar 2024 04:33:37 -0700 (PDT) Received: from [192.168.29.219] ([49.37.251.254]) by smtp.gmail.com with ESMTPSA id m5-20020a17090b068500b0029fbfb620cdsm1173744pjz.28.2024.03.28.04.33.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Mar 2024 04:33:37 -0700 (PDT) Message-ID: <582c276c-ea2f-456c-9bf9-47e39289a0b6@gmail.com> Date: Thu, 28 Mar 2024 17:03:30 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] dt-bindings: aspeed: Add eSPI controller To: Krzysztof Kozlowski , patrick.rudolph@9elements.com, chiawei_wang@aspeedtech.com, ryan_chen@aspeedtech.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, jk@codeconstruct.com.au, openbmc@lists.ozlabs.org, broonie@kernel.org, linux-spi@vger.kernel.org References: <20240319093405.39833-1-manojkiran.eda@gmail.com> <20240319093405.39833-5-manojkiran.eda@gmail.com> Content-Language: en-US From: Manojkiran Eda In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240328_043341_675367_C0A09FC0 X-CRM114-Status: GOOD ( 34.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAyMC8wMy8yNCA4OjE0IHBtLCBLcnp5c3p0b2YgS296bG93c2tpIHdyb3RlOgo+IE9uIDIw LzAzLzIwMjQgMTA6NTksIE1hbm9qa2lyYW4gRWRhIHdyb3RlOgo+Pgo+PiBPbiAxOS8wMy8yNCAz OjI2IHBtLCBLcnp5c3p0b2YgS296bG93c2tpIHdyb3RlOgo+Pj4gT24gMTkvMDMvMjAyNCAxMDoz NCwgTWFub2praXJhbiBFZGEgd3JvdGU6Cj4+Pj4gVGhpcyBjb21taXQgYWRkcyB0aGUgZGV2aWNl IHRyZWUgYmluZGluZ3MgZm9yIGFzcGVlZCBlU1BJCj4+Pj4gY29udHJvbGxlci4KPj4+Pgo+Pj4+ IEFsdGhvdWdoIGFzcGVlZCBlU1BJIGhhcmR3YXJlIHN1cHBvcnRzIDQgZGlmZmVyZW50IGNoYW5u ZWxzLAo+Pj4+IHRoaXMgY29tbWl0IG9ubHkgYWRkcyB0aGUgc3VwcG9ydCBmb3IgZmxhc2ggY2hh bm5lbCwgdGhlCj4+Pj4gYmluZGluZ3MgZm9yIG90aGVyIGNoYW5uZWxzIGNvdWxkIGJlIHVwc3Ry ZWFtZWQgd2hlbiB0aGUgZHJpdmVyCj4+Pj4gc3VwcG9ydCBmb3IgdGhvc2UgYXJlIGFkZGVkLgo+ Pj4+Cj4+Pj4gU2lnbmVkLW9mZi1ieTogTWFub2praXJhbiBFZGE8bWFub2praXJhbi5lZGFAZ21h aWwuY29tPgo+Pj4+IC0tLQo+Pj4+ICAgIC4uLi9iaW5kaW5ncy9zb2MvYXNwZWVkL2FzcGVlZCxl c3BpLnlhbWwgICAgICB8IDk0ICsrKysrKysrKysrKysrKysrKysKPj4+PiAgICAxIGZpbGUgY2hh bmdlZCwgOTQgaW5zZXJ0aW9ucygrKQo+Pj4+ICAgIGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvc29jL2FzcGVlZC9hc3BlZWQsZXNwaS55YW1sCj4+ Pj4KPj4+PiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3Nv Yy9hc3BlZWQvYXNwZWVkLGVzcGkueWFtbCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5k aW5ncy9zb2MvYXNwZWVkL2FzcGVlZCxlc3BpLnlhbWwKPj4+PiBuZXcgZmlsZSBtb2RlIDEwMDY0 NAo+Pj4+IGluZGV4IDAwMDAwMDAwMDAwMC4uM2QzYWQ1MjhlM2IzCj4+Pj4gLS0tIC9kZXYvbnVs bAo+Pj4+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9zb2MvYXNwZWVk L2FzcGVlZCxlc3BpLnlhbWwKPj4+IFdoeSBSb2IncyBjb21tZW50cyBnb3QgaWdub3JlZD8KPj4+ Cj4+PiBUaGlzIGlzIG5vdCBhIHNvYyBjb21wb25lbnQuCj4+IEkgZGlkIG5vdCBtZWFuIHRvIGln bm9yZSwgaSBoYXZlIGZldyByZWFzb25zIGxpc3RlZCBiZWxvdyB0aGF0IHByb3ZpZGVzCj4+IGlu Zm9ybWF0aW9uIG9uIHdoeSBpIGZlbHQgdGhpcyBiZWxvbmdzIGludG8gc29jLgo+IAo+IHNvYyBp cyBkdW1waW5nIGdyb3VuZCBvZiB0aGluZ3Mgd2hpY2ggYXJlIHB1cmVseSBTb0Mgc3BlY2lmaWMs IG5vdAo+IGNvdmVyZWQgYnkgZXhpc3RpbmcgaGFyZHdhcmUgc3RydWN0dXJlIGluIGJpbmRpbmdz LiBNYXliZSBpbmRlZWQgdGhpcwo+IGRvZXMgbm90IGhhdmUgYW55IG90aGVyIHBsYWNlLCBidXQg ZGlkIHlvdSBhY3R1YWxseSBsb29rPwo+IAoKWWVzLCBpIGRpZCBsb29rIGF0IGV4aXN0aW5nIGhh cmR3YXJlIGJpbmRpbmdzLCBhbmQgY2Fubm90IHNlZW0gdG8gZmluZCAKb3V0IGFueSBvdGhlciBz dWl0YWJsZSBwbGFjZS4gSSBjYW4gZGVmaW5pdGVseSBsb29rIGFnYWluLgoKPiBBbnl3YXksIHBs ZWFzZSBDQyBTUEkgbWFpbnRhaW5lcnMgb24gZnV0dXJlIHN1Ym1pc3Npb24uCgpTdXJlLCB3aWxs IGFkZCB0aGVtLgoKPiAKPj4+Cj4+Pj4gQEAgLTAsMCArMSw5NCBAQAo+Pj4+ICsjIFNQRFgtTGlj ZW5zZS1JZGVudGlmaWVyOiAoR1BMLTIuMC1vbmx5IE9SIEJTRC0yLUNsYXVzZSkKPj4+PiArIyAj IENvcHlyaWdodCAoYykgMjAyNCBJQk0gQ29ycG9yYXRpb24uCj4+Pj4gKyMgIyBDb3B5cmlnaHQg KGMpIDIwMjEgQXNwZWVkIFRlY2hub2xvZ3kgSW5jLgo+Pj4+ICslWUFNTCAxLjIKPj4+PiArLS0t Cj4+Pj4gKyRpZDpodHRwOi8vZGV2aWNldHJlZS5vcmcvc2NoZW1hcy9zb2MvYXNwZWVkL2FzcGVl ZCxlc3BpLnlhbWwjCj4+Pj4gKyRzY2hlbWE6aHR0cDovL2RldmljZXRyZWUub3JnL21ldGEtc2No ZW1hcy9jb3JlLnlhbWwjCj4+Pj4gKwo+Pj4+ICt0aXRsZTogQXNwZWVkIGVTUEkgQ29udHJvbGxl cgo+Pj4+ICsKPj4+PiArbWFpbnRhaW5lcnM6Cj4+Pj4gKyAgLSBNYW5vamtpcmFuIEVkYTxtYW5v amtpcmFuLmVkYUBnbWFpbC5jb20+Cj4+Pj4gKyAgLSBQYXRyaWNrIFJ1ZG9scGg8cGF0cmljay5y dWRvbHBoQDllbGVtZW50cy5jb20+Cj4+Pj4gKyAgLSBDaGlhLVdlaSBXYW5nPGNoaWF3ZWlfd2Fu Z0Bhc3BlZWR0ZWNoLmNvbT4KPj4+PiArICAtIFJ5YW4gQ2hlbjxyeWFuX2NoZW5AYXNwZWVkdGVj aC5jb20+Cj4+Pj4gKwo+Pj4+ICtkZXNjcmlwdGlvbjoKPj4+PiArICBBc3BlZWQgZVNQSSBjb250 cm9sbGVyIGltcGxlbWVudHMgYSBkZXZpY2Ugc2lkZSBlU1BJIGVuZHBvaW50IGRldmljZQo+Pj4+ ICsgIHN1cHBvcnRpbmcgdGhlIGZsYXNoIGNoYW5uZWwuCj4+PiBFeHBsYWluIHdoYXQgaXMgZVNQ SS4KPj4gZVNQSSBpcyBhIHNlcmlhbCBidXMgaW50ZXJmYWNlIGZvciBjbGllbnQgYW5kIHNlcnZl ciBwbGF0Zm9ybXMgdGhhdCBpcwo+IAo+IEV4cGxhaW4gaW4gZGVzY3JpcHRpb24gb2YgdGhlIGhh cmR3YXJlLgoKU3VyZSwgaSB3aWxsIGFkZCB0aGlzIGRlc2NyaXB0aW9uIGluIHRoZSBiaW5kaW5n IGRvY3VtZW50IGluIHRoZSBmdXR1cmUgCnN1Ym1pc3Npb24uCj4gCj4+IGJhc2VkIG9uIFNQSSzC oCB1c2luZyB0aGUgc2FtZSBtYXN0ZXIgYW5kIHNsYXZlIHRvcG9sb2d5IGJ1dCBvcGVyYXRlcwo+ PiB3aXRoIGEgZGlmZmVyZW50IHByb3RvY29sIHRvIG1lZXQgbmV3IHJlcXVpcmVtZW50cy4gRm9y IGluc3RhbmNlLCBlU1BJCj4+IHVzZXMgSS9PLCBvciBpbnB1dC9vdXRwdXQsIGNvbW11bmljYXRp b24sIGluc3RlYWQgb2YgTU9TSS9NSVNPIHVzZWQgaW4KPj4gU1BJLiBJdCBhbHNvIGluY2x1ZGVz IGEgdHJhbnNhY3Rpb24gbGF5ZXIgb24gdG9wIG9mIHRoZSBTUEkgcHJvdG9jb2wsCj4+IGRlZmlu aW5nIHBhY2tldHMgc3VjaCBhcyBjb21tYW5kIGFuZCByZXNwb25zZSBwYWNrZXRzIHRoYXQgYWxs b3cgYm90aAo+PiB0aGUgbWFzdGVyIGFuZCBzbGF2ZSB0byBpbml0aWF0ZSBhbGVydCBhbmQgcmVz ZXQgc2lnbmFscy4gZVNQSSBzdXBwb3J0cwo+PiBjb21tdW5pY2F0aW9uIGJldHdlZW4gRW1iZWRk ZWQgQ29udHJvbGxlciAoRUMpLCBCYXNlYm9hcmQgTWFuYWdlbWVudAo+PiBDb250cm9sbGVyIChC TUMpLCBTdXBlci1JL08gKFNJTykgYW5kIFBvcnQtODAgZGVidWcgY2FyZHMuIEkgY291bGQgYWRk Cj4+IHRoaXMgdG8gdGhlIGNvbW1pdCBtZXNzYWdlIGFzIHdlbGwgaW4gdGhlIG5leHQgcGF0Y2hz ZXQuCj4+Pgo+Pj4+ICsKPj4+PiArcHJvcGVydGllczoKPj4+PiArICBjb21wYXRpYmxlOgo+Pj4+ ICsgICAgaXRlbXM6Cj4+Pj4gKyAgICAgIC0gZW51bToKPj4+PiArICAgICAgICAgIC0gYXNwZWVk LGFzdDI1MDAtZXNwaQo+Pj4+ICsgICAgICAgICAgLSBhc3BlZWQsYXN0MjYwMC1lc3BpCj4+Pj4g KyAgICAgIC0gY29uc3Q6IHNpbXBsZS1tZmQKPj4+Cj4+PiBUaGF0J3Mgbm90IHNpbXBsZS1tZmQu IFlvdSBoYXZlIGRyaXZlciBmb3IgdGhpcy4gRHJvcC4KPj4+Cj4+Pj4gKyAgICAgIC0gY29uc3Q6 IHN5c2Nvbgo+Pj4gVGhhdCdzIG5vdCBzeXNjb24uIFdoeSBkbyB5b3UgaGF2ZSByYW5nZXMgdGhl bj8gV2hlcmUgaXMgYW55IGV4cGxhbmF0aW9uCj4+PiBvZiBoYXJkd2FyZSB3aGljaCB3b3VsZCBq dXN0aWZ5IHN1Y2ggY29tYmluYXRpb24/Cj4+Pgo+Pj4+ICsKPj4+PiArICByZWc6Cj4+Pj4gKyAg ICBtYXhJdGVtczogMQo+Pj4+ICsKPj4+PiArICAiI2FkZHJlc3MtY2VsbHMiOgo+Pj4+ICsgICAg Y29uc3Q6IDEKPj4+PiArCj4+Pj4gKyAgIiNzaXplLWNlbGxzIjoKPj4+PiArICAgIGNvbnN0OiAx Cj4+Pj4gKwo+Pj4+ICsgIHJhbmdlczogdHJ1ZQo+Pj4+ICsKPj4+PiArcGF0dGVyblByb3BlcnRp ZXM6Cj4+Pj4gKyAgIl5lc3BpLWN0cmxAWzAtOWEtZl0rJCI6Cj4+Pj4gKyAgICB0eXBlOiBvYmpl Y3QKPj4+PiArCj4+Pj4gKyAgICBkZXNjcmlwdGlvbjogQ29udHJvbHMgdGhlIGZsYXNoIGNoYW5u ZWwgb2YgZVNQSSBoYXJkd2FyZQo+Pj4gVGhhdCBleHBsYWlucyBub3RoaW5nLiBVbmxlc3MgeW91 IHdhbnRlZCB0byB1c2UgaGVyZSBNVEQgYmluZGluZ3MuCj4+Pgo+Pj4gVGhpcyBiaW5kaW5nIGRp ZCBub3QgaW1wcm92ZSBtdWNoLiBJIGRvbid0IHVuZGVyc3RhbmQgd2h5IHRoaXMgaXMgbm90Cj4+ PiBTUEkgKG5vdGhpbmcgaW4gY29tbWl0IG1zZywgbm90aGluZyBpbiBkZXNjcmlwdGlvbiksIHdo YXQgaXMgZVNQSSwKPj4KPj4gZVNQSSB1c2VzIFBlcmlwaGVyYWwsIFZpcnR1YWwgV2lyZSwgT3V0 IG9mIEJhbmQsIGFuZCBGbGFzaCBBY2Nlc3MKPj4gY2hhbm5lbHMgdG8gY29tbXVuaWNhdGUgZGlm ZmVyZW50IHNldHMgb2YgZGF0YS4KPiAKPiBBbmQgd2hhdCBhcmUgdGhlc2UgY2hhbm5lbHM/IFdo YXQgZG9lcyBpdCBtZWFuIGEgImNoYW5uZWwiPyBJcyBpdCBqdXN0Cj4gaG93IHlvdSBvcmdhbml6 ZSB0cmFuc2ZlcnMgYW5kIGNsYXNzZXMgb2YgZGV2aWNlcz8gT3Igc29tZSBzb3J0IG9mCj4gYWRk cmVzc2FibGUgaW5zdGFuY2Ugb24gdGhlIGJ1cz8KPiAKClllcywgYW4gZXNwaSBjaGFubmVsIHBy b3ZpZGVzIGEgbWVhbnMgdG8gYWxsb3cgbXVsdGlwbGUgaW5kZXBlbmRlbnQgCmZsb3dzIG9mIHRy YWZmaWMgdG8gc2hhcmUgdGhlIHNhbWUgcGh5c2ljYWwgYnVzLiBFYWNoIG9mIHRoZSBjaGFubmVs cyAKaGFzIGl0cyBvd24gZGVkaWNhdGVkIHJlc291cmNlcyBzdWNoIGFzIHF1ZXVlIGFuZCBmbG93 IGNvbnRyb2wuCgo+IFRoZSBjaGFubmVscyBmZWVsIGxpa2Ugc29tZSBzb3J0IG9mIHNvZnR3YXJl IG9yIGxvZ2ljYWwgY29uY2VwdCwgbm90Cj4gcGh5c2ljYWwuIFBoeXNpY2FsIHdvdWxkIGJlIGVu ZHBvaW50IHdpdGggcGVyaXBoZXJhbC4gT3IgZmxhc2ggbWVtb3J5LgoKQSBjaGFubmVsIGlzIGEg bG9naWNhbCBjb21tdW5pY2F0aW9uIHBhdGh3YXkgb3IgaW50ZXJmYWNlIGJldHdlZW4gdGhlIApj aGlwc2V0IGFuZCBwZXJpcGhlcmFsIGRldmljZXMuIFRoZSBjb25jZXB0IG9mIGNoYW5uZWxzIGlu IHRoZSBFU1BJIApwcm90b2NvbCBoZWxwcyBvcmdhbml6ZSBhbmQgbWFuYWdlIGRpZmZlcmVudCB0 eXBlcyBvZiBjb21tdW5pY2F0aW9uIApiZXR3ZWVuIHRoZSBjaGlwc2V0IGFuZCBwZXJpcGhlcmFs cy4gRWFjaCBjaGFubmVsIG1heSBoYXZlIGl0cyBvd24gc2V0IApvZiBwcm90b2NvbHMsIGRhdGEg dHJhbnNmZXIgcmF0ZXMsIGFuZCBzdXBwb3J0ZWQgZmVhdHVyZXMsIHRhaWxvcmVkIHRvIAp0aGUg cmVxdWlyZW1lbnRzIG9mIHRoZSBkZXZpY2VzIGl0IHNlcnZlcy4KCj4gSG93IGRvIHRoZXkgZml0 IGhlcmU/CgpJIGFtIG5vdCBzdXJlIEkgdW5kZXJzdGFuZCwgY2FuIHlvdSBwbGVhc2UgZWxhYm9y YXRlID8KCj4+Cj4+ICAgICogVGhlICpQZXJpcGhlcmFsKiBDaGFubmVsIGlzIHVzZWQgZm9yIGNv bW11bmljYXRpb24gYmV0d2VlbiBlU1BJIGhvc3QKPj4gICAgICBicmlkZ2UgbG9jYXRlZCBvbiB0 aGUgbWFzdGVyIHNpZGUgYW5kIGVTUEkgZW5kcG9pbnRzIGxvY2F0ZWQgb24gdGhlCj4+ICAgICAg c2xhdmUgc2lkZS4gTFBDIEhvc3QgYW5kIExQQyBQZXJpcGhlcmFscyBhcmUgYW4gZXhhbXBsZSBv ZiBlU1BJIGhvc3QKPj4gICAgICBicmlkZ2UgYW5kIGVTUEkgZW5kcG9pbnRzIHJlc3BlY3RpdmVs eS4KPj4gICAgKiAqVmlydHVhbCBXaXJlKiBDaGFubmVsOiBUaGUgVmlydHVhbCBXaXJlIGNoYW5u ZWwgaXMgdXNlZCB0bwo+PiAgICAgIGNvbW11bmljYXRlIHRoZSBzdGF0ZSBvZiBzaWRlYmFuZCBw aW5zIG9yIEdQSU8gdHVubmVsZWQgdGhyb3VnaCBlU1BJCj4+ICAgICAgYXMgaW4tYmFuZCBtZXNz YWdlcy4gU2VyaWFsIElSUSBpbnRlcnJ1cHRzIGFyZSBjb21tdW5pY2F0ZWQgdGhyb3VnaAo+PiAg ICAgIHRoaXMgY2hhbm5lbCBhcyBpbi1iYW5kIG1lc3NhZ2VzLgo+PiAgICAqICpPT0IqIENoYW5u ZWw6IFRoZSBTTUJ1cyBwYWNrZXRzIGFyZSB0dW5uZWxlZCB0aHJvdWdoIGVTUEkgYXMKPj4gICAg ICBPdXQtT2YtQmFuZCAoT09CKSBtZXNzYWdlcy4gVGhlIHdob2xlIFNNQnVzIHBhY2tldCBpcyBl bWJlZGRlZAo+PiAgICAgIGluc2lkZSB0aGUgZVNQSSBPT0IgbWVzc2FnZSBhcyBkYXRhLgo+PiAg ICAqICpGbGFzaCBBY2Nlc3MqIENoYW5uZWw6IFRoZSBGbGFzaCBBY2Nlc3MgY2hhbm5lbCBwcm92 aWRlcyBhIHBhdGgKPj4gICAgICBhbGxvd2luZyB0aGUgZmxhc2ggY29tcG9uZW50cyB0byBiZSBz aGFyZWQgcnVuLXRpbWUgYmV0d2VlbiBjaGlwc2V0Cj4+ICAgICAgYW5kIHRoZSBlU1BJIHNsYXZl cyB0aGF0IHJlcXVpcmUgZmxhc2ggYWNjZXNzZXMgc3VjaCBhcyBFQyAoRW1iZWRkZWQKPj4gICAg ICBDb250cm9sbGVyKSBhbmQgQk1DLgo+IAo+IFBsZWFzZSBtYWtlIGJpbmRpbmcgY29tcGxldGUs IHNvIGRlZmluZSBhbGwgb2YgdGhlIGNoYW5uZWxzLgoKCkkgd291bGQgbGlrZSB0byBpbnF1aXJl IGFib3V0IHRoZSByYXRpb25hbGUgYmVoaW5kIHRoaXMgcmVxdWVzdC4gQmFzZWQgCm9uIHByZXZp b3VzIGZlZWRiYWNrIHJlY2VpdmVkIGZyb20gdGhlIHVwc3RyZWFtIGVmZm9ydHMgCltodHRwczov L2xvcmUua2VybmVsLm9yZy9vcGVuYm1jL0hLMFBSMDZNQjM3Nzk4NDYyRDE3NDQzQzY5NzQzM0Q3 MTkxRDA5QEhLMFBSMDZNQjM3NzkuYXBjcHJkMDYucHJvZC5vdXRsb29rLmNvbS9dLCAKc3VnZ2Vz dGlvbnMgd2VyZSBtYWRlIHRvIG1vZGVsIHRoZSBmbGFzaCBjaGFubmVsIGJ5IHV0aWxpemluZyB0 aGUgbXRkIApzdWJzeXN0ZW0sIHRoZSB2aXJ0dWFsIHdpcmUgY2hhbm5lbCBieSB1dGlsaXppbmcg dGhlIEdQSU8gc3Vic3lzdGVtLCBhbmQgCnRvIGNvbnNpZGVyIHRoZSBPT0IgY2hhbm5lbCBhcyBh IHR5cGUgb2YgaTJjIGRldmljZSwgdGhlcmVieSBhbGxvd2luZyBpdCAKdG8gYmUgdXRpbGl6ZWQg YnkgdGhlIGV4aXN0aW5nIGluLWtlcm5lbCBNQ1RQIHN1YnN5c3RlbSwgYW1vbmcgb3RoZXJzLiAK TXkgaW50ZW50aW9uIHdhcyB0byBwcmlvcml0aXplIHVwc3RyZWFtaW5nIHRoZSBmbGFzaCBjaGFu bmVsIGJpbmRpbmcsIAphbG9uZyB3aXRoIGl0cyBkcml2ZXIgY29kZSwgYmVmb3JlIHByb2NlZWRp bmcgdG8gYWRkcmVzcyBvdGhlciBjaGFubmVscy4gCkkgYW0gY3VyaW91cyB0byB1bmRlcnN0YW5k IGlmIGl0IGlzIGEgc3RyaWN0IHJlcXVpcmVtZW50IHRvIGhhdmUgdGhlIApjb21wbGV0ZSBiaW5k aW5nIHVwc3RyZWFtZWQgYmVmb3JlIGFkZHJlc3NpbmcgdGhlIGRldmljZSBkcml2ZXJzIGNvZGUu Cgo+IAo+Pgo+PiBBbHRob3VnaCAsIGVTUEkgcmV1c2VzIHRoZSB0aW1pbmcgYW5kIGVsZWN0cmlj YWwgc3BlY2lmaWNhdGlvbiBvZiBTZXJpYWwKPj4gUGVyaXBoZXJhbCBJbnRlcmZhY2UgKFNQSSkg YnV0IGl0IHJ1bnMgYW4gZW50aXJlbHkgZGlmZmVyZW50IHByb3RvY29sIHRvCj4+IG1lZXQgYSBz ZXQgb2YgZGlmZmVyZW50IHJlcXVpcmVtZW50cy4gV2hpY2ggaXMgd2h5IGkgZmVsdCBwcm9iYWJs eQo+PiBwbGFjaW5nIHRoaXMgaW4gc29jIHdhcyBhIGJldHRlciBjaG9pY2UgcmF0aGVyIHRoYW4g c3BpLiBEbyB5b3UgdGhpbmsKPj4gb3RoZXJ3aXNlID8KPiAKPiBzb2MgaXMgZHVtcGluZyBncm91 bmQgZm9yIHRoaW5ncyBkbyBub3QgZml0IG90aGVyIHBsYWNlcy4gQXJlIHRoZXJlIGFueQo+IG90 aGVyIGJ1c2VzIC8gSVAgYmxvY2tzIHNpbWlsYXIgdG8gdGhpcyBvbmU/Cj4gCj4gCj4gQmVzdCBy ZWdhcmRzLAo+IEtyenlzenRvZgo+IAoKVGhhbmtzLApNYW5vagoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=