From: Oliver Neukum <oneukum@suse.de>
To: Yann Cantin <yann.cantin@laposte.net>
Cc: linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
gregkh@linuxfoundation.org, dmitry.torokhov@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC ebeam PATCH v4 2/2] input: misc: New USB eBeam input driver.
Date: Thu, 23 Aug 2012 08:54:55 +0200 [thread overview]
Message-ID: <5832321.EK5PCgIIzt@linux-lqwf.site> (raw)
In-Reply-To: <1345673514-11575-3-git-send-email-yann.cantin@laposte.net>
On Thursday 23 August 2012 00:11:54 Yann Cantin wrote:
> + /* input final setup */
> + err = input_register_device(ebeam->input);
> + if (err) {
> + dev_dbg(&intf->dev,
> + "%s - input_register_device failed, err: %d\n",
> + __func__, err);
> + goto out_free_urb;
> + }
> +
> + ebeam_setup_input(ebeam, input_dev);
> +
> + /* usb final setup */
> + usb_set_intfdata(intf, ebeam);
Hi,
this looks like a classic race. You initialize the device after you
register it. However, it may be used at that time.
Regards
Oliver
next prev parent reply other threads:[~2012-08-23 6:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 22:11 [RFC ebeam PATCH v4 0/2] new USB eBeam input driver Yann Cantin
2012-08-22 22:11 ` [RFC ebeam PATCH v4 1/2] hid: Blacklist eBeam devices Yann Cantin
2012-08-22 22:11 ` [RFC ebeam PATCH v4 2/2] input: misc: New USB eBeam input driver Yann Cantin
2012-08-23 6:54 ` Oliver Neukum [this message]
2012-08-24 9:31 ` Yann Cantin
2012-08-24 9:31 ` Yann Cantin
2012-08-23 7:23 ` Oliver Neukum
2012-08-24 9:37 ` Yann Cantin
2012-08-24 11:41 ` Oliver Neukum
[not found] ` <1555763.Oi7gGGn7BU-ugxBuEnWX9yG/4A2pS7c2Q@public.gmane.org>
2012-08-24 14:42 ` Yann Cantin
2012-08-24 14:42 ` Yann Cantin
2012-09-03 12:59 ` Oliver Neukum
2012-09-03 12:59 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5832321.EK5PCgIIzt@linux-lqwf.site \
--to=oneukum@suse.de \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=yann.cantin@laposte.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.