All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: 4ncienth@gmail.com, edumazet@google.com, kuba@kernel.org
Cc: netdev@vger.kernel.org, dsahern@kernel.org, idosch@nvidia.com,
	davem@davemloft.net, horms@kernel.org,
	willemdebruijn.kernel@gmail.com, vyasevic@redhat.com,
	linux-kernel@vger.kernel.org, netdev-bot+sashiko@kernel.org
Subject: Re: [net,v3] udp: revalidate socket family before publishing an IPv6 cork
Date: Thu, 3 Sep 2026 15:22:57 +0200	[thread overview]
Message-ID: <5832ba17-c096-4f07-aa73-2e2bb6f79856@redhat.com> (raw)
In-Reply-To: <178844070069.3394541.5419916956797677793@kernel.org>

On 9/3/26 3:05 PM, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider:
> 
> Critical: 0 · High: 2 · Medium: 0 · Low: 0
> 
> - [High] Incomplete fix: the sibling IPv6 socket-dst publisher in the
>   connect() path is not covered, so an IPv6 dst can still be installed…
> - [High] The fix is writer-side and after-the-fact, so the mixed-family
>   socket dst it claims to eliminate remains observable by the unguarded…

It looks like fixing this kind of issues, if possible at all, would
require adding a significant complexity to the data-path.

I'm wondering if we could just remove setsockopt(IPV6_ADDRFORM) support?

/P


  reply	other threads:[~2026-09-03 13:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02  1:04 [PATCH net v3] udp: revalidate socket family before publishing an IPv6 cork Daehyeon Ko
2026-09-03 13:05 ` [net,v3] " netdev-bot+sashiko
2026-09-03 13:22   ` Paolo Abeni [this message]
2026-09-03 21:55     ` Kuniyuki Iwashima

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5832ba17-c096-4f07-aa73-2e2bb6f79856@redhat.com \
    --to=pabeni@redhat.com \
    --cc=4ncienth@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vyasevic@redhat.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.