From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:37986 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751423AbeCUIvN (ORCPT ); Wed, 21 Mar 2018 04:51:13 -0400 From: Laurent Pinchart To: Daniel Vetter Cc: Ulrich Hecht , linux-renesas-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH igt 2/8] tests/kms_panel_fitting: check for i915 before checking version Date: Wed, 21 Mar 2018 10:52:19 +0200 Message-ID: <5833508.5Jkp4rVBdS@avalon> In-Reply-To: <20180321083433.GB14155@phenom.ffwll.local> References: <1521125144-28614-1-git-send-email-ulrich.hecht+renesas@gmail.com> <4326028.gVfV6JXNhJ@avalon> <20180321083433.GB14155@phenom.ffwll.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Daniel, On Wednesday, 21 March 2018 10:34:33 EET Daniel Vetter wrote: > On Tue, Mar 20, 2018 at 01:24:09PM +0200, Laurent Pinchart wrote: > > Hi Ulrich, > > > > Thank you for the patch. > > > > On Thursday, 15 March 2018 16:45:38 EET Ulrich Hecht wrote: > > > Fixes false negatives on non-i915 platforms. > > > > > > Signed-off-by: Ulrich Hecht > > > --- > > > > > > tests/kms_panel_fitting.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c > > > index b3cee22..6d0be50 100644 > > > --- a/tests/kms_panel_fitting.c > > > +++ b/tests/kms_panel_fitting.c > > > @@ -243,6 +243,7 @@ static void test_atomic_fastset(igt_display_t > > > *display) > > > > > > igt_set_module_param_int("fastboot", 1); > > > > > > igt_require(display->is_atomic); > > > > > > + igt_require(is_i915_device(display->drm_fd)); > > > > > > igt_require(intel_gen(intel_get_drm_devid(display->drm_fd)) >= 5); > > > > I'm fine with this patch as a quick fix, but what in this test is Intel- > > specific ? Can't we replace the Intel generation check with a different > > feature check ? > > There's some checks in there that we can do certain panel fitter mode > changes without a modeset (throught ALLOW_MODESET for atomic commits). > That's 100% encoding intel hw constraints: Our hw can disable the panel > fitter without a modest (so going from upscaled -> native resolution), but > not any of the other changes (native -> upscaled or 2 different upscaled > versions). OK, thank you for the information. Would it make sense to rename the Intel-specific test files to start with i915 (or any other Intel prefix) to make this clear ? > > > for_each_pipe_with_valid_output(display, pipe, output) { -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH igt 2/8] tests/kms_panel_fitting: check for i915 before checking version Date: Wed, 21 Mar 2018 10:52:19 +0200 Message-ID: <5833508.5Jkp4rVBdS@avalon> References: <1521125144-28614-1-git-send-email-ulrich.hecht+renesas@gmail.com> <4326028.gVfV6JXNhJ@avalon> <20180321083433.GB14155@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 909186E472 for ; Wed, 21 Mar 2018 08:51:14 +0000 (UTC) In-Reply-To: <20180321083433.GB14155@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Ulrich Hecht , linux-renesas-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org SGkgRGFuaWVsLAoKT24gV2VkbmVzZGF5LCAyMSBNYXJjaCAyMDE4IDEwOjM0OjMzIEVFVCBEYW5p ZWwgVmV0dGVyIHdyb3RlOgo+IE9uIFR1ZSwgTWFyIDIwLCAyMDE4IGF0IDAxOjI0OjA5UE0gKzAy MDAsIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPiBIaSBVbHJpY2gsCj4gPiAKPiA+IFRoYW5r IHlvdSBmb3IgdGhlIHBhdGNoLgo+ID4gCj4gPiBPbiBUaHVyc2RheSwgMTUgTWFyY2ggMjAxOCAx Njo0NTozOCBFRVQgVWxyaWNoIEhlY2h0IHdyb3RlOgo+ID4gPiBGaXhlcyBmYWxzZSBuZWdhdGl2 ZXMgb24gbm9uLWk5MTUgcGxhdGZvcm1zLgo+ID4gPiAKPiA+ID4gU2lnbmVkLW9mZi1ieTogVWxy aWNoIEhlY2h0IDx1bHJpY2guaGVjaHQrcmVuZXNhc0BnbWFpbC5jb20+Cj4gPiA+IC0tLQo+ID4g PiAKPiA+ID4gIHRlc3RzL2ttc19wYW5lbF9maXR0aW5nLmMgfCAxICsKPiA+ID4gIDEgZmlsZSBj aGFuZ2VkLCAxIGluc2VydGlvbigrKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL3Rlc3RzL2tt c19wYW5lbF9maXR0aW5nLmMgYi90ZXN0cy9rbXNfcGFuZWxfZml0dGluZy5jCj4gPiA+IGluZGV4 IGIzY2VlMjIuLjZkMGJlNTAgMTAwNjQ0Cj4gPiA+IC0tLSBhL3Rlc3RzL2ttc19wYW5lbF9maXR0 aW5nLmMKPiA+ID4gKysrIGIvdGVzdHMva21zX3BhbmVsX2ZpdHRpbmcuYwo+ID4gPiBAQCAtMjQz LDYgKzI0Myw3IEBAIHN0YXRpYyB2b2lkIHRlc3RfYXRvbWljX2Zhc3RzZXQoaWd0X2Rpc3BsYXlf dAo+ID4gPiAqZGlzcGxheSkKPiA+ID4gCj4gPiA+ICAJCWlndF9zZXRfbW9kdWxlX3BhcmFtX2lu dCgiZmFzdGJvb3QiLCAxKTsKPiA+ID4gIAkKPiA+ID4gIAlpZ3RfcmVxdWlyZShkaXNwbGF5LT5p c19hdG9taWMpOwo+ID4gPiAKPiA+ID4gKwlpZ3RfcmVxdWlyZShpc19pOTE1X2RldmljZShkaXNw bGF5LT5kcm1fZmQpKTsKPiA+ID4gCj4gPiA+ICAJaWd0X3JlcXVpcmUoaW50ZWxfZ2VuKGludGVs X2dldF9kcm1fZGV2aWQoZGlzcGxheS0+ZHJtX2ZkKSkgPj0gNSk7Cj4gPiAKPiA+IEknbSBmaW5l IHdpdGggdGhpcyBwYXRjaCBhcyBhIHF1aWNrIGZpeCwgYnV0IHdoYXQgaW4gdGhpcyB0ZXN0IGlz IEludGVsLQo+ID4gc3BlY2lmaWMgPyBDYW4ndCB3ZSByZXBsYWNlIHRoZSBJbnRlbCBnZW5lcmF0 aW9uIGNoZWNrIHdpdGggYSBkaWZmZXJlbnQKPiA+IGZlYXR1cmUgY2hlY2sgPwo+IAo+IFRoZXJl J3Mgc29tZSBjaGVja3MgaW4gdGhlcmUgdGhhdCB3ZSBjYW4gZG8gY2VydGFpbiBwYW5lbCBmaXR0 ZXIgbW9kZQo+IGNoYW5nZXMgd2l0aG91dCBhIG1vZGVzZXQgKHRocm91Z2h0IEFMTE9XX01PREVT RVQgZm9yIGF0b21pYyBjb21taXRzKS4KPiBUaGF0J3MgMTAwJSBlbmNvZGluZyBpbnRlbCBodyBj b25zdHJhaW50czogT3VyIGh3IGNhbiBkaXNhYmxlIHRoZSBwYW5lbAo+IGZpdHRlciB3aXRob3V0 IGEgbW9kZXN0IChzbyBnb2luZyBmcm9tIHVwc2NhbGVkIC0+IG5hdGl2ZSByZXNvbHV0aW9uKSwg YnV0Cj4gbm90IGFueSBvZiB0aGUgb3RoZXIgY2hhbmdlcyAobmF0aXZlIC0+IHVwc2NhbGVkIG9y IDIgZGlmZmVyZW50IHVwc2NhbGVkCj4gdmVyc2lvbnMpLgoKT0ssIHRoYW5rIHlvdSBmb3IgdGhl IGluZm9ybWF0aW9uLgoKV291bGQgaXQgbWFrZSBzZW5zZSB0byByZW5hbWUgdGhlIEludGVsLXNw ZWNpZmljIHRlc3QgZmlsZXMgdG8gc3RhcnQgd2l0aCBpOTE1IAoob3IgYW55IG90aGVyIEludGVs IHByZWZpeCkgdG8gbWFrZSB0aGlzIGNsZWFyID8KCj4gPiA+ICAJZm9yX2VhY2hfcGlwZV93aXRo X3ZhbGlkX291dHB1dChkaXNwbGF5LCBwaXBlLCBvdXRwdXQpIHsKCi0tIApSZWdhcmRzLAoKTGF1 cmVudCBQaW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==