All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@codeaurora.org>
To: David Miller <davem@davemloft.net>,
	alokc@codeaurora.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] net: qcom/emac: add support for the Qualcomm Technologies QDF2400
Date: Tue, 22 Nov 2016 16:14:13 -0600	[thread overview]
Message-ID: <5834C335.4040907@codeaurora.org> (raw)
In-Reply-To: <1479769102-27909-3-git-send-email-timur@codeaurora.org>

On 11/21/2016 04:58 PM, Timur Tabi wrote:
> The QDF2432 and the QDF2400 have slightly different internal PHYs,
> so there are some programming differences.  Some of the registers in
> the QDF2400 have moved, and some registers require different values
> during initialization.
>
> Because of the differences, the internal PHY on the QDF2400 has a new
> ACPI HID, QCOM8072.
>
> Signed-off-by: Timur Tabi<timur@codeaurora.org>

There seems to be some disagreement internally as to whether a new HID 
is the right approach.  Please hold off on applying patch [2/2] for now.

Patch [1/2] can be applied, however, if it passes review.

-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

      reply	other threads:[~2016-11-22 22:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-21 22:58 [PATCH 0/2] net: qcom/emac: simplify support for different SOCs Timur Tabi
2016-11-21 22:58 ` [PATCH 1/2] net: qcom/emac: move phy init code to separate files Timur Tabi
2016-11-24 16:32   ` David Miller
2016-11-24 16:39     ` Timur Tabi
2016-11-21 22:58 ` [PATCH 2/2] net: qcom/emac: add support for the Qualcomm Technologies QDF2400 Timur Tabi
2016-11-22 22:14   ` Timur Tabi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5834C335.4040907@codeaurora.org \
    --to=timur@codeaurora.org \
    --cc=alokc@codeaurora.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.