From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60289)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <w90p710@gmail.com>) id 1c9O1l-00041d-FI
	for qemu-devel@nongnu.org; Tue, 22 Nov 2016 22:15:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <w90p710@gmail.com>) id 1c9O1k-0006Bk-D3
	for qemu-devel@nongnu.org; Tue, 22 Nov 2016 22:15:17 -0500
References: <20161121012439.2394-1-w90p710@gmail.com>
	<CACaajQvCKxWib9E=a-k-3Bb0yWkP39CMb+95QaSQ-eq0+62HUQ@mail.gmail.com>
	<5833AE1C.2050708@gmail.com>
	<c41abc51-fce9-b4fc-4366-a72008655284@redhat.com>
From: wyang <w90p710@gmail.com>
Message-ID: <583509B1.6030400@gmail.com>
Date: Wed, 23 Nov 2016 11:14:57 +0800
MIME-Version: 1.0
In-Reply-To: <c41abc51-fce9-b4fc-4366-a72008655284@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] block/mirror: enable detect zeroes when
 driving mirror
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, Vasiliy Tolstov <v.tolstov@selfip.ru>
Cc: jcody@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org

On 2016年11月22日 21:44, Eric Blake wrote:
> On 11/21/2016 08:31 PM, wyang wrote:
>> On 2016年11月21日 14:51, Vasiliy Tolstov wrote:
>>> 21 Ноя 2016 г. 4:27 пользователь "Yang Wei" <w90p710@gmail.com
>>> <mailto:w90p710@gmail.com>> написал:
>>>> In order to preserve sparse disk image, detect_zeroes
>>>> should also be enabled when bdrv_get_block_status_above()
>>>> returns BDRV_BLOCK_DATA
>>>>
>>>> Signed-off-by: Yang Wei <w90p710@gmail.com <mailto:w90p710@gmail.com>>
>>>> ---
>>> Hi, does this patch fixes bug
>>> https://bugzilla.redhat.com/show_bug.cgi?id=1219541 ? Or it unrelated
>>> to this issue?
>>>
>> yes, you also need to  backport  the functionality of NBD's write
>> zeroes(  fa778f and 1f4d6d)
> And also my posted (but not yet applied) patch:
> nbd: Allow unmap and fua during write zeroes
> https://lists.gnu.org/archive/html/qemu-devel/2016-11/msg03496.html
Got it, I would also backport it to my qemu repo. thank you Eric.;-)

Wei
>