Re: [v7 2/3] vfio: support notifier chain in vfio_group

[Jike Song <jike.song@intel.com>]

On 11/23/2016 02:33 PM, Tian, Kevin wrote:
>> From: Song, Jike
>> Sent: Wednesday, November 23, 2016 2:30 PM
>> On 11/23/2016 01:56 PM, Alex Williamson wrote:
>>> On Wed, 23 Nov 2016 10:22:37 +0530
>>> Kirti Wankhede <kwankhede@nvidia.com> wrote:
>>>>
>>>> Most of the distro's kernel have CONFIG_MODVERSIONS enabled and its
>>>> mostly safe to build driver against the kernel to which its going to load.
>>>> For backend IOMMU module, we have same callback functions or
>>>> VFIO_IOMMU_NOTIFY, but as Alex mentioned different IOMMU backend modules
>>>> might have different events/actions. Then the event check shouldn't be
>>>> in vfio module, it should be in backend module.
>>>
>>> Yes, patch 1/3 is wrong, the required events mask should be passed to
>>> the iommu backend and handled there, not in vfio.c.  Thanks,
>>
>> Will change that. BTW, do you think the iommu types should be different?
>> that is to say, having VFIO_IOMMU_NOTIFY_TYPE1 instead of VFIO_IOMMU_NOTIFY?
>>
> 
> Should vendor driver care about underlying IOMMU difference? Assume
> those notification events should be IOMMU vendor agnostic... 

I also lean towards keeping VFIO_IOMMU_NOTIFY, will update [1/3] without
changing that part.

--
Thanks,
Jike