From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [RFC 4/4] ARM: dts: exynos4x12: add suspend OPP for DMC and leftbus Date: Fri, 25 Nov 2016 08:44:12 +0900 Message-ID: <58377B4C.5010503@samsung.com> References: <1479909087-22659-1-git-send-email-tjakobi@math.uni-bielefeld.de> <1479909087-22659-5-git-send-email-tjakobi@math.uni-bielefeld.de> <58364560.4030904@samsung.com> <5836F8C6.4080708@math.uni-bielefeld.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Return-path: In-reply-to: <5836F8C6.4080708@math.uni-bielefeld.de> Sender: linux-samsung-soc-owner@vger.kernel.org To: Tobias Jakobi , linux-samsung-soc@vger.kernel.org Cc: linux-pm@vger.kernel.org, m.reichl@fivetechno.de, myungjoo.ham@gmail.com List-Id: linux-pm@vger.kernel.org Hi Tobias, On 2016년 11월 24일 23:27, Tobias Jakobi wrote: > Hello Chanwoo, > > since exynos-bus is not only used for the Exynos4 platform, could you > maybe check if we need to apply this elsewhere? Sure, I'll review and test your patches on following boards: - exynos4412-u3/exynos5422-xu3/exynos3250-rinato. Regards, Chanwoo Choi > > I see in the exynos5422-odroidxu3-common.dtsi that bus_wcore adjusts the > INT voltage. But MyungJoo mentioned that on newer platform the BL0 might > be "smarter", so we don't need this. > > With best wishes, > Tobias > > > Chanwoo Choi wrote: >> Hi Tobias, >> >> Looks good to me. >> Because the bus_dmc (MIF) and bus_leftbus (INT) are parent devfreq device. >> >> Reviewed-by: Chanwoo Choi >> >> Best Regards, >> Chanwoo Choi >> >> On 2016년 11월 23일 22:51, Tobias Jakobi wrote: >>> TODO: write desc >>> Signed-off-by: Tobias Jakobi >>> --- >>> arch/arm/boot/dts/exynos4x12.dtsi | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi >>> index d5cb433..a00a8b0 100644 >>> --- a/arch/arm/boot/dts/exynos4x12.dtsi >>> +++ b/arch/arm/boot/dts/exynos4x12.dtsi >>> @@ -375,6 +375,7 @@ >>> opp@400000000 { >>> opp-hz = /bits/ 64 <400000000>; >>> opp-microvolt = <1050000>; >>> + opp-suspend; >>> }; >>> }; >>> >>> @@ -463,6 +464,7 @@ >>> opp@200000000 { >>> opp-hz = /bits/ 64 <200000000>; >>> opp-microvolt = <1000000>; >>> + opp-suspend; >>> }; >>> }; >>> >>> >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- Best Regards, Chanwoo Choi