From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 4/5] ubloxmodem: intialize and register the netmon driver
Date: Tue, 29 Nov 2016 10:53:18 -0600 [thread overview]
Message-ID: <583DB27E.3040403@gmail.com> (raw)
In-Reply-To: <1480082415-30822-5-git-send-email-djalal@endocode.com>
[-- Attachment #1: Type: text/plain, Size: 702 bytes --]
Hi Djalal,
On 11/25/2016 08:00 AM, djalal(a)endocode.com wrote:
> From: Djalal Harouni <djalal@endocode.com>
>
> This patch allows to intialize and register the ublox netmon driver.
> ---
> drivers/ubloxmodem/ubloxmodem.c | 2 ++
> drivers/ubloxmodem/ubloxmodem.h | 3 +++
> plugins/ublox.c | 3 +++
> 3 files changed, 8 insertions(+)
>
This patch isn't broken down properly. See HACKING, 'Submitting
patches' section. Each top-level directory change should be in a
separate patch. E.g. one patch for drivers/* and one patch for plugins/*.
It might be easier to simply squash drivers/ubloxmodem/ubloxmodem.[ch]
changes into patch 3.
Regards,
-Denis
next prev parent reply other threads:[~2016-11-29 16:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 14:00 [PATCH 0/5] RFC: ubloxmodem add netmon interface djalal
2016-11-25 14:00 ` [PATCH 1/5] netmon: add OFONO_NETMON_INFO_{RSCP|ECN0|RSRQ|RSRP|OPERATOR} djalal
2016-11-29 16:43 ` Denis Kenzior
2016-11-30 11:45 ` Djalal Harouni
2016-11-25 14:00 ` [PATCH 2/5] netmon: handle OFONO_NETMON_INFO_{RSCP|ECN0|RSRQ|RSRP|OPERATOR} in D-Bus djalal
2016-11-29 16:49 ` Denis Kenzior
2016-11-30 11:48 ` Djalal Harouni
2016-11-25 14:00 ` [PATCH 3/5] ubloxmodem: add the netmon driver djalal
2016-11-29 17:32 ` Denis Kenzior
2016-11-30 12:05 ` Djalal Harouni
2016-11-25 14:00 ` [PATCH 4/5] ubloxmodem: intialize and register " djalal
2016-11-29 16:53 ` Denis Kenzior [this message]
2016-11-30 11:49 ` Djalal Harouni
2016-11-25 14:00 ` [PATCH 5/5] test: support OFONO_NETMON_INFO_{RSCP|ECN0|RSRQ|RSRP|OPERATOR} djalal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=583DB27E.3040403@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.