From mboxrd@z Thu Jan 1 00:00:00 1970 From: Seung-Woo Kim Subject: Re: [PATCH v2] arm64: dts: exynos: Add flash led dt node for TM2 board Date: Wed, 30 Nov 2016 17:44:20 +0900 Message-ID: <583E9164.1090208@samsung.com> References: <1480480062-3472-1-git-send-email-sw0312.kim@samsung.com> <1480481337-3941-1-git-send-email-sw0312.kim@samsung.com> <583E8F73.2060804@samsung.com> Reply-To: sw0312.kim@samsung.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Return-path: Received: from mailout2.samsung.com ([203.254.224.25]:44979 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753078AbcK3IoZ (ORCPT ); Wed, 30 Nov 2016 03:44:25 -0500 In-reply-to: <583E8F73.2060804@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Chanwoo Choi Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, kgene@kernel.org, krzk@kernel.org, javier@osg.samsung.com, Ingi Kim , Seung-Woo Kim Hello Chanwoo, On 2016년 11월 30일 17:36, Chanwoo Choi wrote: > Dear Seung-Woo, > > I think that this patch looks good to me. > But, When I tested this patch on my TM2 board, > the flash turn off after some millisecond automatically. Thank you for testing on your side. I will check on my side about the issue, and if I find, then I will send next version. Regards, - Seung-Woo Kim > > It is strange situation. Unfortunately, I don't know the cause. > I think that we better to check this issue for more time. > > Best Regards, > Chanwoo Choi > > On 2016년 11월 30일 13:48, Seung-Woo Kim wrote: >> From: Ingi Kim >> >> This patch adds Kinetic ktd2692 flash led device node for TM2 board. >> >> Signed-off-by: Ingi Kim >> Signed-off-by: Seung-Woo Kim >> --- >> Change from v1: >> - gpio active value is set with defined macro instead of value. >> --- >> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 13 +++++++++++++ >> 1 files changed, 13 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> index f21bdc2..0d454aa 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> @@ -58,6 +58,19 @@ >> reg = <0x0 0x20000000 0x0 0xc0000000>; >> }; >> >> + camera-flash { >> + compatible = "kinetic,ktd2692"; >> + ctrl-gpios = <&gpc0 1 GPIO_ACTIVE_HIGH>; >> + aux-gpios = <&gpc0 2 GPIO_ACTIVE_HIGH>; >> + >> + flash-led { >> + label = "ktd2692-flash"; >> + led-max-microamp = <300000>; >> + flash-max-microamp = <1500000>; >> + flash-max-timeout-us = <1835000>; >> + }; >> + }; >> + >> gpio-keys { >> compatible = "gpio-keys"; >> >> > > -- Seung-Woo Kim Samsung Software R&D Center -- From mboxrd@z Thu Jan 1 00:00:00 1970 From: sw0312.kim@samsung.com (Seung-Woo Kim) Date: Wed, 30 Nov 2016 17:44:20 +0900 Subject: [PATCH v2] arm64: dts: exynos: Add flash led dt node for TM2 board In-Reply-To: <583E8F73.2060804@samsung.com> References: <1480480062-3472-1-git-send-email-sw0312.kim@samsung.com> <1480481337-3941-1-git-send-email-sw0312.kim@samsung.com> <583E8F73.2060804@samsung.com> Message-ID: <583E9164.1090208@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Chanwoo, On 2016? 11? 30? 17:36, Chanwoo Choi wrote: > Dear Seung-Woo, > > I think that this patch looks good to me. > But, When I tested this patch on my TM2 board, > the flash turn off after some millisecond automatically. Thank you for testing on your side. I will check on my side about the issue, and if I find, then I will send next version. Regards, - Seung-Woo Kim > > It is strange situation. Unfortunately, I don't know the cause. > I think that we better to check this issue for more time. > > Best Regards, > Chanwoo Choi > > On 2016? 11? 30? 13:48, Seung-Woo Kim wrote: >> From: Ingi Kim >> >> This patch adds Kinetic ktd2692 flash led device node for TM2 board. >> >> Signed-off-by: Ingi Kim >> Signed-off-by: Seung-Woo Kim >> --- >> Change from v1: >> - gpio active value is set with defined macro instead of value. >> --- >> arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 13 +++++++++++++ >> 1 files changed, 13 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> index f21bdc2..0d454aa 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts >> @@ -58,6 +58,19 @@ >> reg = <0x0 0x20000000 0x0 0xc0000000>; >> }; >> >> + camera-flash { >> + compatible = "kinetic,ktd2692"; >> + ctrl-gpios = <&gpc0 1 GPIO_ACTIVE_HIGH>; >> + aux-gpios = <&gpc0 2 GPIO_ACTIVE_HIGH>; >> + >> + flash-led { >> + label = "ktd2692-flash"; >> + led-max-microamp = <300000>; >> + flash-max-microamp = <1500000>; >> + flash-max-timeout-us = <1835000>; >> + }; >> + }; >> + >> gpio-keys { >> compatible = "gpio-keys"; >> >> > > -- Seung-Woo Kim Samsung Software R&D Center --