From: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: <linux-block@vger.kernel.org>
Subject: Re: [PATCH] block: avoid incorrect bdi_unregiter call in blk_cleanup_queue
Date: Fri, 2 Dec 2016 09:37:46 +0900 [thread overview]
Message-ID: <5840C25A.9070601@jp.fujitsu.com> (raw)
In-Reply-To: <d89155e1-4b52-b0a4-9db2-978e8c62cbfd@kernel.dk>
Hi Jens,
On Thu, 1 Dec 2016 08:04:33 -0700 Jens Axboe wrote:
> On 12/01/2016 01:45 AM, Masayoshi Mizuma wrote:
>> blk_cleanup_queue() should call bdi_unregister() only if WB_registered
>> is set to bdi->wb.state. Because, blk_cleanup_queue() may be called
>> before bdi_register() is called, for example, error path.
>
> Should this logic be in bdi_unregister() instead?
Thank you for pointed it out! I think your suggestion is better.
I will rewrite the patch.
- Masayoshi Mizuma
>
prev parent reply other threads:[~2016-12-02 0:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 8:45 [PATCH] block: avoid incorrect bdi_unregiter call in blk_cleanup_queue Masayoshi Mizuma
2016-12-01 15:04 ` Jens Axboe
2016-12-02 0:37 ` Masayoshi Mizuma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5840C25A.9070601@jp.fujitsu.com \
--to=m.mizuma@jp.fujitsu.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.