All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiada Wang <jiada_wang@mentor.com>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: alsa-devel@alsa-project.org, Mark_Craske@mentor.com,
	apape@de.adit-jv.com, tiwai@suse.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3 v1] ALSA: usb-audio: more tolerant packetsize
Date: Thu, 1 Dec 2016 21:53:20 -0800	[thread overview]
Message-ID: <58410C50.2090401@mentor.com> (raw)
In-Reply-To: <b869176e-54e4-a47c-98ab-11be08ca0e61@ladisch.de>

Hello Clemens

On 12/01/2016 04:15 AM, Clemens Ladisch wrote:
> Jiada Wang wrote:
>> On 11/30/2016 11:41 PM, Clemens Ladisch wrote:
>>> Jiada Wang wrote:
>>>> since commit 57e6dae1087bbaa6b33d3dd8a8e90b63888939a3 the expected packetsize is always limited to
>>>> nominal + 25%. It was discovered, that some devices
>>> Which devices?
>> It was a LG nexus
> So it was the Android audio accessory mode.
>
>>>> have a much higher jitter in used packetsizes than 25%
>>> How high?
>> the nominal packet size was somewhere around 176bytes
>> +25% would result in max expected packets to be ~220bytes
>> We observed some packets exceeding this size (256byte)
> 256 bytes per USB frame would correspond to 64 kHz, instead of the
> nominal 44.1 kHz.
>
> The audio accessory sample format is fixed, and that mode is no longer
> developed, so increasing the limit to +50% would be sufficient to work
> around this problem.
>
> I don't know if this is a bug in Google's generic AOA code, or if LG did
> some changes; I have not heard any other report so far ...
>
We also reproduced the same issue with following android devices,
* Samsung S4, Android 4.2.2, model GT-I9505
* Sony Xperia Z, Android 4.2.2, model number CC6603
* LGE Nexus 4, Android 4.2.2
so it most likely not a LG specific issue.

I agree to increase to +50% would be sufficient to avoid this issue.

Thanks,
Jiada


> Regards,
> Clemens

  reply	other threads:[~2016-12-02  5:53 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-30  7:59 [PATCH 0/3 v1] usb-misc fix Jiada Wang
2016-11-30  7:59 ` Jiada Wang
2016-11-30  7:59 ` [PATCH 1/3 v1] ALSA: usb-audio: more tolerant packetsize Jiada Wang
2016-11-30  7:59   ` Jiada Wang
2016-11-30  8:54   ` Takashi Iwai
2016-11-30  8:54     ` Takashi Iwai
2016-12-01  7:04     ` Jiada Wang
2016-12-01  7:04       ` Jiada Wang
2016-12-01  7:41   ` [alsa-devel] " Clemens Ladisch
2016-12-01  8:58     ` Takashi Iwai
2016-12-01 11:16       ` Clemens Ladisch
2016-12-01 11:23         ` Takashi Iwai
2016-12-01 11:50           ` Clemens Ladisch
2016-12-01 11:36     ` Jiada Wang
2016-12-01 12:15       ` [alsa-devel] " Clemens Ladisch
2016-12-02  5:53         ` Jiada Wang [this message]
2016-11-30  7:59 ` [PATCH 2/3 v2] ALSA: usb-audio: avoid setting of sample rate multiple times on bus Jiada Wang
2016-11-30  7:59   ` Jiada Wang
2016-11-30  8:51   ` Takashi Iwai
2016-11-30  8:51     ` Takashi Iwai
2016-12-01  7:07     ` Jiada Wang
2016-12-01  7:07       ` Jiada Wang
2016-11-30 10:45   ` Takashi Sakamoto
2016-11-30 22:19     ` Takashi Sakamoto
2016-12-05  7:32     ` Jiada Wang
2016-12-05  7:32       ` Jiada Wang
2016-12-05  9:58       ` Takashi Sakamoto
2016-11-30  7:59 ` [PATCH 3/3 v3] ALSA: usb-audio: fix race in snd_usb_endpoint_stop Jiada Wang
2016-11-30  7:59   ` Jiada Wang
2016-11-30  9:00   ` Takashi Iwai
2016-11-30  9:00     ` Takashi Iwai
2016-12-05 10:10     ` Jiada Wang
2016-12-05 10:10       ` Jiada Wang
2016-12-05 10:30       ` Takashi Iwai
2016-12-05 10:30         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58410C50.2090401@mentor.com \
    --to=jiada_wang@mentor.com \
    --cc=Mark_Craske@mentor.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=apape@de.adit-jv.com \
    --cc=clemens@ladisch.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.