From: Chanwoo Choi <cw00.choi@samsung.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Rafael Wysocki <rjw@rjwysocki.net>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
Stephen Boyd <sboyd@codeaurora.org>,
nm@ti.com, Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH] devfreq: exynos: Don't use OPP structures outside of RCU locks
Date: Fri, 02 Dec 2016 17:39:02 +0900 [thread overview]
Message-ID: <58413326.6050407@samsung.com> (raw)
In-Reply-To: <9cb02ef0037c8d161f7b57ff3e99c2831661da03.1480587838.git.viresh.kumar@linaro.org>
Hi Viresh,
On 2016년 12월 01일 19:25, Viresh Kumar wrote:
> The OPP structures are abused to the best here, without understanding
> how the OPP core and RCU locks work.
>
> In short, the OPP pointer saved 'struct exynos_bus' can become invalid
> under your nose, as the OPP core may free it.
>
> Fix various abuses around OPP structures and calls.
>
> Compile tested only.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> I would like it to go via the PM tree. Perhaps that's already the
> default tree for this.
>
> drivers/devfreq/exynos-bus.c | 29 ++++++++++++++---------------
> 1 file changed, 14 insertions(+), 15 deletions(-)
Looks good to me and I tested this patch on Exynos4412-odroidu3/Exynos5433-TM2.
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Tested-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
prev parent reply other threads:[~2016-12-02 8:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161201102605epcas4p118a7bc6f533d61d36f0ed66b8c349852@epcas4p1.samsung.com>
2016-12-01 10:25 ` [PATCH] devfreq: exynos: Don't use OPP structures outside of RCU locks Viresh Kumar
2016-12-02 8:39 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58413326.6050407@samsung.com \
--to=cw00.choi@samsung.com \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.