From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51203) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDrBl-0004zq-9c for qemu-devel@nongnu.org; Mon, 05 Dec 2016 06:12:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDrBh-0003YM-B8 for qemu-devel@nongnu.org; Mon, 05 Dec 2016 06:12:05 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:54763) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1cDrBg-0003Xu-6I for qemu-devel@nongnu.org; Mon, 05 Dec 2016 06:12:01 -0500 Message-ID: <58454B69.4040402@huawei.com> Date: Mon, 5 Dec 2016 19:11:37 +0800 From: "Longpeng (Mike)" MIME-Version: 1.0 References: <1480928380-161760-1-git-send-email-longpeng2@huawei.com> <1480928380-161760-2-git-send-email-longpeng2@huawei.com> <20161205091842.GA2498@redhat.com> In-Reply-To: <20161205091842.GA2498@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.9 1/3] crypto: add standard des support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: eblake@redhat.com, armbru@redhat.com, arei.gonglei@huawei.com, qemu-devel@nongnu.org, wu.wubin@huawei.com, jianjay.zhou@huawei.com Hi Daniel, On 2016/12/5 17:18, Daniel P. Berrange wrote: > On Mon, Dec 05, 2016 at 04:59:38PM +0800, Longpeng(Mike) wrote: ...... >> diff --git a/qapi/crypto.json b/qapi/crypto.json >> index 5c9d7d4..d403ab9 100644 >> --- a/qapi/crypto.json >> +++ b/qapi/crypto.json >> @@ -75,7 +75,7 @@ >> { 'enum': 'QCryptoCipherAlgorithm', >> 'prefix': 'QCRYPTO_CIPHER_ALG', >> 'data': ['aes-128', 'aes-192', 'aes-256', >> - 'des-rfb', >> + 'des-rfb', 'des', > > Can we call this '3des' to make it clear that this is Triple-DES and not > the single-DES (which des-rfb is) > As the comment in qapi/crypto.json said: @des-rfb: RFB specific variant of single DES. This patch just add the standard single-DES support, not the triple-DES, so I think maybe "des" is suitable. And we will add "3des" in the near-future. >> 'cast5-128', >> 'serpent-128', 'serpent-192', 'serpent-256', >> 'twofish-128', 'twofish-192', 'twofish-256']} > > Regards, > Daniel -- Regards, Longpeng(Mike)