From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH 01/12] phy: rcar-gen3-usb2: Replace the deprecated extcon API Date: Tue, 06 Dec 2016 09:25:25 +0900 Message-ID: <58460575.8030008@samsung.com> References: <1480485460-2663-1-git-send-email-cw00.choi@samsung.com> <1480485460-2663-2-git-send-email-cw00.choi@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <1480485460-2663-2-git-send-email-cw00.choi@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: balbi@kernel.org, gregkh@linuxfoundation.org, kishon@ti.com, sre@kernel.org Cc: Peter.Chen@nxp.com, linux-pm@vger.kernel.org, yoshihiro.shimoda.uh@renesas.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, wens@csie.org, chanwoo@kernel.org, maxime.ripard@free-electrons.com, linux-omap@vger.kernel.org, b-liu@ti.com, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org SGkgS2lzaG9uLAoKQ291bGQgeW91IHJldmlldyBhbmQgcGljayB0aGUgcGF0Y2gxLzIgZm9yIHBo eSBkcml2ZXI/CgpCZXN0IFJlZ2FyZHMsCkNoYW53b28gQ2hvaQoKT24gMjAxNuuFhCAxMeyblCAz MOydvCAxNDo1NywgQ2hhbndvbyBDaG9pIHdyb3RlOgo+IFRoaXMgcGF0Y2ggcmVwbGFjZXMgdGhl IGRlcHJlY2F0ZWQgZXh0Y29uIEFQSSBhcyBmb2xsb3dpbmc6Cj4gLSBleHRjb25fc2V0X2NhYmxl X3N0YXRlXygpIC0+IGV4dGNvbl9zZXRfc3RhdGVfc3luYygpCj4gCj4gU2lnbmVkLW9mZi1ieTog Q2hhbndvbyBDaG9pIDxjdzAwLmNob2lAc2Ftc3VuZy5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvcGh5 L3BoeS1yY2FyLWdlbjMtdXNiMi5jIHwgOCArKysrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNCBp bnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3Bo eS9waHktcmNhci1nZW4zLXVzYjIuYyBiL2RyaXZlcnMvcGh5L3BoeS1yY2FyLWdlbjMtdXNiMi5j Cj4gaW5kZXggYmQyNDMwZDczMzljLi43ZjgwODFmMTU3ZjQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9waHkvcGh5LXJjYXItZ2VuMy11c2IyLmMKPiArKysgYi9kcml2ZXJzL3BoeS9waHktcmNhci1n ZW4zLXVzYjIuYwo+IEBAIC05MywxMSArOTMsMTEgQEAgc3RhdGljIHZvaWQgcmNhcl9nZW4zX3Bo eV91c2IyX3dvcmsoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ICAJCQkJCQkgd29yayk7Cj4g IAo+ICAJaWYgKGNoLT5leHRjb25faG9zdCkgewo+IC0JCWV4dGNvbl9zZXRfY2FibGVfc3RhdGVf KGNoLT5leHRjb24sIEVYVENPTl9VU0JfSE9TVCwgdHJ1ZSk7Cj4gLQkJZXh0Y29uX3NldF9jYWJs ZV9zdGF0ZV8oY2gtPmV4dGNvbiwgRVhUQ09OX1VTQiwgZmFsc2UpOwo+ICsJCWV4dGNvbl9zZXRf c3RhdGVfc3luYyhjaC0+ZXh0Y29uLCBFWFRDT05fVVNCX0hPU1QsIHRydWUpOwo+ICsJCWV4dGNv bl9zZXRfc3RhdGVfc3luYyhjaC0+ZXh0Y29uLCBFWFRDT05fVVNCLCBmYWxzZSk7Cj4gIAl9IGVs c2Ugewo+IC0JCWV4dGNvbl9zZXRfY2FibGVfc3RhdGVfKGNoLT5leHRjb24sIEVYVENPTl9VU0Jf SE9TVCwgZmFsc2UpOwo+IC0JCWV4dGNvbl9zZXRfY2FibGVfc3RhdGVfKGNoLT5leHRjb24sIEVY VENPTl9VU0IsIHRydWUpOwo+ICsJCWV4dGNvbl9zZXRfc3RhdGVfc3luYyhjaC0+ZXh0Y29uLCBF WFRDT05fVVNCX0hPU1QsIGZhbHNlKTsKPiArCQlleHRjb25fc2V0X3N0YXRlX3N5bmMoY2gtPmV4 dGNvbiwgRVhUQ09OX1VTQiwgdHJ1ZSk7Cj4gIAl9Cj4gIH0KPiAgCj4gCgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <58460575.8030008@samsung.com> Date: Tue, 06 Dec 2016 09:25:25 +0900 From: Chanwoo Choi To: balbi@kernel.org, gregkh@linuxfoundation.org, kishon@ti.com, sre@kernel.org Cc: Peter.Chen@nxp.com, wens@csie.org, yoshihiro.shimoda.uh@renesas.com, maxime.ripard@free-electrons.com, b-liu@ti.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, chanwoo@kernel.org Subject: Re: [PATCH 01/12] phy: rcar-gen3-usb2: Replace the deprecated extcon API References: <1480485460-2663-1-git-send-email-cw00.choi@samsung.com> <1480485460-2663-2-git-send-email-cw00.choi@samsung.com> In-reply-to: <1480485460-2663-2-git-send-email-cw00.choi@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: Hi Kishon, Could you review and pick the patch1/2 for phy driver? Best Regards, Chanwoo Choi On 2016년 11월 30일 14:57, Chanwoo Choi wrote: > This patch replaces the deprecated extcon API as following: > - extcon_set_cable_state_() -> extcon_set_state_sync() > > Signed-off-by: Chanwoo Choi > --- > drivers/phy/phy-rcar-gen3-usb2.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/phy/phy-rcar-gen3-usb2.c b/drivers/phy/phy-rcar-gen3-usb2.c > index bd2430d7339c..7f8081f157f4 100644 > --- a/drivers/phy/phy-rcar-gen3-usb2.c > +++ b/drivers/phy/phy-rcar-gen3-usb2.c > @@ -93,11 +93,11 @@ static void rcar_gen3_phy_usb2_work(struct work_struct *work) > work); > > if (ch->extcon_host) { > - extcon_set_cable_state_(ch->extcon, EXTCON_USB_HOST, true); > - extcon_set_cable_state_(ch->extcon, EXTCON_USB, false); > + extcon_set_state_sync(ch->extcon, EXTCON_USB_HOST, true); > + extcon_set_state_sync(ch->extcon, EXTCON_USB, false); > } else { > - extcon_set_cable_state_(ch->extcon, EXTCON_USB_HOST, false); > - extcon_set_cable_state_(ch->extcon, EXTCON_USB, true); > + extcon_set_state_sync(ch->extcon, EXTCON_USB_HOST, false); > + extcon_set_state_sync(ch->extcon, EXTCON_USB, true); > } > } > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: cw00.choi@samsung.com (Chanwoo Choi) Date: Tue, 06 Dec 2016 09:25:25 +0900 Subject: [PATCH 01/12] phy: rcar-gen3-usb2: Replace the deprecated extcon API In-Reply-To: <1480485460-2663-2-git-send-email-cw00.choi@samsung.com> References: <1480485460-2663-1-git-send-email-cw00.choi@samsung.com> <1480485460-2663-2-git-send-email-cw00.choi@samsung.com> Message-ID: <58460575.8030008@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Kishon, Could you review and pick the patch1/2 for phy driver? Best Regards, Chanwoo Choi On 2016? 11? 30? 14:57, Chanwoo Choi wrote: > This patch replaces the deprecated extcon API as following: > - extcon_set_cable_state_() -> extcon_set_state_sync() > > Signed-off-by: Chanwoo Choi > --- > drivers/phy/phy-rcar-gen3-usb2.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/phy/phy-rcar-gen3-usb2.c b/drivers/phy/phy-rcar-gen3-usb2.c > index bd2430d7339c..7f8081f157f4 100644 > --- a/drivers/phy/phy-rcar-gen3-usb2.c > +++ b/drivers/phy/phy-rcar-gen3-usb2.c > @@ -93,11 +93,11 @@ static void rcar_gen3_phy_usb2_work(struct work_struct *work) > work); > > if (ch->extcon_host) { > - extcon_set_cable_state_(ch->extcon, EXTCON_USB_HOST, true); > - extcon_set_cable_state_(ch->extcon, EXTCON_USB, false); > + extcon_set_state_sync(ch->extcon, EXTCON_USB_HOST, true); > + extcon_set_state_sync(ch->extcon, EXTCON_USB, false); > } else { > - extcon_set_cable_state_(ch->extcon, EXTCON_USB_HOST, false); > - extcon_set_cable_state_(ch->extcon, EXTCON_USB, true); > + extcon_set_state_sync(ch->extcon, EXTCON_USB_HOST, false); > + extcon_set_state_sync(ch->extcon, EXTCON_USB, true); > } > } > >