From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Stuart Yoder <stuart.yoder@nxp.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"agraf@suse.de" <agraf@suse.de>,
"Ruxandra Ioana Radulescu" <ruxandra.radulescu@nxp.com>,
"arnd@arndb.de" <arnd@arndb.de>, Roy Pledge <roy.pledge@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Leo Li <leoyang.li@nxp.com>,
Catalin Horghidan <catalin.horghidan@nxp.com>,
"Ioana Ciornei" <ioana.ciornei@nxp.com>
Subject: Re: [PATCH v3 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs
Date: Tue, 6 Dec 2016 10:35:59 +0000 [thread overview]
Message-ID: <5846948E.10203@nxp.com> (raw)
In-Reply-To: <20161205205226.GB31322@mwanda>
On 12/05/2016 10:52 PM, Dan Carpenter wrote:
> On Fri, Dec 02, 2016 at 12:12:14PM +0000, Laurentiu Tudor wrote:
>>> +static inline bool dpaa2_sg_is_final(const struct dpaa2_sg_entry *sg)
>>> +{
>>> + return !!(le16_to_cpu(sg->format_offset) >> SG_FINAL_FLAG_SHIFT);
>>
>> In other places in this file we don't use the '!!' to convert to bool. Maybe we should drop it here too.
>
> I like the explicit "!!". I think it makes the code more obvious since
> all the information is on one line.
>
That's fine too, as long as we're doing it consistently in all the places.
---
Best Regards, Laurentiu
next prev parent reply other threads:[~2016-12-06 15:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 22:41 [PATCH v3 0/9] staging: fsl-mc: move bus driver out of staging, add dpio Stuart Yoder
2016-12-01 22:41 ` [PATCH v3 1/9] staging: fsl-mc: move bus driver out of staging Stuart Yoder
2016-12-07 15:52 ` Greg KH
2016-12-07 20:19 ` Stuart Yoder
2016-12-08 16:05 ` Greg KH
2016-12-09 0:36 ` Stuart Yoder
2016-12-09 7:10 ` Greg KH
2016-12-09 15:53 ` Stuart Yoder
2016-12-01 22:41 ` [PATCH v3 2/9] bus: fsl-mc: dpio: add DPIO driver overview document Stuart Yoder
2016-12-01 22:41 ` [PATCH v3 3/9] bus: fsl-mc: dpio: add APIs for DPIO objects Stuart Yoder
2016-12-02 11:26 ` Laurentiu Tudor
2016-12-15 16:36 ` Stuart Yoder
2016-12-01 22:41 ` [PATCH v3 4/9] bus: fsl-mc: dpio: add frame descriptor and scatter/gather APIs Stuart Yoder
2016-12-02 12:12 ` Laurentiu Tudor
2016-12-05 20:52 ` Dan Carpenter
2016-12-06 10:35 ` Laurentiu Tudor [this message]
2016-12-15 16:41 ` Stuart Yoder
2016-12-01 22:41 ` [PATCH v3 5/9] bus: fsl-mc: dpio: add global dpaa2 definitions Stuart Yoder
2016-12-02 12:19 ` Laurentiu Tudor
2016-12-15 17:12 ` Stuart Yoder
2016-12-01 22:41 ` [PATCH v3 6/9] bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2 Stuart Yoder
2016-12-02 12:40 ` Laurentiu Tudor
2016-12-15 22:20 ` Stuart Yoder
2016-12-01 22:41 ` [PATCH v3 7/9] bus: fsl-mc: dpio: add the DPAA2 DPIO service interface Stuart Yoder
2016-12-02 13:02 ` Laurentiu Tudor
2016-12-15 22:43 ` Stuart Yoder
2016-12-01 22:41 ` [PATCH v3 8/9] bus: fsl-mc: dpio: add the DPAA2 DPIO object driver Stuart Yoder
2016-12-01 22:41 ` [PATCH v3 9/9] bus: fsl-mc: dpio: add maintainer for DPIO Stuart Yoder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5846948E.10203@nxp.com \
--to=laurentiu.tudor@nxp.com \
--cc=agraf@suse.de \
--cc=arnd@arndb.de \
--cc=catalin.horghidan@nxp.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=ioana.ciornei@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roy.pledge@nxp.com \
--cc=ruxandra.radulescu@nxp.com \
--cc=stuart.yoder@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.