From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Icenowy Zheng To: Maxime Ripard , Quentin Schulz Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "lars@metafoo.de" , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-sunxi@googlegroups.com" , "dmitry.torokhov@gmail.com" , "linux@armlinux.org.uk" , "stefan.mavrodiev@gmail.com" , "wens@csie.org" , "robh+dt@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "pmeerw@pmeerw.net" , "knaack.h@gmx.de" , "lee.jones@linaro.org" , "thomas.petazzoni@free-electrons.com" , "jic23@kernel.org" In-Reply-To: <20170310122544.wkbqnzq2twfciyaw@lukather> References: <20170310103921.19469-1-quentin.schulz@free-electrons.com> <20170310103921.19469-6-quentin.schulz@free-electrons.com> <20170310122544.wkbqnzq2twfciyaw@lukather> Subject: Re: [PATCH v2 05/11] Documentation: DT: bindings: mfd: add A33 GPADC binding MIME-Version: 1.0 Message-Id: <5847351489174431@web4o.yandex.ru> Date: Sat, 11 Mar 2017 03:33:51 +0800 Content-Type: text/plain; charset=utf-8 List-ID: 10.03.2017, 20:26, "Maxime Ripard" : > On Fri, Mar 10, 2017 at 11:39:15AM +0100, Quentin Schulz wrote: >>  This patch adds documentation for the A33 GPADC binding. >> >>  Signed-off-by: Quentin Schulz >>  --- >> >>  added in v2 >> >>   .../devicetree/bindings/mfd/sun4i-gpadc.txt | 59 ++++++++++++++++++++++ >>   1 file changed, 59 insertions(+) >>   create mode 100644 Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >> >>  diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >>  new file mode 100644 >>  index 0000000..17242c8 >>  --- /dev/null >>  +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >>  @@ -0,0 +1,59 @@ >>  +Allwinner SoCs' GPADC Device Tree bindings >>  +------------------------------------------ >>  +The Allwinner SoCs all have an ADC that can also act as a thermal sensor >>  +and sometimes as a touchscreen controller. >>  + >>  +Required properties: >>  + - compatible: "sun8i-a33-gpadc-iio", > > This doesn't match your example, and you shouldn't have IIO in > there. Compatibles shouldn't be tied to a given framework, since that > is Linux specific (and might even change in the future). >>From this aspect, I think we shouldn't even call it gpadc in compatible -- as it's not GP at all on A33. > > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com > , > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: icenowy@aosc.xyz (Icenowy Zheng) Date: Sat, 11 Mar 2017 03:33:51 +0800 Subject: [PATCH v2 05/11] Documentation: DT: bindings: mfd: add A33 GPADC binding In-Reply-To: <20170310122544.wkbqnzq2twfciyaw@lukather> References: <20170310103921.19469-1-quentin.schulz@free-electrons.com> <20170310103921.19469-6-quentin.schulz@free-electrons.com> <20170310122544.wkbqnzq2twfciyaw@lukather> Message-ID: <5847351489174431@web4o.yandex.ru> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 10.03.2017, 20:26, "Maxime Ripard" : > On Fri, Mar 10, 2017 at 11:39:15AM +0100, Quentin Schulz wrote: >> ?This patch adds documentation for the A33 GPADC binding. >> >> ?Signed-off-by: Quentin Schulz >> ?--- >> >> ?added in v2 >> >> ??.../devicetree/bindings/mfd/sun4i-gpadc.txt | 59 ++++++++++++++++++++++ >> ??1 file changed, 59 insertions(+) >> ??create mode 100644 Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >> >> ?diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >> ?new file mode 100644 >> ?index 0000000..17242c8 >> ?--- /dev/null >> ?+++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >> ?@@ -0,0 +1,59 @@ >> ?+Allwinner SoCs' GPADC Device Tree bindings >> ?+------------------------------------------ >> ?+The Allwinner SoCs all have an ADC that can also act as a thermal sensor >> ?+and sometimes as a touchscreen controller. >> ?+ >> ?+Required properties: >> ?+ - compatible: "sun8i-a33-gpadc-iio", > > This doesn't match your example, and you shouldn't have IIO in > there. Compatibles shouldn't be tied to a given framework, since that > is Linux specific (and might even change in the future). >>From this aspect, I think we shouldn't even call it gpadc in compatible -- as it's not GP at all on A33. > > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com > , > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Icenowy Zheng Subject: Re: [PATCH v2 05/11] Documentation: DT: bindings: mfd: add A33 GPADC binding Date: Sat, 11 Mar 2017 03:33:51 +0800 Message-ID: <5847351489174431@web4o.yandex.ru> References: <20170310103921.19469-1-quentin.schulz@free-electrons.com> <20170310103921.19469-6-quentin.schulz@free-electrons.com> <20170310122544.wkbqnzq2twfciyaw@lukather> Reply-To: icenowy-ymACFijhrKM@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20170310122544.wkbqnzq2twfciyaw@lukather> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Maxime Ripard , Quentin Schulz Cc: "mark.rutland-5wv7dgnIgG8@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org" , "linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org" , "dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org" , "stefan.mavrodiev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "wens-jdAy2FN1RRM@public.gmane.org" , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org" , "knaack.h-Mmb7MZpHnFY@public.gmane.org" , "lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org" , "jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" List-Id: devicetree@vger.kernel.org 10.03.2017, 20:26, "Maxime Ripard" : > On Fri, Mar 10, 2017 at 11:39:15AM +0100, Quentin Schulz wrote: >> =C2=A0This patch adds documentation for the A33 GPADC binding. >> >> =C2=A0Signed-off-by: Quentin Schulz >> =C2=A0--- >> >> =C2=A0added in v2 >> >> =C2=A0=C2=A0.../devicetree/bindings/mfd/sun4i-gpadc.txt | 59 +++++++++++= +++++++++++ >> =C2=A0=C2=A01 file changed, 59 insertions(+) >> =C2=A0=C2=A0create mode 100644 Documentation/devicetree/bindings/mfd/sun= 4i-gpadc.txt >> >> =C2=A0diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt= b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >> =C2=A0new file mode 100644 >> =C2=A0index 0000000..17242c8 >> =C2=A0--- /dev/null >> =C2=A0+++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt >> =C2=A0@@ -0,0 +1,59 @@ >> =C2=A0+Allwinner SoCs' GPADC Device Tree bindings >> =C2=A0+------------------------------------------ >> =C2=A0+The Allwinner SoCs all have an ADC that can also act as a thermal= sensor >> =C2=A0+and sometimes as a touchscreen controller. >> =C2=A0+ >> =C2=A0+Required properties: >> =C2=A0+ - compatible: "sun8i-a33-gpadc-iio", > > This doesn't match your example, and you shouldn't have IIO in > there. Compatibles shouldn't be tied to a given framework, since that > is Linux specific (and might even change in the future). >>From this aspect, I think we shouldn't even call it gpadc in compatible -- as it's not GP at all on A33. > > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com > , > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.