Re: [PATCH 1/3] Don't create default ioreq server

[Wen Congyang <wencongyang@gmail.com>]

At 2016/11/30 20:25, Andrew Cooper wrote:
> On 30/11/16 09:47, Zhang Chen wrote:
>> The ioreq server make colo run failed.
>>
>> Signed-off-by: Zhang Chen <zhangchen.fnst@cn.fujitsu.com>
>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>
> Nack.
>
> You can simply "fix" a COLO issue by breaking a much more common usecase.

Yes, this patch is wrong. It is only in my git tree to let COLO work.

>
>
> What actually breaks in the COLO case here?

I have reported this BUG last year:
https://lists.xenproject.org/archives/html/xen-devel/2015-12/msg02850.html


Thanks
Wen Congyang

>
> ~Andrew
>
>> ---
>>   xen/arch/x86/hvm/hvm.c | 11 -----------
>>   1 file changed, 11 deletions(-)
>>
>> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
>> index 25dc759..8522852 100644
>> --- a/xen/arch/x86/hvm/hvm.c
>> +++ b/xen/arch/x86/hvm/hvm.c
>> @@ -5339,17 +5339,6 @@ static int hvmop_get_param(
>>       case HVM_PARAM_IOREQ_PFN:
>>       case HVM_PARAM_BUFIOREQ_PFN:
>>       case HVM_PARAM_BUFIOREQ_EVTCHN:
>> -    {
>> -        domid_t domid;
>> -
>> -        /* May need to create server. */
>> -        domid = d->arch.hvm_domain.params[HVM_PARAM_DM_DOMAIN];
>> -        rc = hvm_create_ioreq_server(d, domid, 1,
>> -                                     HVM_IOREQSRV_BUFIOREQ_LEGACY, NULL);
>> -        if ( rc != 0 && rc != -EEXIST )
>> -            goto out;
>> -    }
>> -    /*FALLTHRU*/
>>       default:
>>           a.value = d->arch.hvm_domain.params[a.index];
>>           break;
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel