From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH 3/5] arm64: dts: exynos5433: Add PPMU dt node Date: Wed, 07 Dec 2016 13:12:49 +0900 Message-ID: <58478C41.5090500@samsung.com> References: <1480663087-4590-1-git-send-email-cw00.choi@samsung.com> <1480663087-4590-4-git-send-email-cw00.choi@samsung.com> <20161206190756.GA12683@kozik-lap> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <20161206190756.GA12683@kozik-lap> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Krzysztof Kozlowski Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, tomasz.figa@gmail.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org, javier@osg.samsung.com, kyungmin.park@samsung.com, myungjoo.ham@samsung.com, kgene@kernel.org, s.nawrocki@samsung.com, linux-arm-kernel@lists.infradead.org List-Id: linux-samsung-soc@vger.kernel.org T24gMjAxNuuFhCAxMuyblCAwN+ydvCAwNDowNywgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToK PiBPbiBGcmksIERlYyAwMiwgMjAxNiBhdCAwNDoxODowNVBNICswOTAwLCBDaGFud29vIENob2kg d3JvdGU6Cj4+IFRoaXMgcGF0Y2ggYWRkcyBQUE1VIChQbGF0Zm9ybSBQZXJmb3JtYW5jZSBNb25p dG9yaW5nIFVuaXQpIERldmljZS10cmVlIG5vZGUKPj4gdG8gbWVhc3VyZSB0aGUgdXRpbGl6YXRp b24gb2YgZWFjaCBJUCBpbiBFeHlub3MgU29DLgo+Pgo+PiAtIFBQTVVfRHswfDF9X0NQVSBhcmUg dXNlZCB0byBtZWFzdXJlIHRoZSB1dGlsaXphdGlvbiBvZiBNSUYgKE1lbW9yeSBJbnRlcmZhY2Up Cj4+ICAgYmxvY2sgd2l0aCBWRERfTUlGIHBvd2VyIHNvdXJjZS4KPj4gLSBQUE1VX0R7MHwxfV9H RU5FUkFMIGFyZSB1c2VkIHRvIG1lYXN1cmUgdGhlIHV0aWxpemF0aW9uIG9mIElOVChJbnRlcm5h bCkKPj4gICBibG9jayB3aXRoIFZERF9JTlQgcG93ZXIgc291cmNlLgo+Pgo+PiBTaWduZWQtb2Zm LWJ5OiBDaGFud29vIENob2kgPGN3MDAuY2hvaUBzYW1zdW5nLmNvbT4KPj4gLS0tCj4+ICBhcmNo L2FybTY0L2Jvb3QvZHRzL2V4eW5vcy9leHlub3M1NDMzLmR0c2kgfCAyNCArKysrKysrKysrKysr KysrKysrKysrKysKPj4gIDEgZmlsZSBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspCj4+Cj4+IGRp ZmYgLS1naXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL2V4eW5vcy9leHlub3M1NDMzLmR0c2kgYi9h cmNoL2FybTY0L2Jvb3QvZHRzL2V4eW5vcy9leHlub3M1NDMzLmR0c2kKPj4gaW5kZXggNjQyMjZk NWFlNDcxLi44YzRlZTg0ZDUyMzIgMTAwNjQ0Cj4+IC0tLSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMv ZXh5bm9zL2V4eW5vczU0MzMuZHRzaQo+PiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL2V4eW5v cy9leHlub3M1NDMzLmR0c2kKPj4gQEAgLTU5OSw2ICs1OTksMzAgQEAKPj4gIAkJCWNsb2NrLW5h bWVzID0gImZpbl9wbGwiLCAibWN0IjsKPj4gIAkJfTsKPj4gIAo+PiArCQlwcG11X2QwX2NwdTog cHBtdUAxMDQ4MDAwMCB7Cj4+ICsJCQljb21wYXRpYmxlID0gInNhbXN1bmcsZXh5bm9zLXBwbXUt djIiOwo+PiArCQkJcmVnID0gPDB4MTA0ODAwMDAgMHgyMDAwPjsKPj4gKwkJCXN0YXR1cyA9ICJk aXNhYmxlZCI7Cj4gCj4gV2h5IHRoZXNlIGFyZSBkaXNhYmxlZD8gVGhleSBoYXZlIHNvbWUgZXh0 ZXJuYWwgZGVwZW5kZW5jaWVzPwoKVGhlcmUgaXMgbm8gYW55IGRlcGVuZGVuY3kuIElmIHlvdSB3 YW50IHRvIHJlbWFpbiBpdCBhbHdheXMgZW5hYmxlZCwKSSdtIE9LLgoKQmVzdCBSZWdhcmRzLApD aGFud29vIENob2kKCj4gCj4gQmVzdCByZWdhcmRzLAo+IEtyenlzenRvZgo+IAo+PiArCQl9Owo+ PiArCj4+ICsJCXBwbXVfZDBfZ2VuZXJhbDogcHBtdUAxMDQ5MDAwMCB7Cj4+ICsJCQljb21wYXRp YmxlID0gInNhbXN1bmcsZXh5bm9zLXBwbXUtdjIiOwo+PiArCQkJcmVnID0gPDB4MTA0OTAwMDAg MHgyMDAwPjsKPj4gKwkJCXN0YXR1cyA9ICJkaXNhYmxlZCI7Cj4+ICsJCX07Cj4+ICsKPj4gKwkJ cHBtdV9kMV9jcHU6IHBwbXVAMTA0YjAwMDAgewo+PiArCQkJY29tcGF0aWJsZSA9ICJzYW1zdW5n LGV4eW5vcy1wcG11LXYyIjsKPj4gKwkJCXJlZyA9IDwweDEwNGIwMDAwIDB4MjAwMD47Cj4+ICsJ CQlzdGF0dXMgPSAiZGlzYWJsZWQiOwo+PiArCQl9Owo+PiArCj4+ICsJCXBwbXVfZDFfZ2VuZXJh bDogcHBtdUAxMDRjMDAwMCB7Cj4+ICsJCQljb21wYXRpYmxlID0gInNhbXN1bmcsZXh5bm9zLXBw bXUtdjIiOwo+PiArCQkJcmVnID0gPDB4MTA0YzAwMDAgMHgyMDAwPjsKPj4gKwkJCXN0YXR1cyA9 ICJkaXNhYmxlZCI7Cj4+ICsJCX07Cj4+ICsKPj4gIAkJcGluY3RybF9hbGl2ZTogcGluY3RybEAx MDU4MDAwMCB7Cj4+ICAJCQljb21wYXRpYmxlID0gInNhbXN1bmcsZXh5bm9zNTQzMy1waW5jdHJs IjsKPj4gIAkJCXJlZyA9IDwweDEwNTgwMDAwIDB4MWEyMD4sIDwweDExMDkwMDAwIDB4MTAwPjsK Pj4gLS0gCj4+IDEuOS4xCj4+Cj4gCj4gCj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: cw00.choi@samsung.com (Chanwoo Choi) Date: Wed, 07 Dec 2016 13:12:49 +0900 Subject: [PATCH 3/5] arm64: dts: exynos5433: Add PPMU dt node In-Reply-To: <20161206190756.GA12683@kozik-lap> References: <1480663087-4590-1-git-send-email-cw00.choi@samsung.com> <1480663087-4590-4-git-send-email-cw00.choi@samsung.com> <20161206190756.GA12683@kozik-lap> Message-ID: <58478C41.5090500@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016? 12? 07? 04:07, Krzysztof Kozlowski wrote: > On Fri, Dec 02, 2016 at 04:18:05PM +0900, Chanwoo Choi wrote: >> This patch adds PPMU (Platform Performance Monitoring Unit) Device-tree node >> to measure the utilization of each IP in Exynos SoC. >> >> - PPMU_D{0|1}_CPU are used to measure the utilization of MIF (Memory Interface) >> block with VDD_MIF power source. >> - PPMU_D{0|1}_GENERAL are used to measure the utilization of INT(Internal) >> block with VDD_INT power source. >> >> Signed-off-by: Chanwoo Choi >> --- >> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> index 64226d5ae471..8c4ee84d5232 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> @@ -599,6 +599,30 @@ >> clock-names = "fin_pll", "mct"; >> }; >> >> + ppmu_d0_cpu: ppmu at 10480000 { >> + compatible = "samsung,exynos-ppmu-v2"; >> + reg = <0x10480000 0x2000>; >> + status = "disabled"; > > Why these are disabled? They have some external dependencies? There is no any dependency. If you want to remain it always enabled, I'm OK. Best Regards, Chanwoo Choi > > Best regards, > Krzysztof > >> + }; >> + >> + ppmu_d0_general: ppmu at 10490000 { >> + compatible = "samsung,exynos-ppmu-v2"; >> + reg = <0x10490000 0x2000>; >> + status = "disabled"; >> + }; >> + >> + ppmu_d1_cpu: ppmu at 104b0000 { >> + compatible = "samsung,exynos-ppmu-v2"; >> + reg = <0x104b0000 0x2000>; >> + status = "disabled"; >> + }; >> + >> + ppmu_d1_general: ppmu at 104c0000 { >> + compatible = "samsung,exynos-ppmu-v2"; >> + reg = <0x104c0000 0x2000>; >> + status = "disabled"; >> + }; >> + >> pinctrl_alive: pinctrl at 10580000 { >> compatible = "samsung,exynos5433-pinctrl"; >> reg = <0x10580000 0x1a20>, <0x11090000 0x100>; >> -- >> 1.9.1 >> > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753197AbcLGEXz (ORCPT ); Tue, 6 Dec 2016 23:23:55 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:39717 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751672AbcLGEXw (ORCPT ); Tue, 6 Dec 2016 23:23:52 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee61b-f796f6d000004092-78-58478c4180f2 Content-transfer-encoding: 8BIT Message-id: <58478C41.5090500@samsung.com> Date: Wed, 07 Dec 2016 13:12:49 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski Cc: javier@osg.samsung.com, kgene@kernel.org, robh+dt@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] arm64: dts: exynos5433: Add PPMU dt node References: <1480663087-4590-1-git-send-email-cw00.choi@samsung.com> <1480663087-4590-4-git-send-email-cw00.choi@samsung.com> <20161206190756.GA12683@kozik-lap> In-reply-to: <20161206190756.GA12683@kozik-lap> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBIsWRmVeSWpSXmKPExsVy+t9jQV3HHvcIg73LNSzmHznHavHm7Rom i/7Hr5ktzp/fwG5xtukNu8Wmx9dYLS7vmsNmMeP8PiaL240r2Cxa9x5htzj8pp3VYtWuP4wO PB47Z91l99i0qpPNY/OSeo8t/UBe35ZVjB6fN8kFsEW52WSkJqakFimk5iXnp2TmpdsqhYa4 6VooKeQl5qbaKkXo+oYEKSmUJeaUAnlGBmjAwTnAPVhJ3y7BLWPPsg1MBesEKt4v5WhgbODt YuTkkBAwkWhqe8sGYYtJXLi3HswWEpjFKLHogDKIzSsgKPFj8j2WLkYODmYBeYkjl7IhTHWJ KVNyuxi5gKofMEq8nXSfHaJcS6LrWisTiM0ioCrx+O8pZhCbDSi+/8UNsPH8AooSV388ZgSZ IyoQIdF9ohIkLCKgKXH973dWkJnMAuuZJKZ0TgCrFxZwlGg+94kVYtkPRok5X3exgjRzCuhL /PgfNYFRcBaSS2chXDoL4dIFjMyrGCVSC5ILipPSc43yUsv1ihNzi0vz0vWS83M3MYJj9Zn0 DsbDu9wPMQpwMCrx8EZwuEcIsSaWFVfmHmKU4GBWEuEN7AIK8aYkVlalFuXHF5XmpBYfYjQF enUis5Rocj4wjeSVxBuamJuYGxtYmFtamhgpifM2zn4WLiSQnliSmp2aWpBaBNPHxMEp1cBY rLT73KSdcyabLdLeE6phnbNs0RxGw4+ipxZNZhSR/bNU63KmU/GGkt/Zy7vez4qZ8CWsOtb/ Vsn7nuJAM4XuD7MlHbXCmN2SrjbcbLrKtljqocyu2U8VLpv2bPA/LHLxP9OEPi1u3S05p4qv nnu38pN8oMKLBBllhUUZG175ztR8WMfy75G5EktxRqKhFnNRcSIAt4NjbOsCAAA= X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 12월 07일 04:07, Krzysztof Kozlowski wrote: > On Fri, Dec 02, 2016 at 04:18:05PM +0900, Chanwoo Choi wrote: >> This patch adds PPMU (Platform Performance Monitoring Unit) Device-tree node >> to measure the utilization of each IP in Exynos SoC. >> >> - PPMU_D{0|1}_CPU are used to measure the utilization of MIF (Memory Interface) >> block with VDD_MIF power source. >> - PPMU_D{0|1}_GENERAL are used to measure the utilization of INT(Internal) >> block with VDD_INT power source. >> >> Signed-off-by: Chanwoo Choi >> --- >> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> index 64226d5ae471..8c4ee84d5232 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >> @@ -599,6 +599,30 @@ >> clock-names = "fin_pll", "mct"; >> }; >> >> + ppmu_d0_cpu: ppmu@10480000 { >> + compatible = "samsung,exynos-ppmu-v2"; >> + reg = <0x10480000 0x2000>; >> + status = "disabled"; > > Why these are disabled? They have some external dependencies? There is no any dependency. If you want to remain it always enabled, I'm OK. Best Regards, Chanwoo Choi > > Best regards, > Krzysztof > >> + }; >> + >> + ppmu_d0_general: ppmu@10490000 { >> + compatible = "samsung,exynos-ppmu-v2"; >> + reg = <0x10490000 0x2000>; >> + status = "disabled"; >> + }; >> + >> + ppmu_d1_cpu: ppmu@104b0000 { >> + compatible = "samsung,exynos-ppmu-v2"; >> + reg = <0x104b0000 0x2000>; >> + status = "disabled"; >> + }; >> + >> + ppmu_d1_general: ppmu@104c0000 { >> + compatible = "samsung,exynos-ppmu-v2"; >> + reg = <0x104c0000 0x2000>; >> + status = "disabled"; >> + }; >> + >> pinctrl_alive: pinctrl@10580000 { >> compatible = "samsung,exynos5433-pinctrl"; >> reg = <0x10580000 0x1a20>, <0x11090000 0x100>; >> -- >> 1.9.1 >> > > >