From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH 4/5] arm64: dts: exynos5433: Add bus dt node using VDD_INT for Exynos5433 Date: Wed, 07 Dec 2016 20:17:48 +0900 Message-ID: <5847EFDC.8050702@samsung.com> References: <1480663087-4590-1-git-send-email-cw00.choi@samsung.com> <1480663087-4590-5-git-send-email-cw00.choi@samsung.com> <20161206192104.GB12683@kozik-lap> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <20161206192104.GB12683@kozik-lap> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Krzysztof Kozlowski Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, tomasz.figa@gmail.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org, javier@osg.samsung.com, kyungmin.park@samsung.com, myungjoo.ham@samsung.com, kgene@kernel.org, s.nawrocki@samsung.com, linux-arm-kernel@lists.infradead.org List-Id: linux-samsung-soc@vger.kernel.org T24gMjAxNuuFhCAxMuyblCAwN+ydvCAwNDoyMSwgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToK PiBPbiBGcmksIERlYyAwMiwgMjAxNiBhdCAwNDoxODowNlBNICswOTAwLCBDaGFud29vIENob2kg d3JvdGU6Cj4+IFRoaXMgcGF0Y2ggYWRkcyB0aGUgYnVzIG5vZGVzIHVzaW5nIFZERF9JTlQgZm9y IEV4eW5vczU0MzMgU29DLgo+PiBFeHlub3M1NDMzIGhhcyB0aGUgZm9sbG93aW5nIEFNQkEgQVhJ IGJ1c2VzIHRvIHRyYW5zbGF0ZSBkYXRhCj4+IGJldHdlZW4gRFJBTSBhbmQgc3ViLWJsb2Nrcy4K Pj4KPj4gRm9sbG93aW5nIGxpc3Qgc3BlY2lmeSB0aGUgZGV0YWlsZWQgY29ycmVsYXRpb24gYmV0 d2VlbiBzdWItYmxvY2sgYW5kIGNsb2NrOgo+PiAtIENMS19BQ0xLX0cyRF97NDAwfDI2Nn0gIDog QnVzIGNsb2NrIGZvciBHMkQKPj4gLSBDTEtfQUNMS19NU0NMXzQwMCAgICAgICA6IEJ1cyBjbG9j ayBmb3IgTVNDTCAoTW9iaWxlIFNjYWxlcikKPj4gLSBDTEtfQUNMS19HU0NMXzMzMyAgICAgICA6 IEJ1cyBjbG9jayBmb3IgR1NDTCAoR2VuZXJhbCBTY2FsZXIpCj4+IC0gQ0xLX1NDTEtfSlBFR19N U0NMICAgICAgOiBCdXMgY2xvY2sgZm9yIEpQRUcKPj4gLSBDTEtfQUNMS19NRkNfNDAwICAgICAg ICA6IEJ1cyBjbG9jayBmb3IgTUZDIChNdWx0aSBGb3JtYXQgQ29kZWMpCj4+IC0gQ0xLX0FDTEtf SEVWQ180MDAgICAgICAgOiBCdXMgY2xvY2sgZm9yIEhFVkMgKEhpZ2ggRWZmZWN0aXZlIFZpZGVv IENvZGVjKQo+PiAtIENMS19BQ0xLX0JVUzBfNDAwICAgICAgIDogTm9DKE5ldHdvcmsgT24gQ2hp cCkncyBidXMgY2xvY2sgZm9yIFBFUklDL1BFUklTL0ZTWVMvTVNDTAo+PiAtIENMS19BQ0xLX0JV UzFfNDAwICAgICAgIDogTm9DJ3MgYnVzIGNsb2NrIGZvciBNRkMvSEVWQy9HM0QKPj4gLSBDTEtf QUNMS19CVVMyXzQwMCAgICAgICA6IE5vQydzIGJ1cyBjbG9jayBmb3IgR1NDTC9ESVNQL0cyRC9D QU0wL0NBTTEvSVNQCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IENoYW53b28gQ2hvaSA8Y3cwMC5jaG9p QHNhbXN1bmcuY29tPgo+PiAtLS0KPj4gIGFyY2gvYXJtNjQvYm9vdC9kdHMvZXh5bm9zL2V4eW5v czU0MzMtYnVzLmR0c2kgfCAyMDggKysrKysrKysrKysrKysrKysrKysrKysrKwo+PiAgYXJjaC9h cm02NC9ib290L2R0cy9leHlub3MvZXh5bm9zNTQzMy5kdHNpICAgICB8ICAgMSArCj4+ICAyIGZp bGVzIGNoYW5nZWQsIDIwOSBpbnNlcnRpb25zKCspCj4+ICBjcmVhdGUgbW9kZSAxMDA2NDQgYXJj aC9hcm02NC9ib290L2R0cy9leHlub3MvZXh5bm9zNTQzMy1idXMuZHRzaQo+Pgo+PiBkaWZmIC0t Z2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9leHlub3MvZXh5bm9zNTQzMy1idXMuZHRzaSBiL2Fy Y2gvYXJtNjQvYm9vdC9kdHMvZXh5bm9zL2V4eW5vczU0MzMtYnVzLmR0c2kKPj4gbmV3IGZpbGUg bW9kZSAxMDA2NDQKPj4gaW5kZXggMDAwMDAwMDAwMDAwLi5iMWUxZDljNjIyZTEKPj4gLS0tIC9k ZXYvbnVsbAo+PiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL2V4eW5vcy9leHlub3M1NDMzLWJ1 cy5kdHNpCj4+IEBAIC0wLDAgKzEsMjA4IEBACj4+ICsvKgo+PiArICogU2Ftc3VuZydzIEV4eW5v czU0MzMgU29DIE1lbW9yeSBpbnRlcmZhY2UgYW5kIEFNQkEgYnVzIGRldmljZSB0cmVlIHNvdXJj ZQo+PiArICoKPj4gKyAqIENvcHlyaWdodCAoYykgMjAxNiBTYW1zdW5nIEVsZWN0cm9uaWNzIENv LiwgTHRkLgo+PiArICogQ2hhbndvbyBDaG9pIDxjdzAwLmNob2lAc2Ftc3VuZy5jb20+Cj4+ICsg Kgo+PiArICogU2Ftc3VuZydzIEV4eW5vczU0MzMgU29DIE1lbW9yeSBpbnRlcmZhY2UgYW5kIEFN QkEgYnVzZXMgYXJlIGxpc3RlZAo+PiArICogYXMgZGV2aWNlIHRyZWUgbm9kZXMgYXJlIGxpc3Rl ZCBpbiB0aGlzIGZpbGUuCj4gCj4gVGhpcyBkdXBsaWNhdGVzIHRoZSBpbnRyb2R1Y3Rpb24gbGlu ZSBhbmQgZG9lcyBub3QgbWFrZSBzZW5zZS4KCkknbGwgcmVtb3ZlIGl0LgoKPiAKPj4gKyAqCj4+ ICsgKiBUaGlzIHByb2dyYW0gaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUg aXQgYW5kL29yIG1vZGlmeQo+PiArICogaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgR2Vu ZXJhbCBQdWJsaWMgTGljZW5zZSB2ZXJzaW9uIDIgYXMKPj4gKyAqIHB1Ymxpc2hlZCBieSB0aGUg RnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLgo+PiArICovCj4+ICsKPj4gKy8gewo+IAo+IFNob3Vs ZG4ndCB0aGVzZSBiZSB1bmRlciBzb2Mgbm9kZT8gSXQgbG9va3MgbGlrZSBwcm9wZXJ0eSBvZiBT b0MgaXRzZWxmLgoKT0suIE1vdmUgdG8gdGhlbSB1bmRlciBTb0MuCi0gIi8geyIgLT4gIiZzb2Mg eyIKCj4gCj4+ICsJLyogSU5UIChJbnRlcm5hbCkgYmxvY2sgdXNpbmcgVkREX0lOVCAqLwo+PiAr CWJ1c19nMmRfNDAwOiBidXNfZzJkXzQwMCB7Cj4gCj4gSW4gbm9kZSBuYW1lLCB0aGUgZGFzaCAn LScgaXMgcHJlZmVycmVkLiBUaGUgbmFtZSBzaG91bGQgZGVzY3JpYmUKPiBnZW5lcmFsIGNsYXNz IG9mIGRldmljZSBzbyBwcm9iYWJseSB0aGlzIHNob3VsZCBiZSBqdXN0ICJidXMiLi4uIGJ1dCBJ Cj4gZG9uJ3Qgc2VlIGEgd2F5IGhvdyB0byBkbyBpdCByZWFzb25hYmxlIGFueXdheS4KCkknbGwg Y2hhbmdlIHRoZW0gYXMgZm9sbG93aW5nIHdpdGggJ2J1c1gnLgoKVGhlIGVhY2ggZHQgbm9kZSBo YXMgdGhlIHVuaXF1ZSBudW1iZXIoJ1gnKQpiZWNhdXNlIGVhY2ggZHQgbm9kZSBkb2VzIG5vdCBo YXZlIHRoZSBiYXNlIGFkZHJlc3MKYW5kIHRoZW4gbmVlZCB0byBpZGVudGlmeSBvbmVzZWxmLgoK CWJ1c19nMmRfNDAwOiBidXMwIHsKCWJ1c19nMmRfMjY2OiBidXMxIHsKCWJ1c19nc2NsOiBidXMy IHsKCWJ1c19oZXZjOiBidXMzIHsKCWJ1c19qcGVnOiBidXM0IHsKCWJ1c19tZmM6IGJ1czUgewoJ YnVzX21zY2w6IGJ1czYgewoJYnVzX25vYzA6IGJ1czcgewoJYnVzX25vYzE6IGJ1czggewoJYnVz X25vYzI6IGJ1czkgewoKPiAKPj4gKwkJY29tcGF0aWJsZSA9ICJzYW1zdW5nLGV4eW5vcy1idXMi Owo+PiArCQljbG9ja3MgPSA8JmNtdV90b3AgQ0xLX0FDTEtfRzJEXzQwMD47Cj4+ICsJCWNsb2Nr LW5hbWVzID0gImJ1cyI7Cj4+ICsJCW9wZXJhdGluZy1wb2ludHMtdjIgPSA8JmJ1c19nMmRfNDAw X29wcF90YWJsZT47Cj4+ICsJCXN0YXR1cyA9ImRpc2FibGUiOwo+IAo+IEhtPwoKSSdsbCBmaXgg aXQuIGRpc2FibGUgLT4gZGlzYWJsZWQKCj4gCj4gCj4+ICsJfTsKPj4gKwo+PiArCWJ1c19tc2Ns OiBidXNfbXNjbCB7Cj4+ICsJCWNvbXBhdGlibGUgPSAic2Ftc3VuZyxleHlub3MtYnVzIjsKPj4g KwkJY2xvY2tzID0gPCZjbXVfdG9wIENMS19BQ0xLX01TQ0xfNDAwPjsKPj4gKwkJY2xvY2stbmFt ZXMgPSAiYnVzIjsKPj4gKwkJb3BlcmF0aW5nLXBvaW50cy12MiA9IDwmYnVzX2cyZF80MDBfb3Bw X3RhYmxlPjsKPj4gKwkJc3RhdHVzID0iZGlzYWJsZSI7Cj4+ICsJfTsKPj4gKwo+PiArCWJ1c19q cGVnOiBidXNfanBlZyB7Cj4+ICsJCWNvbXBhdGlibGUgPSAic2Ftc3VuZyxleHlub3MtYnVzIjsK Pj4gKwkJY2xvY2tzID0gPCZjbXVfdG9wIENMS19TQ0xLX0pQRUdfTVNDTD47Cj4+ICsJCWNsb2Nr LW5hbWVzID0gImJ1cyI7Cj4+ICsJCW9wZXJhdGluZy1wb2ludHMtdjIgPSA8JmJ1c19nMmRfNDAw X29wcF90YWJsZT47Cj4+ICsJCXN0YXR1cyA9ImRpc2FibGUiOwo+PiArCX07Cj4+ICsKPj4gKwli dXNfbWZjOiBidXNfbWZjIHsKPj4gKwkJY29tcGF0aWJsZSA9ICJzYW1zdW5nLGV4eW5vcy1idXMi Owo+PiArCQljbG9ja3MgPSA8JmNtdV90b3AgQ0xLX0FDTEtfTUZDXzQwMD47Cj4+ICsKPj4gKwkJ Y2xvY2stbmFtZXMgPSAiYnVzIjsKPj4gKwkJb3BlcmF0aW5nLXBvaW50cy12MiA9IDwmYnVzX2cy ZF80MDBfb3BwX3RhYmxlPjsKPj4gKwkJc3RhdHVzID0iZGlzYWJsZSI7Cj4+ICsJfTsKPj4gKwo+ PiArCWJ1c19nMmRfMjY2OiBidXNfZzJkXzI2NiB7Cj4+ICsJCWNvbXBhdGlibGUgPSAic2Ftc3Vu ZyxleHlub3MtYnVzIjsKPj4gKwkJY2xvY2tzID0gPCZjbXVfdG9wIENMS19BQ0xLX0cyRF8yNjY+ Owo+PiArCQljbG9jay1uYW1lcyA9ICJidXMiOwo+PiArCQlvcGVyYXRpbmctcG9pbnRzLXYyID0g PCZidXNfZzJkXzI2Nl9vcHBfdGFibGU+Owo+PiArCQlzdGF0dXMgPSJkaXNhYmxlIjsKPj4gKwl9 Owo+PiArCj4+ICsJYnVzX2dzY2w6IGJ1c19nc2NsIHsKPj4gKwkJY29tcGF0aWJsZSA9ICJzYW1z dW5nLGV4eW5vcy1idXMiOwo+PiArCQljbG9ja3MgPSA8JmNtdV90b3AgQ0xLX0FDTEtfR1NDTF8z MzM+Owo+PiArCQljbG9jay1uYW1lcyA9ICJidXMiOwo+PiArCQlvcGVyYXRpbmctcG9pbnRzLXYy ID0gPCZidXNfZ3NjbF9vcHBfdGFibGU+Owo+PiArCQlzdGF0dXMgPSJkaXNhYmxlIjsKPj4gKwl9 Owo+PiArCj4+ICsJYnVzX2hldmM6IGJ1c19oZXZjIHsKPj4gKwkJY29tcGF0aWJsZSA9ICJzYW1z dW5nLGV4eW5vcy1idXMiOwo+PiArCQljbG9ja3MgPSA8JmNtdV90b3AgQ0xLX0FDTEtfSEVWQ180 MDA+Owo+PiArCQljbG9jay1uYW1lcyA9ICJidXMiOwo+PiArCQlvcGVyYXRpbmctcG9pbnRzLXYy ID0gPCZidXNfaGV2Y19vcHBfdGFibGU+Owo+PiArCQlzdGF0dXMgPSJkaXNhYmxlIjsKPj4gKwl9 Owo+PiArCj4+ICsJYnVzX2J1czA6IGJ1c19idXMwIHsKPiAKPiBidXMsIGJ1cywgYnVzLCBidXMs IGphY2twb3QhIExldCdzIHRyeSB0byBmaW5kIGJldHRlciBuYW1lIGFuZCBsYWJlbCBmb3IKPiB0 aGVzZS4gOikKCkknbGwgY2hhbmdlIHRoZSBuYW1lIHdpdGggJ25vYycgcHJlZml4IGJlY2F1c2Ug dGhpcyBidXMgaXMgdXNlZApmb3IgTm9DIChOZXR3b3JrIE9uIENoaXApJ3MgYnVzIGNsb2NrIGFz IGNvbW1pdCBtc2cuCi0gb2xkIDogYnVzX2J1czAKLSBuZXcgOiBidXNfbm9jMAoKCkJlc3QgUmVn YXJkcywKQ2hhbndvbyBDaG9pCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: cw00.choi@samsung.com (Chanwoo Choi) Date: Wed, 07 Dec 2016 20:17:48 +0900 Subject: [PATCH 4/5] arm64: dts: exynos5433: Add bus dt node using VDD_INT for Exynos5433 In-Reply-To: <20161206192104.GB12683@kozik-lap> References: <1480663087-4590-1-git-send-email-cw00.choi@samsung.com> <1480663087-4590-5-git-send-email-cw00.choi@samsung.com> <20161206192104.GB12683@kozik-lap> Message-ID: <5847EFDC.8050702@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016? 12? 07? 04:21, Krzysztof Kozlowski wrote: > On Fri, Dec 02, 2016 at 04:18:06PM +0900, Chanwoo Choi wrote: >> This patch adds the bus nodes using VDD_INT for Exynos5433 SoC. >> Exynos5433 has the following AMBA AXI buses to translate data >> between DRAM and sub-blocks. >> >> Following list specify the detailed correlation between sub-block and clock: >> - CLK_ACLK_G2D_{400|266} : Bus clock for G2D >> - CLK_ACLK_MSCL_400 : Bus clock for MSCL (Mobile Scaler) >> - CLK_ACLK_GSCL_333 : Bus clock for GSCL (General Scaler) >> - CLK_SCLK_JPEG_MSCL : Bus clock for JPEG >> - CLK_ACLK_MFC_400 : Bus clock for MFC (Multi Format Codec) >> - CLK_ACLK_HEVC_400 : Bus clock for HEVC (High Effective Video Codec) >> - CLK_ACLK_BUS0_400 : NoC(Network On Chip)'s bus clock for PERIC/PERIS/FSYS/MSCL >> - CLK_ACLK_BUS1_400 : NoC's bus clock for MFC/HEVC/G3D >> - CLK_ACLK_BUS2_400 : NoC's bus clock for GSCL/DISP/G2D/CAM0/CAM1/ISP >> >> Signed-off-by: Chanwoo Choi >> --- >> arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi | 208 +++++++++++++++++++++++++ >> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 1 + >> 2 files changed, 209 insertions(+) >> create mode 100644 arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi >> new file mode 100644 >> index 000000000000..b1e1d9c622e1 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi >> @@ -0,0 +1,208 @@ >> +/* >> + * Samsung's Exynos5433 SoC Memory interface and AMBA bus device tree source >> + * >> + * Copyright (c) 2016 Samsung Electronics Co., Ltd. >> + * Chanwoo Choi >> + * >> + * Samsung's Exynos5433 SoC Memory interface and AMBA buses are listed >> + * as device tree nodes are listed in this file. > > This duplicates the introduction line and does not make sense. I'll remove it. > >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ >> + >> +/ { > > Shouldn't these be under soc node? It looks like property of SoC itself. OK. Move to them under SoC. - "/ {" -> "&soc {" > >> + /* INT (Internal) block using VDD_INT */ >> + bus_g2d_400: bus_g2d_400 { > > In node name, the dash '-' is preferred. The name should describe > general class of device so probably this should be just "bus"... but I > don't see a way how to do it reasonable anyway. I'll change them as following with 'busX'. The each dt node has the unique number('X') because each dt node does not have the base address and then need to identify oneself. bus_g2d_400: bus0 { bus_g2d_266: bus1 { bus_gscl: bus2 { bus_hevc: bus3 { bus_jpeg: bus4 { bus_mfc: bus5 { bus_mscl: bus6 { bus_noc0: bus7 { bus_noc1: bus8 { bus_noc2: bus9 { > >> + compatible = "samsung,exynos-bus"; >> + clocks = <&cmu_top CLK_ACLK_G2D_400>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_g2d_400_opp_table>; >> + status ="disable"; > > Hm? I'll fix it. disable -> disabled > > >> + }; >> + >> + bus_mscl: bus_mscl { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&cmu_top CLK_ACLK_MSCL_400>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_g2d_400_opp_table>; >> + status ="disable"; >> + }; >> + >> + bus_jpeg: bus_jpeg { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&cmu_top CLK_SCLK_JPEG_MSCL>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_g2d_400_opp_table>; >> + status ="disable"; >> + }; >> + >> + bus_mfc: bus_mfc { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&cmu_top CLK_ACLK_MFC_400>; >> + >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_g2d_400_opp_table>; >> + status ="disable"; >> + }; >> + >> + bus_g2d_266: bus_g2d_266 { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&cmu_top CLK_ACLK_G2D_266>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_g2d_266_opp_table>; >> + status ="disable"; >> + }; >> + >> + bus_gscl: bus_gscl { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&cmu_top CLK_ACLK_GSCL_333>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_gscl_opp_table>; >> + status ="disable"; >> + }; >> + >> + bus_hevc: bus_hevc { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&cmu_top CLK_ACLK_HEVC_400>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_hevc_opp_table>; >> + status ="disable"; >> + }; >> + >> + bus_bus0: bus_bus0 { > > bus, bus, bus, bus, jackpot! Let's try to find better name and label for > these. :) I'll change the name with 'noc' prefix because this bus is used for NoC (Network On Chip)'s bus clock as commit msg. - old : bus_bus0 - new : bus_noc0 Best Regards, Chanwoo Choi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752246AbcLGL2v (ORCPT ); Wed, 7 Dec 2016 06:28:51 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:37496 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751675AbcLGL2s (ORCPT ); Wed, 7 Dec 2016 06:28:48 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee61b-f796f6d000004092-b9-5847efdc67ae Content-transfer-encoding: 8BIT Message-id: <5847EFDC.8050702@samsung.com> Date: Wed, 07 Dec 2016 20:17:48 +0900 From: Chanwoo Choi Organization: Samsung Electronics User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski Cc: javier@osg.samsung.com, kgene@kernel.org, robh+dt@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] arm64: dts: exynos5433: Add bus dt node using VDD_INT for Exynos5433 References: <1480663087-4590-1-git-send-email-cw00.choi@samsung.com> <1480663087-4590-5-git-send-email-cw00.choi@samsung.com> <20161206192104.GB12683@kozik-lap> In-reply-to: <20161206192104.GB12683@kozik-lap> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJIsWRmVeSWpSXmKPExsVy+t9jAd07790jDN42aFnMP3KO1eLN2zVM Fv2PXzNbnD+/gd3ibNMbdotNj6+xWlzeNYfNYsb5fUwWtxtXsFm07j3CbnH4TTurxapdfxgd eDx2zrrL7rFpVSebx+Yl9R5b+oG8vi2rGD0+b5ILYItys8lITUxJLVJIzUvOT8nMS7dVCg1x 07VQUshLzE21VYrQ9Q0JUlIoS8wpBfKMDNCAg3OAe7CSvl2CW8bRNY/YC26oV3w8foqlgXGl fBcjJ4eEgInEryvtzBC2mMSFe+vZuhi5OIQEljJKLOjtZAVJ8AoISvyYfI+li5GDg1lAXuLI pWwIU11iypRckAohgQeMEo3fsiGqtSSaZ91hArFZBFQlHt+cyQ5iswHF97+4wQZi8wsoSlz9 8ZgRZIyoQIRE94lKkLCIgKbE9b/fWUEuYBZYzyQxpXMCWL2wQLzEwkc3mCF2/WCUOHLcG8Tm FNCXuDlxAcsERsFZSA6dhXDoLIRDFzAyr2KUSC1ILihOSs81ykst1ytOzC0uzUvXS87P3cQI jtZn0jsYD+9yP8QowMGoxMMbweEeIcSaWFZcmXuIUYKDWUmE989boBBvSmJlVWpRfnxRaU5q 8SFGU6BXJzJLiSbnAxNJXkm8oYm5ibmxgYW5paWJkZI4b+PsZ+FCAumJJanZqakFqUUwfUwc nFINjHFt3ZVXeT5EdLRNYLpbPuGSfvDD/zOYr25eECa97ZNdjNxmkeqWHK4Fid+cWZSNGgsu Gn7lve/SOO335Lwn5+qv77l6V65l+eE0oXdP3ovciZd6++8/8/UHwmc6XV9NrPzStElF9uNz +5Jb4dmP1mqFn128cmX2XtXU6Fzdf2cZWla3TzryyUqJpTgj0VCLuag4EQCkf40N7AIAAA== X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 12월 07일 04:21, Krzysztof Kozlowski wrote: > On Fri, Dec 02, 2016 at 04:18:06PM +0900, Chanwoo Choi wrote: >> This patch adds the bus nodes using VDD_INT for Exynos5433 SoC. >> Exynos5433 has the following AMBA AXI buses to translate data >> between DRAM and sub-blocks. >> >> Following list specify the detailed correlation between sub-block and clock: >> - CLK_ACLK_G2D_{400|266} : Bus clock for G2D >> - CLK_ACLK_MSCL_400 : Bus clock for MSCL (Mobile Scaler) >> - CLK_ACLK_GSCL_333 : Bus clock for GSCL (General Scaler) >> - CLK_SCLK_JPEG_MSCL : Bus clock for JPEG >> - CLK_ACLK_MFC_400 : Bus clock for MFC (Multi Format Codec) >> - CLK_ACLK_HEVC_400 : Bus clock for HEVC (High Effective Video Codec) >> - CLK_ACLK_BUS0_400 : NoC(Network On Chip)'s bus clock for PERIC/PERIS/FSYS/MSCL >> - CLK_ACLK_BUS1_400 : NoC's bus clock for MFC/HEVC/G3D >> - CLK_ACLK_BUS2_400 : NoC's bus clock for GSCL/DISP/G2D/CAM0/CAM1/ISP >> >> Signed-off-by: Chanwoo Choi >> --- >> arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi | 208 +++++++++++++++++++++++++ >> arch/arm64/boot/dts/exynos/exynos5433.dtsi | 1 + >> 2 files changed, 209 insertions(+) >> create mode 100644 arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi >> new file mode 100644 >> index 000000000000..b1e1d9c622e1 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-bus.dtsi >> @@ -0,0 +1,208 @@ >> +/* >> + * Samsung's Exynos5433 SoC Memory interface and AMBA bus device tree source >> + * >> + * Copyright (c) 2016 Samsung Electronics Co., Ltd. >> + * Chanwoo Choi >> + * >> + * Samsung's Exynos5433 SoC Memory interface and AMBA buses are listed >> + * as device tree nodes are listed in this file. > > This duplicates the introduction line and does not make sense. I'll remove it. > >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ >> + >> +/ { > > Shouldn't these be under soc node? It looks like property of SoC itself. OK. Move to them under SoC. - "/ {" -> "&soc {" > >> + /* INT (Internal) block using VDD_INT */ >> + bus_g2d_400: bus_g2d_400 { > > In node name, the dash '-' is preferred. The name should describe > general class of device so probably this should be just "bus"... but I > don't see a way how to do it reasonable anyway. I'll change them as following with 'busX'. The each dt node has the unique number('X') because each dt node does not have the base address and then need to identify oneself. bus_g2d_400: bus0 { bus_g2d_266: bus1 { bus_gscl: bus2 { bus_hevc: bus3 { bus_jpeg: bus4 { bus_mfc: bus5 { bus_mscl: bus6 { bus_noc0: bus7 { bus_noc1: bus8 { bus_noc2: bus9 { > >> + compatible = "samsung,exynos-bus"; >> + clocks = <&cmu_top CLK_ACLK_G2D_400>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_g2d_400_opp_table>; >> + status ="disable"; > > Hm? I'll fix it. disable -> disabled > > >> + }; >> + >> + bus_mscl: bus_mscl { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&cmu_top CLK_ACLK_MSCL_400>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_g2d_400_opp_table>; >> + status ="disable"; >> + }; >> + >> + bus_jpeg: bus_jpeg { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&cmu_top CLK_SCLK_JPEG_MSCL>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_g2d_400_opp_table>; >> + status ="disable"; >> + }; >> + >> + bus_mfc: bus_mfc { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&cmu_top CLK_ACLK_MFC_400>; >> + >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_g2d_400_opp_table>; >> + status ="disable"; >> + }; >> + >> + bus_g2d_266: bus_g2d_266 { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&cmu_top CLK_ACLK_G2D_266>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_g2d_266_opp_table>; >> + status ="disable"; >> + }; >> + >> + bus_gscl: bus_gscl { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&cmu_top CLK_ACLK_GSCL_333>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_gscl_opp_table>; >> + status ="disable"; >> + }; >> + >> + bus_hevc: bus_hevc { >> + compatible = "samsung,exynos-bus"; >> + clocks = <&cmu_top CLK_ACLK_HEVC_400>; >> + clock-names = "bus"; >> + operating-points-v2 = <&bus_hevc_opp_table>; >> + status ="disable"; >> + }; >> + >> + bus_bus0: bus_bus0 { > > bus, bus, bus, bus, jackpot! Let's try to find better name and label for > these. :) I'll change the name with 'noc' prefix because this bus is used for NoC (Network On Chip)'s bus clock as commit msg. - old : bus_bus0 - new : bus_noc0 Best Regards, Chanwoo Choi