From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Colin King <colin.king@canonical.com>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ppdev: don't print a free'd string
Date: Thu, 08 Dec 2016 22:13:02 +0000 [thread overview]
Message-ID: <5849DAEE.9050408@gmail.com> (raw)
In-Reply-To: <20161206105138.GA10275@kroah.com>
On Tuesday 06 December 2016 10:51 AM, Greg Kroah-Hartman wrote:
> On Fri, Dec 02, 2016 at 04:23:55PM +0000, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> A previous fix of a memory leak now prints the string 'name'
>> that was previously free'd. Fix this by free'ing the string
>> at the end of the function and adding an error exit path for
>> the error conditions.
>>
>> CoverityScan CID#1384523 ("Use after free")
>>
>> Fixes: 2bd362d5f45c1 ("ppdev: fix memory leak")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/char/ppdev.c | 13 ++++++++-----
>> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> Sudip, any thoughts?
>
Hi Greg,
Sorry for the late reply. It looks good.
Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Regards
Sudip
prev parent reply other threads:[~2016-12-08 22:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 16:23 [PATCH] ppdev: don't print a free'd string Colin King
2016-12-06 10:51 ` Greg Kroah-Hartman
2016-12-08 22:13 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5849DAEE.9050408@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=arnd@arndb.de \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.