From: Daniel Borkmann <daniel@iogearbox.net>
To: David Ahern <dsa@cumulusnetworks.com>,
netdev@vger.kernel.org, stephen@networkplumber.org
Subject: Re: [iproute2 net-next 2/8] bpf: export bpf_prog_load
Date: Sat, 10 Dec 2016 22:24:53 +0100 [thread overview]
Message-ID: <584C72A5.9020801@iogearbox.net> (raw)
In-Reply-To: <1481401934-4026-3-git-send-email-dsa@cumulusnetworks.com>
On 12/10/2016 09:32 PM, David Ahern wrote:
> Code move only; no functional change intended.
>
> Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
> ---
> include/bpf_util.h | 3 +++
> lib/bpf.c | 40 ++++++++++++++++++++--------------------
> 2 files changed, 23 insertions(+), 20 deletions(-)
>
> diff --git a/include/bpf_util.h b/include/bpf_util.h
> index 49b96bbc208f..dcbdca6978d6 100644
> --- a/include/bpf_util.h
> +++ b/include/bpf_util.h
> @@ -75,6 +75,9 @@ int bpf_trace_pipe(void);
>
> void bpf_print_ops(FILE *f, struct rtattr *bpf_ops, __u16 len);
>
> +int bpf_prog_load(enum bpf_prog_type type, const struct bpf_insn *insns,
> + size_t size_insns, const char *license, char *log,
> + size_t size_log);
Just a really minor nit: please add a newline here.
> int bpf_prog_attach(int prog_fd, int target_fd, enum bpf_attach_type type);
> int bpf_prog_detach(int target_fd, enum bpf_attach_type type);
>
next prev parent reply other threads:[~2016-12-10 21:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-10 20:32 [iproute2 v2 net-next 0/8] Add support for vrf helper David Ahern
2016-12-10 20:32 ` [iproute2 net-next 1/8] lib bpf: Add support for BPF_PROG_ATTACH and BPF_PROG_DETACH David Ahern
2016-12-10 21:16 ` Daniel Borkmann
2016-12-10 21:21 ` Daniel Borkmann
2016-12-10 22:15 ` David Ahern
2016-12-10 23:18 ` Daniel Borkmann
2016-12-10 20:32 ` [iproute2 net-next 2/8] bpf: export bpf_prog_load David Ahern
2016-12-10 21:24 ` Daniel Borkmann [this message]
2016-12-10 20:32 ` [iproute2 net-next 3/8] Add libbpf.h header with BPF_ macros David Ahern
2016-12-10 21:27 ` Daniel Borkmann
2016-12-10 20:32 ` [iproute2 net-next 4/8] move cmd_exec to lib utils David Ahern
2016-12-10 20:32 ` [iproute2 net-next 5/8] Add filesystem APIs to lib David Ahern
2016-12-10 20:32 ` [iproute2 net-next 6/8] change name_is_vrf to return index David Ahern
2016-12-10 20:32 ` [iproute2 net-next 7/8] libnetlink: Add variant of rtnl_talk that does not display RTNETLINK answers error David Ahern
2016-12-10 20:32 ` [iproute2 net-next 8/8] Introduce ip vrf command David Ahern
2016-12-12 23:43 ` [iproute2 v2 net-next 0/8] Add support for vrf helper Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2016-12-12 0:53 [iproute2 v3 " David Ahern
2016-12-12 0:53 ` [iproute2 net-next 2/8] bpf: export bpf_prog_load David Ahern
2016-12-12 9:14 ` Daniel Borkmann
2016-12-10 17:47 [iproute2 net-next 0/8] Add support for vrf helper David Ahern
2016-12-10 17:47 ` [iproute2 net-next 2/8] bpf: export bpf_prog_load David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=584C72A5.9020801@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.