All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
To: Briana Oursler <briana.oursler@gmail.com>,
	gregkh@linuxfoundation.org, forest@alittletooquiet.net,
	outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2] Staging: vt6655: Refactor switch case statement.
Date: Thu, 26 Mar 2020 18:14:11 -0700	[thread overview]
Message-ID: <584c79ff-3022-5b4d-e4e3-05a2a29befab@linux.microsoft.com> (raw)
In-Reply-To: <20200327003311.73204-1-briana.oursler@gmail.com>

On 3/26/20 5:33 PM, Briana Oursler wrote:

Hi Briana,

> Pulls some logic branches above switch case and holds outcomes in
> variables to improve readability and reduce code duplication within
> switch case.

I have copy & pasted the guidance Julia Lawall had pointed to on how 
"subject" and "patch description" should be written. Please see below:

https://kernelnewbies.org/PatchPhilosophy suggests:

In patch descriptions and in the subject, it is common and preferable to
use present-tense, imperative language. Write as if you are telling git
what to do with your patch.

It provides the following as an example of a good description:

     somedriver: fix sleep while atomic in send_a_packet()

     The send_a_packet() function is called in atomic context but takes a
     mutex, causing a sleeping while atomic warning.  Change the skb_lock
     to be a spinlock instead of a mutex to fix.

thanks,
  -lakshmi


  reply	other threads:[~2020-03-27  1:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25  4:55 [Outreachy} [PATCH] Staging: vt6655: Refactor switch case statement Briana Oursler
2020-03-25 12:35 ` Greg KH
2020-03-25 17:46   ` [Outreachy] " Briana Oursler
2020-03-25 17:48   ` Briana Oursler
2020-03-25 18:01   ` Briana Oursler
2020-03-25 19:34     ` Briana Oursler
2020-03-27  0:33   ` [PATCH v2] " Briana Oursler
2020-03-27  1:14     ` Lakshmi Ramasubramanian [this message]
2020-03-27  2:53       ` [Outreachy][PATCH v3] " Briana Oursler
2020-03-27  9:00         ` Greg KH
2020-03-27 21:32           ` [Outreachy][Patch v4] " Briana Oursler
2020-03-27 21:40             ` [Outreachy kernel] " Julia Lawall
2020-03-28  5:10               ` [patch v5] Staging: vt6655: Reduce statement complexity Briana Oursler
2020-03-28 10:19                 ` Julia Lawall
2020-03-29  1:05                   ` Briana Oursler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=584c79ff-3022-5b4d-e4e3-05a2a29befab@linux.microsoft.com \
    --to=nramas@linux.microsoft.com \
    --cc=briana.oursler@gmail.com \
    --cc=forest@alittletooquiet.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.