All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wols Lists <antlists@youngman.org.uk>
To: Mariusz Dabrowski <mariusz.dabrowski@intel.com>,
	linux-raid@vger.kernel.org
Cc: jes.sorensen@redhat.com
Subject: Re: [PATCH] Use disk sector size value to set offset for reading GPT
Date: Wed, 14 Dec 2016 18:38:44 +0000	[thread overview]
Message-ID: <585191B4.9020902@youngman.org.uk> (raw)
In-Reply-To: <cd102c85-a9d5-25a9-bf2c-706310b53cc6@intel.com>

On 14/12/16 11:04, Mariusz Dabrowski wrote:
> Hi,
> this patch affects only reading GPT from disk. It fixes minor issue when
> there
> were no warning from mdadm when user was trying to create 1-disk RAID 0
> with
> external metadata on disk with some partitions and given array size was
> smaller
> than total size of all partitions on this disk (mdadm failed to read GPT
> because it was using wrong offset).
> 
In both instances I'm thinking of, iirc, a user pulled a working array
from one machine, tried to assemble it in another, then went back to the
original machine and the GPT had disappeared.

I'm clutching a bit at straws, but when the same bug bites more than one
user, you think something must be behind it. And as you can tell from
the scenario I describe, nothing *should* have been writing to disk, yet
the disk got corrupted.

> I couldn't reproduce those incidents so I can't tell that this patch
> fixes the
> root cause of this issue.

It'll have to stay on the "mysterious" list then :-)
> 
> Regards,
> Mariusz

Cheers,
Wol


      reply	other threads:[~2016-12-14 18:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-08 11:13 [PATCH] Use disk sector size value to set offset for reading GPT Mariusz Dabrowski
2016-12-12 19:26 ` Jes Sorensen
2016-12-13 16:38 ` Wols Lists
2016-12-14 11:04   ` Mariusz Dabrowski
2016-12-14 18:38     ` Wols Lists [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=585191B4.9020902@youngman.org.uk \
    --to=antlists@youngman.org.uk \
    --cc=jes.sorensen@redhat.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=mariusz.dabrowski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.