From: liuxinliang <z.liuxinliang@hisilicon.com>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Cc: Alexey Brodkin <abrodkin@synopsys.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Xinwei Kong <kong.kongxinwei@hisilicon.com>,
Jyri Sarha <jsarha@ti.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Chen Feng <puck.chen@hisilicon.com>,
Rongrong Zou <zourongrong@gmail.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>
Subject: Re: [PATCH v4 3/5] drm: bridge: Link encoder and bridge in core code
Date: Fri, 16 Dec 2016 09:12:00 +0800 [thread overview]
Message-ID: <58533F60.10408@hisilicon.com> (raw)
In-Reply-To: <1481709550-29226-4-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On 2016/12/14 17:59, Laurent Pinchart wrote:
> int fsl_dcu_create_outputs(struct fsl_dcu_drm_device *fsl_dev)
> diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
> index 998452ad0fcb..1737e98bc10a 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
> @@ -709,10 +709,7 @@ static int dsi_bridge_init(struct drm_device *dev, struct dw_dsi *dsi)
> int ret;
>
> /* associate the bridge to dsi encoder */
> - encoder->bridge = bridge;
> - bridge->encoder = encoder;
> -
> - ret = drm_bridge_attach(dev, bridge);
> + ret = drm_bridge_attach(encoder, bridge, NULL);
> if (ret) {
> DRM_ERROR("failed to attach external bridge\n");
> return ret;
For hisilicon,
Acked-by: Xinliang Liu <z.liuxinliang@hisilicon.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-12-16 1:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 9:59 [PATCH v4 0/5] Cleanup DRM bridge attach/detach Laurent Pinchart
2016-12-14 9:59 ` [PATCH v4 1/5] drm: Don't include <drm/drm_encoder.h> in <drm/drm_crtc.h> Laurent Pinchart
2016-12-14 16:46 ` Alex Deucher
2016-12-14 9:59 ` [PATCH v4 2/5] drm: Fix compilation warning caused by static inline forward declaration Laurent Pinchart
2016-12-14 9:59 ` [PATCH v4 3/5] drm: bridge: Link encoder and bridge in core code Laurent Pinchart
2016-12-14 10:30 ` Maxime Ripard
2016-12-16 1:12 ` liuxinliang [this message]
2016-12-16 8:35 ` Archit Taneja
2016-12-16 13:29 ` Daniel Vetter
2016-12-16 13:29 ` Daniel Vetter
2016-12-23 11:10 ` Philipp Zabel
2016-12-16 9:17 ` Jyri Sarha
2016-12-14 9:59 ` [PATCH v4 4/5] drm: bridge: Detach bridge from encoder at encoder cleanup time Laurent Pinchart
2016-12-14 10:19 ` Daniel Vetter
2016-12-14 9:59 ` [PATCH v4 5/5] drm: bridge: Detach all bridges in a chain " Laurent Pinchart
2016-12-14 10:21 ` Daniel Vetter
2016-12-18 11:18 ` [PATCH v4 0/5] Cleanup DRM bridge attach/detach Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58533F60.10408@hisilicon.com \
--to=z.liuxinliang@hisilicon.com \
--cc=abrodkin@synopsys.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=maxime.ripard@free-electrons.com \
--cc=puck.chen@hisilicon.com \
--cc=sw0312.kim@samsung.com \
--cc=tomi.valkeinen@ti.com \
--cc=wens@csie.org \
--cc=zourongrong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.