From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux ACPI <linux-acpi@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Bob Moore <robert.moore@intel.com>,
Saket Dumbre <saket.dumbre@intel.com>
Subject: [PATCH 11/14] ACPICA: Add AML_NO_OPERAND_RESOLVE flag to Timer
Date: Mon, 10 Jul 2023 19:21:00 +0200 [thread overview]
Message-ID: <5856120.MhkbZ0Pkbq@kreacher> (raw)
In-Reply-To: <5698695.DvuYhMxLoT@kreacher>
From: Abhishek Mainkar <abmainkar@nvidia.com>
ACPICA commit 90310989a0790032f5a0140741ff09b545af4bc5
According to the ACPI specification 19.6.134, no argument is required to be passed for ASL Timer instruction. For taking care of no argument, AML_NO_OPERAND_RESOLVE flag is added to ASL Timer instruction opcode.
When ASL timer instruction interpreted by ACPI interpreter, getting error. After adding AML_NO_OPERAND_RESOLVE flag to ASL Timer instruction opcode, issue is not observed.
=============================================================
UBSAN: array-index-out-of-bounds in acpica/dswexec.c:401:12 index -1 is out of range for type 'union acpi_operand_object *[9]'
CPU: 37 PID: 1678 Comm: cat Not tainted
6.0.0-dev-th500-6.0.y-1+bcf8c46459e407-generic-64k
HW name: NVIDIA BIOS v1.1.1-d7acbfc-dirty 12/19/2022 Call trace:
dump_backtrace+0xe0/0x130
show_stack+0x20/0x60
dump_stack_lvl+0x68/0x84
dump_stack+0x18/0x34
ubsan_epilogue+0x10/0x50
__ubsan_handle_out_of_bounds+0x80/0x90
acpi_ds_exec_end_op+0x1bc/0x6d8
acpi_ps_parse_loop+0x57c/0x618
acpi_ps_parse_aml+0x1e0/0x4b4
acpi_ps_execute_method+0x24c/0x2b8
acpi_ns_evaluate+0x3a8/0x4bc
acpi_evaluate_object+0x15c/0x37c
acpi_evaluate_integer+0x54/0x15c
show_power+0x8c/0x12c [acpi_power_meter]
Link: https://github.com/acpica/acpica/commit/90310989
Signed-off-by: Abhishek Mainkar <abmainkar@nvidia.com>
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/acpi/acpica/psopcode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/acpica/psopcode.c b/drivers/acpi/acpica/psopcode.c
index 09029fe545f1..39e31030e5f4 100644
--- a/drivers/acpi/acpica/psopcode.c
+++ b/drivers/acpi/acpica/psopcode.c
@@ -603,7 +603,7 @@ const struct acpi_opcode_info acpi_gbl_aml_op_info[AML_NUM_OPCODES] = {
/* 7E */ ACPI_OP("Timer", ARGP_TIMER_OP, ARGI_TIMER_OP, ACPI_TYPE_ANY,
AML_CLASS_EXECUTE, AML_TYPE_EXEC_0A_0T_1R,
- AML_FLAGS_EXEC_0A_0T_1R),
+ AML_FLAGS_EXEC_0A_0T_1R | AML_NO_OPERAND_RESOLVE),
/* ACPI 5.0 opcodes */
--
2.35.3
next prev parent reply other threads:[~2023-07-10 17:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 17:10 [PATCH 00/14] ACPICA 20230628 Rafael J. Wysocki
2023-07-10 17:11 ` [PATCH 01/14] ACPICA: Fix GCC 12 dangling-pointer warning Rafael J. Wysocki
2023-07-10 17:12 ` [PATCH 02/14] ACPICA: Modify ACPI_STATE_COMMON Rafael J. Wysocki
2023-07-10 17:13 ` [PATCH 03/14] ACPICA: exserial.c: replace ternary operator with ACPI_MIN() Rafael J. Wysocki
2023-07-10 17:13 ` [PATCH 04/14] ACPICA: Add support for _DSC as per ACPI 6.5 Rafael J. Wysocki
2023-07-10 17:14 ` [PATCH 05/14] ACPICA: fix for conflict macro definition on zephyr interface Rafael J. Wysocki
2023-07-10 17:15 ` [PATCH 06/14] ACPICA: Detect GED device and keep track of _EVT Rafael J. Wysocki
2023-07-10 17:16 ` [PATCH 07/14] ACPICA: Add interrupt command to acpiexec Rafael J. Wysocki
2023-07-10 17:17 ` [PATCH 08/14] ACPICA: Fix misspelled CDAT DSMAS define Rafael J. Wysocki
2023-07-10 17:18 ` [PATCH 09/14] ACPICA: Slightly simplify an error message in acpi_ds_result_push() Rafael J. Wysocki
2023-07-10 17:20 ` [PATCH 10/14] ACPICA: Add a define for size of struct acpi_srat_generic_affinity device_handle Rafael J. Wysocki
2023-07-10 17:21 ` Rafael J. Wysocki [this message]
2023-07-10 17:21 ` [PATCH 12/14] ACPICA: MADT: Add RISC-V external interrupt controllers Rafael J. Wysocki
2023-07-10 17:22 ` [PATCH 13/14] ACPICA: RHCT: Add flags, CMO and MMU nodes Rafael J. Wysocki
2023-07-10 17:23 ` [PATCH 14/14] ACPICA: Update version to 20230628 Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5856120.MhkbZ0Pkbq@kreacher \
--to=rjw@rjwysocki.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.moore@intel.com \
--cc=saket.dumbre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.