From: Chanwoo Choi <cw00.choi@samsung.com>
To: Hans de Goede <hdegoede@redhat.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/8] extcon: axp288: Simplify axp288_handle_chrg_det_event
Date: Mon, 19 Dec 2016 15:10:34 +0900 [thread overview]
Message-ID: <585779DA.20402@samsung.com> (raw)
In-Reply-To: <20161219001313.13402-3-hdegoede@redhat.com>
Hi Hans,
On 2016년 12월 19일 09:13, Hans de Goede wrote:
> axp288_handle_chrg_det_event only gets called on change interrupts
> (so not that often), extcon_set_state_sync() checks itself if there are
> any actual changes before notifying listeners, and gpiod_set_value is
> not really expensive either.
>
> So we can simply always do both on each interrupt removing a bunch of
> somewhat magic looking code from axp288_handle_chrg_det_event.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/extcon/extcon-axp288.c | 37 ++++++++++++-------------------------
> 1 file changed, 12 insertions(+), 25 deletions(-)
Looks good to me.
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Regards,
Chanwoo Choi
next prev parent reply other threads:[~2016-12-19 6:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161219001318epcas5p1884657998ce4dd35c8ef8094fe00904f@epcas5p1.samsung.com>
2016-12-19 0:13 ` [PATCH 1/8] extcon: axp288: Remove dependency on non-existing platform_data Hans de Goede
2016-12-19 0:13 ` [PATCH 2/8] extcon: axp288: Remove usb_phy notification code Hans de Goede
2016-12-19 6:54 ` Chanwoo Choi
2016-12-19 0:13 ` [PATCH 3/8] extcon: axp288: Simplify axp288_handle_chrg_det_event Hans de Goede
2016-12-19 6:10 ` Chanwoo Choi [this message]
2016-12-19 0:13 ` [PATCH 4/8] extcon: axp288: Fix possibly reporting 2 cables in state true Hans de Goede
2016-12-19 6:27 ` Chanwoo Choi
2016-12-19 0:13 ` [PATCH 5/8] extcon: axp288: Make a couple of messages dev_info instead of dev_dbg Hans de Goede
2016-12-19 6:31 ` Chanwoo Choi
2016-12-19 0:13 ` [PATCH 6/8] extcon: axp288: Use vbus-valid instead of -present to determine cable presence Hans de Goede
2016-12-19 6:36 ` Chanwoo Choi
2016-12-19 0:13 ` [PATCH 7/8] extcon: axp288: Remove unnecessary irq?_en register writes Hans de Goede
2016-12-19 6:51 ` Chanwoo Choi
2016-12-19 0:13 ` [PATCH 8/8] extcon: axp288: Fix the module not auto-loading Hans de Goede
2016-12-19 6:51 ` Chanwoo Choi
2016-12-19 6:10 ` [PATCH 1/8] extcon: axp288: Remove dependency on non-existing platform_data Chanwoo Choi
2016-12-19 6:58 ` Chanwoo Choi
2016-12-19 8:18 ` Hans de Goede
2016-12-19 8:22 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=585779DA.20402@samsung.com \
--to=cw00.choi@samsung.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.