From: "Yu, Mingli" <mingli.yu@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] gpgme: add GPGME_STATUS_KEY_CONSIDERED
Date: Thu, 22 Dec 2016 09:52:40 +0800 [thread overview]
Message-ID: <585B31E8.60704@windriver.com> (raw)
In-Reply-To: <CAJTo0LYT4YrWxex7mOLhBsWqKR_9cmJgO66dxzCoJT-U6kWDqQ@mail.gmail.com>
On 2016年12月21日 19:14, Burton, Ross wrote:
>
> On 21 December 2016 at 08:19, <mingli.yu@windriver.com
> <mailto:mingli.yu@windriver.com>> wrote:
>
> From: Mingli Yu <Mingli.Yu@windriver.com
> <mailto:Mingli.Yu@windriver.com>>
>
> * src/gpgme.h.in <http://gpgme.h.in> (GPGME_STATUS_KEY_CONSIDERED): New.
> * src/status-table.c (KEY_CONSIDERED): New.
> * src/op-support.c (_gpgme_parse_inv_recp): Add argc KC_FPR and
> KC_FLAGS. Use calloc.
> (_gpgme_parse_key_considered): New.
> * src/sign.c (op_data_t): Add fields KC_FPR and KC_FLAGS.
> (release_op_data): Free KC_FPR.
> (_gpgme_sign_status_handler): Handle STATUS_KEY_CONSIDERED.
> * src/encrypt.c (op_data_t): Add fields KC_FPR and KC_FLAGS.
> (release_op_data): Free KC_FPR.
> (_gpgme_encrypt_status_handler): Handle STATUS_KEY_CONSIDERED.
>
> Reference:
> https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gpgme.git;a=commitdiff;h=315fb73d4a774e2c699ac1804f5377559b4d0027
> <https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gpgme.git;a=commitdiff;h=315fb73d4a774e2c699ac1804f5377559b4d0027>
>
>
> Can you explain *why* we should cherry pick a patch from upstream?
Thanks Ross!
The reason why I cherry pick this patch as there are three failed ptest
cases as below for python-pygpgme which depends on gpgme.
FAIL: test_edit_ownertrust (tests.test_editkey.EditKeyTestCase)
FAIL: test_edit_quit (tests.test_editkey.EditKeyTestCase)
FAIL: test_edit_sign (tests.test_editkey.EditKeyTestCase)
And also found the solution from
https://pagure.io/pygpgme/c/f14699792622715c9cec372400f9dc38f1122f63?branch=master
to fix the failed ptest cases for python-pygpgme, and this solution for
python-pygpgme also needs we update accordingly for gpgme.
Thanks,
Mingli
>
> Ross
prev parent reply other threads:[~2016-12-22 1:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 8:19 [PATCH] gpgme: add GPGME_STATUS_KEY_CONSIDERED mingli.yu
2016-12-21 11:14 ` Burton, Ross
2016-12-21 12:25 ` Alexander Kanavin
2016-12-22 2:24 ` Yu, Mingli
2016-12-22 14:30 ` Alexander Kanavin
2016-12-22 1:52 ` Yu, Mingli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=585B31E8.60704@windriver.com \
--to=mingli.yu@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.