From: John Fastabend <john.fastabend@gmail.com>
To: Jason Wang <jasowang@redhat.com>,
mst@redhat.com, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: john.r.fastabend@intel.com
Subject: Re: [PATCH net 3/9] virtio-net: fix page miscount during XDP linearizing
Date: Fri, 23 Dec 2016 07:54:15 -0800 [thread overview]
Message-ID: <585D48A7.3040701@gmail.com> (raw)
In-Reply-To: <1482503852-12438-4-git-send-email-jasowang@redhat.com>
On 16-12-23 06:37 AM, Jason Wang wrote:
> We don't put page during linearizing, the would cause leaking when
> xmit through XDP_TX or the packet exceeds PAGE_SIZE. Fix them by
> put page accordingly. Also decrease the number of buffers during
> linearizing to make sure caller can free buffers correctly when packet
> exceeds PAGE_SIZE. With this patch, we won't get OOM after linearize
> huge number of packets.
>
> Cc: John Fastabend <john.r.fastabend@intel.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
Thanks! looks good. By the way do you happen to have any actual
configuration where this path is hit? I obviously didn't test this
very long other than a quick test with my hacked vhost driver.
Acked-by: John Fastabend <john.r.fastabend@intel.com>
next prev parent reply other threads:[~2016-12-23 15:54 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 14:37 [PATCH net 0/9] several fixups for virtio-net XDP Jason Wang
2016-12-23 14:37 ` Jason Wang
2016-12-23 14:37 ` [PATCH net 1/9] virtio-net: remove the warning before XDP linearizing Jason Wang
2016-12-23 14:37 ` Jason Wang
2016-12-23 19:31 ` Daniel Borkmann
2016-12-27 3:08 ` Jason Wang
2016-12-27 3:08 ` Jason Wang
2016-12-23 19:31 ` Daniel Borkmann
2016-12-23 14:37 ` [PATCH net 2/9] virtio-net: correctly xmit linearized page on XDP_TX Jason Wang
2016-12-23 14:37 ` Jason Wang
2016-12-23 15:47 ` John Fastabend
2016-12-23 14:37 ` [PATCH net 3/9] virtio-net: fix page miscount during XDP linearizing Jason Wang
2016-12-23 14:37 ` Jason Wang
2016-12-23 15:54 ` John Fastabend [this message]
2016-12-26 2:30 ` Jason Wang
2016-12-26 2:30 ` Jason Wang
2016-12-23 14:37 ` [PATCH net 4/9] virtio-net: correctly handle XDP_PASS for linearized packets Jason Wang
2016-12-23 14:37 ` Jason Wang
2016-12-23 15:57 ` John Fastabend
2016-12-26 2:34 ` Jason Wang
2016-12-26 2:34 ` Jason Wang
2016-12-23 14:37 ` [PATCH net 5/9] virtio-net: unbreak csumed packets for XDP_PASS Jason Wang
2016-12-23 14:37 ` Jason Wang
2016-12-23 15:58 ` John Fastabend
2016-12-23 14:37 ` [PATCH net 6/9] virtio-net: make rx buf size estimation works for XDP Jason Wang
2016-12-23 14:37 ` Jason Wang
2016-12-23 16:02 ` John Fastabend
2016-12-23 14:37 ` [PATCH net 7/9] virtio-net: forbid XDP when VIRTIO_NET_F_GUEST_UFO is support Jason Wang
2016-12-23 14:37 ` Jason Wang
2016-12-23 16:02 ` John Fastabend
2016-12-23 16:10 ` John Fastabend
2016-12-26 2:38 ` Jason Wang
2016-12-26 2:38 ` Jason Wang
2016-12-23 14:37 ` [PATCH net 8/9] virtio-net: remove big packet XDP codes Jason Wang
2016-12-23 14:37 ` Jason Wang
2016-12-23 14:37 ` [PATCH net 9/9] virtio-net: XDP support for small buffers Jason Wang
2016-12-23 14:37 ` Jason Wang
2016-12-23 16:51 ` John Fastabend
2017-01-02 22:43 ` John Fastabend
2017-01-03 6:16 ` Jason Wang
2017-01-03 6:16 ` Jason Wang
2017-01-03 16:40 ` John Fastabend
2017-01-03 16:40 ` John Fastabend
2017-01-04 3:05 ` Jason Wang
2017-01-04 3:05 ` Jason Wang
2016-12-23 17:10 ` [PATCH net 0/9] several fixups for virtio-net XDP John Fastabend
2016-12-26 2:39 ` Jason Wang
2016-12-26 2:39 ` Jason Wang
2016-12-23 18:49 ` David Miller
2016-12-23 18:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=585D48A7.3040701@gmail.com \
--to=john.fastabend@gmail.com \
--cc=jasowang@redhat.com \
--cc=john.r.fastabend@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.