From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subject: Re: [PATCH v2 5/5] tools/blktap2/drivers: Removenon-existent sys/sysctl.h include Date: Fri, 23 Dec 2016 17:09:47 -0500 Message-ID: <585da0b3.3223ed0a.65489.a190@mx.google.com> References: <1482263220-3233-1-git-send-email-alistair.francis@xilinx.com> <1482263220-3233-6-git-send-email-alistair.francis@xilinx.com> <20161222105415.GN28690@citrix.com> <20161223111009.GR28690@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0690357263214681065==" Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKY2J-0007CB-7y for xen-devel@lists.xenproject.org; Fri, 23 Dec 2016 22:09:59 +0000 Received: by mail-qt0-f193.google.com with SMTP id d22so4882697qtd.3 for ; Fri, 23 Dec 2016 14:09:56 -0800 (PST) In-Reply-To: <20161223111009.GR28690@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Alistair Francis Cc: Wei Liu , "ian.jackson@eu.citrix.com" , Doug Goldstein , "imhy.yang@gmail.com" , "rshriram@cs.ubc.ca" , "xen-devel@lists.xenproject.org" List-Id: xen-devel@lists.xenproject.org --===============0690357263214681065== Content-Type: multipart/alternative; boundary="_BE18C240-4EFF-41A0-A3F6-49449CC3FF19_" --_BE18C240-4EFF-41A0-A3F6-49449CC3FF19_ Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hey Wei, Sorry about the top post but I=E2=80=99m doing this from my phone. That sounds good to me, you can use that commit message. Thanks, Alistair From: Wei Liu Sent: Friday, 23 December 2016 6:12 AM To: Alistair Francis Cc: Wei Liu; Doug Goldstein; ian.jackson@eu.citrix.com; imhy.yang@gmail.com= ; rshriram@cs.ubc.ca; xen-devel@lists.xenproject.org Subject: Re: [Xen-devel] [PATCH v2 5/5] tools/blktap2/drivers: Removenon-ex= istent sys/sysctl.h include On Thu, Dec 22, 2016 at 07:44:19AM -0800, Alistair Francis wrote: > On Thu, Dec 22, 2016 at 2:54 AM, Wei Liu wrote: > > On Tue, Dec 20, 2016 at 11:47:00AM -0800, Alistair Francis wrote: > >> To avoid build errors related to missing file 'sys/sysctl.h' by removi= ng > >> the #include statement. > >> > >> Signed-off-by: Alistair Francis > > > > I can find this in Linux. Maybe this is also due to the libc you're > > using? >=20 > Yes, I think you are right. I am using musl when I see the error. >=20 > > > > On the flip side, if this header is unused anyway I think I'm fine with > > taking this patch. >=20 > Thanks, that is what I was thinking too. >=20 OK. I think I will need to update the commit message to: tools/blktap2: remove unused inclusion of sys/sysctl.h =20 That header file is not used. Removing it would avoid build error with musl libc, which doesn't have that header. If you have no objection I can make the change while committing. Wei. > Thanks, >=20 > Alistair >=20 > > > >> --- > >> tools/blktap2/drivers/block-remus.c | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/tools/blktap2/drivers/block-remus.c b/tools/blktap2/drive= rs/block-remus.c > >> index 079588d..7401800 100644 > >> --- a/tools/blktap2/drivers/block-remus.c > >> +++ b/tools/blktap2/drivers/block-remus.c > >> @@ -54,7 +54,6 @@ > >> #include > >> #include > >> #include > >> -#include > >> #include > >> #include > >> > >> -- > >> 2.7.4 > >> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel --_BE18C240-4EFF-41A0-A3F6-49449CC3FF19_ Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset="utf-8"

Hey Wei,

 

Sorry about the top post but I=E2=80= =99m doing this from my phone.

 

That sounds good to me, you can use that commit messa= ge.

 

Thank= s,

Alistair

 

From: Wei Liu
<= b>Sent: Friday, 23 December 2016 6:12 AM
To: Alistair Francis
Cc: Wei Liu; Doug Goldstein; ian= .jackson@eu.citrix.com; imhy.yan= g@gmail.com; rshriram@cs.ubc.ca; xen-devel@lists.xenpr= oject.org
Subject: Re: [Xen-devel] [PATCH v2 5/5] tools/blkta= p2/drivers: Removenon-existent sys/sysctl.h include

 

On Thu, Dec 22, 2016 at 07= :44:19AM -0800, Alistair Francis wrote:

> On Thu= , Dec 22, 2016 at 2:54 AM, Wei Liu <wei.liu2@citrix.com> wrote:

> > On Tue, Dec 20, 2016 at 11:47:00AM -0800, Alis= tair Francis wrote:

> >> To avoid build er= rors related to missing file 'sys/sysctl.h' by removing

> >> the #include statement.

> >= ;>

> >> Signed-off-by: Alistair Francis= <alistair.francis@xilinx.com>

> >

<= p class=3DMsoNormal>> > I can find this in Linux. Maybe this is also = due to the libc you're

> > using?

>

> Yes, I think you are right.= I am using musl when I see the error.

>

> >

> > On the flip s= ide, if this header is unused anyway I think I'm fine with

> > taking this patch.

>

> Thanks, that is what I was thinking too.

>

 

OK. I think I will need to update the commit message to:

 

=C2=A0 tools/blkt= ap2: remove unused inclusion of sys/sysctl.h

=C2=A0=

=C2=A0=C2=A0That header file is not used. Removin= g it would avoid build error with

=C2=A0 musl libc,= which doesn't have that header.

 <= /p>

If you have no objection I can make the change whil= e committing.

 

Wei.

 

> Thanks,

>

> Al= istair

>

> >

<= p class=3DMsoNormal>> >> ---

> >>= =C2=A0 tools/blktap2/drivers/block-remus.c | 1 -

&g= t; >>=C2=A0 1 file changed, 1 deletion(-)

>= ; >>

> >> diff --git a/tools/blktap2= /drivers/block-remus.c b/tools/blktap2/drivers/block-remus.c

> >> index 079588d..7401800 100644

> >> --- a/tools/blktap2/drivers/block-remus.c

> >> +++ b/tools/blktap2/drivers/block-remus.c

> >> @@ -54,7 +54,6 @@

> &= gt;>=C2=A0 #include <netinet/in.h>

> &g= t;>=C2=A0 #include <arpa/inet.h>

> >= >=C2=A0 #include <sys/param.h>

> >&g= t; -#include <sys/sysctl.h>

> >>=C2= =A0 #include <unistd.h>

> >>=C2=A0 #= include <sys/stat.h>

> >>

> >> --

> >> 2.7.4<= /p>

> >>

 

______________________________________________= _

Xen-devel mailing list

Xe= n-devel@lists.xen.org

https://lists.xen.org/xen-dev= el

 

= --_BE18C240-4EFF-41A0-A3F6-49449CC3FF19_-- --===============0690357263214681065== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============0690357263214681065==--