From: Cui Bixuan <cuibixuan@huawei.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] rt_sigtimedwait01: fix probability of failure
Date: Wed, 28 Dec 2016 20:14:45 +0800 [thread overview]
Message-ID: <5863ACB5.8000606@huawei.com> (raw)
In-Reply-To: <585201FA.9010508@huawei.com>
If child[0] of test_masked_matching_rt() haven't had chance to
finish until we get to the sigwaitinfo() call, the case will fail.
So we should add waitpid() to make sure that both children are finished.
Signed-off-by: Cui Bixuan <cuibixuan@huawei.com>
---
testcases/kernel/syscalls/utils/common_j_h.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/testcases/kernel/syscalls/utils/common_j_h.c b/testcases/kernel/syscalls/utils/common_j_h.c
index 43165ca..784ca04 100644
--- a/testcases/kernel/syscalls/utils/common_j_h.c
+++ b/testcases/kernel/syscalls/utils/common_j_h.c
@@ -119,6 +119,7 @@ static void sigterm_handler(int sig)
pid_t create_sig_proc(unsigned long usec, int sig, unsigned count)
{
pid_t pid, cpid;
+ int status;
pid = getpid();
WITH_SIGNALS_BLOCKED(if ((cpid = fork()) == 0) {
@@ -138,6 +139,8 @@ pid_t create_sig_proc(unsigned long usec, int sig, unsigned count)
EPRINTF("fork failed.\n");
return cpid;
default:
+ /* wait cpid finish */
+ waitpid(cpid, &status, 0);
return cpid;
}
}
--
1.8.3.4
next prev parent reply other threads:[~2016-12-28 12:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 9:09 [LTP] rt_sigtimedwait01 failed in armv7l Cui Bixuan
2016-12-13 10:43 ` Cyril Hrubis
2016-12-15 2:37 ` Cui Bixuan
2016-12-28 12:14 ` Cui Bixuan [this message]
2017-01-16 13:33 ` [LTP] [PATCH] rt_sigtimedwait01: fix probability of failure Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5863ACB5.8000606@huawei.com \
--to=cuibixuan@huawei.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.